Extended: Add "system" URLRequestContext

chrome/test/testing_browser_process.cc

Index: chrome/test/testing_browser_process.cc
diff --git a/chrome/test/testing_browser_process.cc b/chrome/test/testing_browser_process.cc
index 9a4e72fba136708f30e408164ba828fc7065c74f..49826fec683596e79eb1e3445c497ada36b7e13d 100644
--- a/chrome/test/testing_browser_process.cc
+++ b/chrome/test/testing_browser_process.cc
@@ -13,6 +13,7 @@
 #include "chrome/browser/policy/dummy_configuration_policy_provider.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/common/net/url_request_context_getter.h"
 #include "ui/base/clipboard/clipboard.h"
 
 TestingBrowserProcess::TestingBrowserProcess()
@@ -113,6 +114,18 @@ TestingBrowserProcess::safe_browsing_detection_service() {
   return NULL;
 }
 
+scoped_refptr<URLRequestContextGetter>
+TestingBrowserProcess::system_request_context() {
+  return NULL;

[Mattias Nissler (ping if slow), 2011/03/09 11:04:56]

Are we prepared to handle that?

[battre, 2011/03/09 19:24:07]

Currently, there are only two use cases of system_request_context():
GoogleUrlTracker and IntranetRedirectDetector. The unit tests for
GoogleUrlTracker use a TestURLFetcherFactory which does not access the request
context. The latter has no unit tests.

In the past we had only the GetRequestContext() of TestingProfile which returned
NULL by default. I guess we can write something if we ever need it.

+}
+
+#if defined(OS_CHROMEOS)
+chromeos::ProxyConfigServiceImpl*
+TestingBrowserProcess::chromeos_proxy_config_service_impl() {
+  return NULL;

[Mattias Nissler (ping if slow), 2011/03/09 11:04:56]

same here?

[battre, 2011/03/09 19:24:07]

This was copied literally from TestingProfile.

+}
+#endif  // defined(OS_CHROMEOS)
+
 ui::Clipboard* TestingBrowserProcess::clipboard() {
   if (!clipboard_.get()) {
     // Note that we need a MessageLoop for the next call to work.