Extended: Add "system" URLRequestContext

chrome/test/testing_browser_process.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/testing_browser_process.h"
 
 #include "base/string_util.h"
 #include "base/synchronization/waitable_event.h"
 #include "chrome/browser/google/google_url_tracker.h"
 #include "chrome/browser/policy/browser_policy_connector.h"
 #include "chrome/browser/policy/configuration_policy_pref_store.h"
 #include "chrome/browser/policy/configuration_policy_provider.h"
 #include "chrome/browser/policy/dummy_configuration_policy_provider.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/common/net/url_request_context_getter.h"
 #include "ui/base/clipboard/clipboard.h"
 
 TestingBrowserProcess::TestingBrowserProcess()
     : shutdown_event_(new base::WaitableEvent(true, false)),
       module_ref_count_(0),
       app_locale_("en"),
       pref_service_(NULL) {
 }
 
 TestingBrowserProcess::~TestingBrowserProcess() {
@@ skipping 80 matching lines @@
 
 TabCloseableStateWatcher* TestingBrowserProcess::tab_closeable_state_watcher() {
   return NULL;
 }
 
 safe_browsing::ClientSideDetectionService*
 TestingBrowserProcess::safe_browsing_detection_service() {
   return NULL;
 }
 
+scoped_refptr<URLRequestContextGetter>
+TestingBrowserProcess::system_request_context() {
+  return NULL;

[Mattias Nissler (ping if slow), 2011/03/09 11:04:56]

Are we prepared to handle that?

[battre, 2011/03/09 19:24:07]

Currently, there are only two use cases of system_request_context():
GoogleUrlTracker and IntranetRedirectDetector. The unit tests for
GoogleUrlTracker use a TestURLFetcherFactory which does not access the request
context. The latter has no unit tests.

In the past we had only the GetRequestContext() of TestingProfile which returned
NULL by default. I guess we can write something if we ever need it.

+}
+
+#if defined(OS_CHROMEOS)
+chromeos::ProxyConfigServiceImpl*
+TestingBrowserProcess::chromeos_proxy_config_service_impl() {
+  return NULL;

[Mattias Nissler (ping if slow), 2011/03/09 11:04:56]

same here?

[battre, 2011/03/09 19:24:07]

This was copied literally from TestingProfile.

+}
+#endif  // defined(OS_CHROMEOS)
+
 ui::Clipboard* TestingBrowserProcess::clipboard() {
   if (!clipboard_.get()) {
     // Note that we need a MessageLoop for the next call to work.
     clipboard_.reset(new ui::Clipboard);
   }
   return clipboard_.get();
 }
 
 ExtensionEventRouterForwarder*
 TestingBrowserProcess::extension_event_router_forwarder() {
@@ skipping 100 matching lines @@
 
 ScopedTestingBrowserProcess::~ScopedTestingBrowserProcess() {
   DCHECK_EQ(browser_process_.get(), g_browser_process);
 
   // TODO(phajdan.jr): Temporary, for http://crbug.com/61062.
   // After the transition is over, we should just
   // reset |g_browser_process| to NULL.
   browser_process_.reset();
   g_browser_process = new TestingBrowserProcess();
 }