Position new windows correctly if a dock icon is shown but not highlighted....

Position new windows correctly if a dock icon is shown but not highlighted.
BUG=70409
TEST=Drag a tab to the edge of the screen so that a dock appears. Release the tab outside the dock area. Check that the tab (not the windows top-left corner) is under the cursor.

[Jamie, 2011-01-24 20:59:57]

Could you review this one-line fix? Although the ticket is untriaged, this fix
is required by my fix for bug 281 (http://codereview.chromium.org/6380007/)

[sky, 2011-01-24 21:58:48]

http://codereview.chromium.org/6288010/diff/1/chrome/browser/ui/views/tabs/dr...
File chrome/browser/ui/views/tabs/dragged_tab_controller.cc (right):

http://codereview.chromium.org/6288010/diff/1/chrome/browser/ui/views/tabs/dr...
chrome/browser/ui/views/tabs/dragged_tab_controller.cc:535: if
(dock_info_.type() != DockInfo::NONE && dock_info_.in_enable_area()) {
If dock_info_.type() == NONE then it might not contain the right screen bounds
(line 554 ish specifically).

[Jamie, 2011-01-25 17:13:02]

http://codereview.chromium.org/6288010/diff/1/chrome/browser/ui/views/tabs/dr...
File chrome/browser/ui/views/tabs/dragged_tab_controller.cc (right):

http://codereview.chromium.org/6288010/diff/1/chrome/browser/ui/views/tabs/dr...
chrome/browser/ui/views/tabs/dragged_tab_controller.cc:535: if
(dock_info_.type() != DockInfo::NONE && dock_info_.in_enable_area()) {
On 2011/01/24 21:58:48, sky wrote:
> If dock_info_.type() == NONE then it might not contain the right screen bounds
> (line 554 ish specifically).

Can you clarify what you mean by this? If dock_info.type() == NONE, then this
patch doesn't change the behavior. The new condition is based on the one in
DockInfo::GetNewWindowBounds (line 123).

[sky, 2011-01-25 17:52:26]

LGTM

Sorry, I was confusing this with your patch
(http://codereview.chromium.org/6380007/).

  -Scott

[Jamie, 2011-01-25 17:57:14]

On 2011/01/25 17:52:26, sky wrote:
> LGTM
> 
> Sorry, I was confusing this with your patch
> (http://codereview.chromium.org/6380007/).
> 
>   -Scott

Thanks for the review. Could you commit this for me please? I don't have
committer status yet.

[sky, 2011-01-25 21:33:17]

Landed @ 72546

  -Scott

On Tue, Jan 25, 2011 at 9:57 AM,  <jamiewalch@chromium.org> wrote:
> On 2011/01/25 17:52:26, sky wrote:
>>
>> LGTM
>
>> Sorry, I was confusing this with your patch
>> (http://codereview.chromium.org/6380007/).
>
>>   -Scott
>
> Thanks for the review. Could you commit this for me please? I don't have
> committer status yet.
>
> http://codereview.chromium.org/6288010/
>