Position new windows correctly if a dock icon is shown but not highlighted....

chrome/browser/ui/views/tabs/dragged_tab_controller.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/tabs/dragged_tab_controller.h"
 
 #include <math.h>
 #include <set>
 
 #include "base/callback.h"
@@ skipping 514 matching lines @@
 }
 
 void DraggedTabController::UpdateWindowCreatePoint() {
   // See comments in InitWindowCreatePoint for details on this.
   window_create_point_ = first_source_tab_point_;
   window_create_point_.Offset(mouse_offset_.x(), mouse_offset_.y());
 }
 
 gfx::Point DraggedTabController::GetWindowCreatePoint() const {
   gfx::Point cursor_point = GetCursorScreenPoint();
-  if (dock_info_.type() != DockInfo::NONE) {
+  if (dock_info_.type() != DockInfo::NONE && dock_info_.in_enable_area()) {

[sky, 2011/01/24 21:58:48]

If dock_info_.type() == NONE then it might not contain the right screen bounds
(line 554 ish specifically).

[Jamie, 2011/01/25 17:13:02]

Can you clarify what you mean by this? If dock_info.type() == NONE, then this
patch doesn't change the behavior. The new condition is based on the one in
DockInfo::GetNewWindowBounds (line 123).

     // If we're going to dock, we need to return the exact coordinate,
     // otherwise we may attempt to maximize on the wrong monitor.
     return cursor_point;
   }
   return gfx::Point(cursor_point.x() - window_create_point_.x(),
                     cursor_point.y() - window_create_point_.y());
 }
 
 void DraggedTabController::UpdateDockInfo(const gfx::Point& screen_point) {
   // Update the DockInfo for the current mouse coordinates.
@@ skipping 790 matching lines @@
 #else
     NOTIMPLEMENTED();
 #endif
   }
 }
 
 TabStripModel* DraggedTabController::GetModel(BaseTabStrip* tabstrip) const {
   return static_cast<BrowserTabStripController*>(tabstrip->controller())->
       model();
 }