Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 6287041: Avoid callbacks to user code during error formatting in a couple of (Closed)

Created:
9 years, 10 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Avoid callbacks to user code during error formatting in a couple of other situations. Do not use overwritten Object.prototype.hasOwnProperty and Array.prototype.pop. Do not use split and join in the error formatting implementation. They are too big to control and their generality is not needed. Committed: http://code.google.com/p/v8/source/detail?r=6552

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -99 lines) Patch
M src/array.js View 1 chunk +1 line, -1 line 2 comments Download
M src/messages.js View 3 chunks +95 lines, -91 lines 0 comments Download
M src/mirror-debugger.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +16 lines, -4 lines 0 comments Download
M test/mjsunit/mirror-error.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (chromium)
9 years, 10 months ago (2011-02-01 12:11:17 UTC) #1
Søren Thygesen Gjesse
LGTM http://codereview.chromium.org/6287041/diff/1/src/array.js File src/array.js (right): http://codereview.chromium.org/6287041/diff/1/src/array.js#newcode174 src/array.js:174: // Make sure to pop the visited array ...
9 years, 10 months ago (2011-02-01 12:23:02 UTC) #2
Mads Ager (chromium)
9 years, 10 months ago (2011-02-01 12:29:45 UTC) #3
http://codereview.chromium.org/6287041/diff/1/src/array.js
File src/array.js (right):

http://codereview.chromium.org/6287041/diff/1/src/array.js#newcode174
src/array.js:174: // Make sure to pop the visited array no matter what happens.
On 2011/02/01 12:23:02, Søren Gjesse wrote:
> pop -> remove the last element?

Done.

Powered by Google App Engine
This is Rietveld 408576698