Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: src/array.js

Issue 6287041: Avoid callbacks to user code during error formatting in a couple of (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/messages.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/array.js
diff --git a/src/array.js b/src/array.js
index 0d7a7cbc85e1f89a490d229fa759d047b3966fa6..80cc89932a7911f9c56c3aedef8f064f0a49bc88 100644
--- a/src/array.js
+++ b/src/array.js
@@ -172,7 +172,7 @@ function Join(array, length, separator, convert) {
return %StringBuilderConcat(elements, length2, '');
} finally {
// Make sure to pop the visited array no matter what happens.
Søren Thygesen Gjesse 2011/02/01 12:23:02 pop -> remove the last element?
Mads Ager (chromium) 2011/02/01 12:29:45 Done.
- if (is_array) visited_arrays.pop();
+ if (is_array) visited_arrays.length = visited_arrays.length - 1;
}
}
« no previous file with comments | « no previous file | src/messages.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698