Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 6286102: CHROMIUM: verity: remove dead code in dm_bht_verify_path (Closed)

Created:
9 years, 10 months ago by Mandeep Singh Baines
Modified:
9 years, 7 months ago
Reviewers:
Will Drewry
CC:
chromium-os-reviews_chromium.org, vb+kernel_google.com, Olof Johansson, msb+croskernel_chromium.org
Visibility:
Public.

Description

CHROMIUM: verity: remove dead code in dm_bht_verify_path The depth == 0 check is no longer necessary as depth can never be zero at this point. We check depth > 0 at the top of the while loop and only decrement depth at the bottom and before the continue. BUG=9752 TEST= Ran dm-verity.git unit tests. Ran platform_DMVerityCorruption on H/W. Change-Id: Ie3854a2b71b36ea4cb6b2114e298f6a424f707b5 Signed-off-by: Mandeep Singh Baines <msb@chromium.org>; Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=acafb2e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M drivers/md/dm-bht.c View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mandeep Singh Baines
9 years, 10 months ago (2011-02-04 02:53:54 UTC) #1
Mandeep Singh Baines
ping
9 years, 10 months ago (2011-02-09 02:23:27 UTC) #2
Will Drewry
LGTM as per the other cl, that code is unreachable, so it's a nop :)
9 years, 10 months ago (2011-02-11 19:37:36 UTC) #3
Will Drewry
Btw, weren't there some other issues that came out of that now dead cl? :/
9 years, 10 months ago (2011-02-11 19:38:09 UTC) #4
Mandeep Singh Baines
9 years, 10 months ago (2011-02-11 21:22:34 UTC) #5
wad@chromium.org (wad@chromium.org) wrote:
> Btw, weren't there some other issues that came out of that now dead cl? :/
> 

I think the issues were all in the CL and not in the existing code. Kinda
embarassed by that CL now. Not sure what I was thinking. But I'll double
check the CL to be sure.

> http://codereview.chromium.org/6286102/

Powered by Google App Engine
This is Rietveld 408576698