Issue 6283012: Do not shuffle parameters when doing sub on ia32 and arm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6283012: Do not shuffle parameters when doing sub on ia32 and arm. (Closed)

Created:
9 years, 11 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Do not shuffle parameters when doing sub on ia32 and arm. Committed: http://code.google.com/p/v8/source/detail?r=6458

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	src/arm/lithium-arm.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	src/ia32/lithium-ia32.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

William Hesse

9 years, 11 months ago (2011-01-25 12:02:17 UTC) #2

LGTM.  It worked before because LeastConstantOperand included a check that the
operation was commutative.