Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 6283012: Do not shuffle parameters when doing sub on ia32 and arm. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1309 matching lines...) Expand 10 before | Expand all | Expand 10 after
1320 ASSERT(instr->representation().IsTagged()); 1320 ASSERT(instr->representation().IsTagged());
1321 return DoArithmeticT(Token::MUL, instr); 1321 return DoArithmeticT(Token::MUL, instr);
1322 } 1322 }
1323 } 1323 }
1324 1324
1325 1325
1326 LInstruction* LChunkBuilder::DoSub(HSub* instr) { 1326 LInstruction* LChunkBuilder::DoSub(HSub* instr) {
1327 if (instr->representation().IsInteger32()) { 1327 if (instr->representation().IsInteger32()) {
1328 ASSERT(instr->left()->representation().IsInteger32()); 1328 ASSERT(instr->left()->representation().IsInteger32());
1329 ASSERT(instr->right()->representation().IsInteger32()); 1329 ASSERT(instr->right()->representation().IsInteger32());
1330 LOperand* left = UseRegisterAtStart(instr->LeastConstantOperand()); 1330 LOperand* left = UseRegisterAtStart(instr->left());
1331 LOperand* right = UseOrConstantAtStart(instr->MostConstantOperand()); 1331 LOperand* right = UseOrConstantAtStart(instr->right());
1332 LSubI* sub = new LSubI(left, right); 1332 LSubI* sub = new LSubI(left, right);
1333 LInstruction* result = DefineSameAsFirst(sub); 1333 LInstruction* result = DefineSameAsFirst(sub);
1334 if (instr->CheckFlag(HValue::kCanOverflow)) { 1334 if (instr->CheckFlag(HValue::kCanOverflow)) {
1335 result = AssignEnvironment(result); 1335 result = AssignEnvironment(result);
1336 } 1336 }
1337 return result; 1337 return result;
1338 } else if (instr->representation().IsDouble()) { 1338 } else if (instr->representation().IsDouble()) {
1339 return DoArithmeticD(Token::SUB, instr); 1339 return DoArithmeticD(Token::SUB, instr);
1340 } else { 1340 } else {
1341 ASSERT(instr->representation().IsTagged()); 1341 ASSERT(instr->representation().IsTagged());
(...skipping 549 matching lines...) Expand 10 before | Expand all | Expand 10 after
1891 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) { 1891 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) {
1892 HEnvironment* outer = current_block_->last_environment()->outer(); 1892 HEnvironment* outer = current_block_->last_environment()->outer();
1893 current_block_->UpdateEnvironment(outer); 1893 current_block_->UpdateEnvironment(outer);
1894 return NULL; 1894 return NULL;
1895 } 1895 }
1896 1896
1897 1897
1898 } } // namespace v8::internal 1898 } } // namespace v8::internal
1899 1899
1900 #endif // V8_TARGET_ARCH_IA32 1900 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698