Adjust Unix domain IPC permissions.

Adjust unix domain IPC permissions.


BUG=chromium-os:7473
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72007

[dtu, 2011-01-19 23:51:39]

+dmaclach for review

[dmac, 2011-01-19 23:54:37]

http://codereview.chromium.org/6280009/diff/1/ipc/ipc_channel_posix.cc
File ipc/ipc_channel_posix.cc (right):

http://codereview.chromium.org/6280009/diff/1/ipc/ipc_channel_posix.cc#newcod...
ipc/ipc_channel_posix.cc:170: // Make sure the path we need exists.
thanks for catching the comments

http://codereview.chromium.org/6280009/diff/1/ipc/ipc_channel_posix.cc#newcod...
ipc/ipc_channel_posix.cc:197: fchmod(fd, 0600);
can you check this for errors? and then PLOG as appropriate?

[dtu, 2011-01-19 23:59:18]

http://codereview.chromium.org/6280009/diff/1/ipc/ipc_channel_posix.cc
File ipc/ipc_channel_posix.cc (right):

http://codereview.chromium.org/6280009/diff/1/ipc/ipc_channel_posix.cc#newcod...
ipc/ipc_channel_posix.cc:197: fchmod(fd, 0600);
On 2011/01/19 23:54:37, dmac wrote:
> can you check this for errors? and then PLOG as appropriate?

Done.

[dmac, 2011-01-20 00:08:58]

LGTM

[Nirnimesh, 2011-01-21 02:41:55]

http://codereview.chromium.org/6280009/diff/9001/ipc/ipc_channel_posix.cc
File ipc/ipc_channel_posix.cc (right):

http://codereview.chromium.org/6280009/diff/9001/ipc/ipc_channel_posix.cc#new...
ipc/ipc_channel_posix.cc:198: PLOG(ERROR) << "fchmod " << pipe_name;
s/fchmod/chmod/