Adjust Unix domain IPC permissions.

ipc/ipc_channel_posix.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ipc/ipc_channel_posix.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <stddef.h>
 #include <sys/types.h>
@@ skipping 149 matching lines @@
   if (fcntl(fd, F_SETFL, O_NONBLOCK) == -1) {
     PLOG(ERROR) << "fcntl(O_NONBLOCK) " << pipe_name;
     if (HANDLE_EINTR(close(fd)) < 0)
       PLOG(ERROR) << "close " << pipe_name;
     return false;
   }
 
   // Delete any old FS instances.
   unlink(pipe_name.c_str());
 
-    // Make sure the path we need exists.
+  // Make sure the path we need exists.

[dmac, 2011/01/19 23:54:37]

thanks for catching the comments

   FilePath path(pipe_name);
   FilePath dir_path = path.DirName();
   if (!file_util::CreateDirectory(dir_path)) {
     return false;
   }
 
-  // Create unix_addr structure
+  // Create unix_addr structure.
   struct sockaddr_un unix_addr;
   memset(&unix_addr, 0, sizeof(unix_addr));
   unix_addr.sun_family = AF_UNIX;
   int path_len = snprintf(unix_addr.sun_path, IPC::kMaxPipeNameLength,
                           "%s", pipe_name.c_str());
   DCHECK_EQ(static_cast<int>(pipe_name.length()), path_len);
   size_t unix_addr_len = offsetof(struct sockaddr_un,
                                        sun_path) + path_len + 1;
 
   // Bind the socket.
   if (bind(fd, reinterpret_cast<const sockaddr*>(&unix_addr),
            unix_addr_len) != 0) {
     PLOG(ERROR) << "bind " << pipe_name;
     if (HANDLE_EINTR(close(fd)) < 0)
       PLOG(ERROR) << "close " << pipe_name;
     return false;
   }
 
+  // Adjust the socket permissions.
+  fchmod(fd, 0600);

[dmac, 2011/01/19 23:54:37]

can you check this for errors? and then PLOG as appropriate?

[dtu, 2011/01/19 23:59:18]

Done.

+
   // Start listening on the socket.
   const int listen_queue_length = 1;
   if (listen(fd, listen_queue_length) != 0) {
     PLOG(ERROR) << "listen " << pipe_name;
     if (HANDLE_EINTR(close(fd)) < 0)
       PLOG(ERROR) << "close " << pipe_name;
     return false;
   }
 
   *server_listen_fd = fd;
@@ skipping 943 matching lines @@
 
 bool Channel::HasAcceptedConnection() const {
   return channel_impl_->HasAcceptedConnection();
 }
 
 void Channel::ResetToAcceptingConnectionState() {
   channel_impl_->ResetToAcceptingConnectionState();
 }
 
 }  // namespace IPC