Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: chrome/renderer/navigation_state.h

Issue 6276001: Fix two bugs in recording web timing histograms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/page_load_histograms.cc » ('j') | chrome/renderer/page_load_histograms.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/navigation_state.h
diff --git a/chrome/renderer/navigation_state.h b/chrome/renderer/navigation_state.h
index ab34b123b08d2a8b967c82d4ae799b894fd0b62d..a53bbaadeb6c37ca9ef74827632769df40ffa544 100644
--- a/chrome/renderer/navigation_state.h
+++ b/chrome/renderer/navigation_state.h
@@ -160,6 +160,13 @@ class NavigationState : public WebKit::WebDataSource::ExtraData {
load_histograms_recorded_ = value;
}
+ bool web_timing_histograms_recorded() const {
+ return web_timing_histograms_recorded_;
+ }
+ void set_web_timing_histograms_recorded(bool value) {
+ web_timing_histograms_recorded_ = value;
+ }
+
// True if we have already processed the "DidCommitLoad" event for this
// request. Used by session history.
bool request_committed() const { return request_committed_; }
@@ -281,6 +288,7 @@ class NavigationState : public WebKit::WebDataSource::ExtraData {
base::Time first_paint_time_;
base::Time first_paint_after_load_time_;
bool load_histograms_recorded_;
+ bool web_timing_histograms_recorded_;
jar (doing other things) 2011/01/13 17:42:20 Please add a constructor initializer for this to n
tonyg 2011/01/13 22:14:07 Good catch. That would have been bad.
bool request_committed_;
bool is_content_initiated_;
int32 pending_page_id_;
« no previous file with comments | « no previous file | chrome/renderer/page_load_histograms.cc » ('j') | chrome/renderer/page_load_histograms.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698