Fix two bugs in recording web timing histograms.

chrome/renderer/navigation_state.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_RENDERER_NAVIGATION_STATE_H_
 #define CHROME_RENDERER_NAVIGATION_STATE_H_
 #pragma once
 
 #include <string>
 
@@ skipping 142 matching lines @@
   void set_first_paint_after_load_time(const base::Time& value) {
     first_paint_after_load_time_ = value;
   }
 
   // True iff the histograms for the associated frame have been dumped.
   bool load_histograms_recorded() const { return load_histograms_recorded_; }
   void set_load_histograms_recorded(bool value) {
     load_histograms_recorded_ = value;
   }
 
+  bool web_timing_histograms_recorded() const {
+    return web_timing_histograms_recorded_;
+  }
+  void set_web_timing_histograms_recorded(bool value) {
+    web_timing_histograms_recorded_ = value;
+  }
+
   // True if we have already processed the "DidCommitLoad" event for this
   // request.  Used by session history.
   bool request_committed() const { return request_committed_; }
   void set_request_committed(bool value) { request_committed_ = value; }
 
   // True if this navigation was not initiated via WebFrame::LoadRequest.
   bool is_content_initiated() const { return is_content_initiated_; }
 
   const GURL& searchable_form_url() const { return searchable_form_url_; }
   void set_searchable_form_url(const GURL& url) { searchable_form_url_ = url; }
@@ skipping 101 matching lines @@
   PageTransition::Type transition_type_;
   LoadType load_type_;
   base::Time request_time_;
   base::Time start_load_time_;
   base::Time commit_load_time_;
   base::Time finish_document_load_time_;
   base::Time finish_load_time_;
   base::Time first_paint_time_;
   base::Time first_paint_after_load_time_;
   bool load_histograms_recorded_;
+  bool web_timing_histograms_recorded_;

[jar (doing other things), 2011/01/13 17:42:20]

Please add a constructor initializer for this to navigation_state.cc

[tonyg, 2011/01/13 22:14:07]

Good catch. That would have been bad.

   bool request_committed_;
   bool is_content_initiated_;
   int32 pending_page_id_;
   int pending_history_list_offset_;
   GURL searchable_form_url_;
   std::string searchable_form_encoding_;
   scoped_ptr<webkit_glue::PasswordForm> password_form_data_;
   scoped_ptr<webkit_glue::AltErrorPageResourceFetcher> alt_error_page_fetcher_;
   std::string security_info_;
   bool postpone_loading_data_;
@@ skipping 13 matching lines @@
   bool was_within_same_page_;
 
   // A prefetcher is a page that contains link rel=prefetch elements.
   bool was_prefetcher_;
   bool was_referred_by_prefetcher_;
 
   DISALLOW_COPY_AND_ASSIGN(NavigationState);
 };
 
 #endif  // CHROME_RENDERER_NAVIGATION_STATE_H_