Fix two bugs in recording web timing histograms.

Fix two bugs in recording web timing histograms.
1. Record them prior to the missing-start shortcut.
2. Don't share a recorded boolean with the legacy times.

TEST=NONE
BUG=NONE

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71452

[James Simonsen, 2011-01-13 03:35:18]

LGTM

http://codereview.chromium.org/6276001/diff/1/chrome/renderer/page_load_histo...
File chrome/renderer/page_load_histograms.cc (right):

http://codereview.chromium.org/6276001/diff/1/chrome/renderer/page_load_histo...
chrome/renderer/page_load_histograms.cc:106: navigation_state);
Line up with (.

[jar (doing other things), 2011-01-13 17:42:20]

http://codereview.chromium.org/6276001/diff/1/chrome/renderer/navigation_state.h
File chrome/renderer/navigation_state.h (right):

http://codereview.chromium.org/6276001/diff/1/chrome/renderer/navigation_stat...
chrome/renderer/navigation_state.h:291: bool web_timing_histograms_recorded_;
Please add a constructor initializer for this to navigation_state.cc

[tonyg, 2011-01-13 22:14:07]

http://codereview.chromium.org/6276001/diff/1/chrome/renderer/navigation_state.h
File chrome/renderer/navigation_state.h (right):

http://codereview.chromium.org/6276001/diff/1/chrome/renderer/navigation_stat...
chrome/renderer/navigation_state.h:291: bool web_timing_histograms_recorded_;
On 2011/01/13 17:42:20, jar wrote:
> Please add a constructor initializer for this to navigation_state.cc

Good catch. That would have been bad.

http://codereview.chromium.org/6276001/diff/1/chrome/renderer/page_load_histo...
File chrome/renderer/page_load_histograms.cc (right):

http://codereview.chromium.org/6276001/diff/1/chrome/renderer/page_load_histo...
chrome/renderer/page_load_histograms.cc:106: navigation_state);
On 2011/01/13 03:35:28, James Simonsen wrote:
> Line up with (.

Done.

[tonyg, 2011-01-14 16:53:26]

Jim, do you have anything else or should I take James' LGTM?

On Thu, Jan 13, 2011 at 2:14 PM,  <tonyg@chromium.org> wrote:
>
>
http://codereview.chromium.org/6276001/diff/1/chrome/renderer/navigation_state.h
> File chrome/renderer/navigation_state.h (right):
>
>
http://codereview.chromium.org/6276001/diff/1/chrome/renderer/navigation_stat...
> chrome/renderer/navigation_state.h:291: bool
> web_timing_histograms_recorded_;
> On 2011/01/13 17:42:20, jar wrote:
>>
>> Please add a constructor initializer for this to navigation_state.cc
>
> Good catch. That would have been bad.
>
>
http://codereview.chromium.org/6276001/diff/1/chrome/renderer/page_load_histo...
> File chrome/renderer/page_load_histograms.cc (right):
>
>
http://codereview.chromium.org/6276001/diff/1/chrome/renderer/page_load_histo...
> chrome/renderer/page_load_histograms.cc:106: navigation_state);
> On 2011/01/13 03:35:28, James Simonsen wrote:
>>
>> Line up with (.
>
> Done.
>
> http://codereview.chromium.org/6276001/
>

[jar (doing other things), 2011-01-14 17:05:10]

LGTM