Issue 6269014: DOMUI: Delay loading the password lists until the password manager is shown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6269014: DOMUI: Delay loading the password lists until the password manager is shown. (Closed)

Created:
9 years, 11 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

DOMUI: Delay loading the password lists until the password manager is shown. BUG=67716 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72056

Patch Set 2 : Review fixes 1. #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/browser/resources/options/password_manager.js	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

LGTM http://codereview.chromium.org/6269014/diff/1/chrome/browser/resources/options/password_manager.js File chrome/browser/resources/options/password_manager.js (right): http://codereview.chromium.org/6269014/diff/1/chrome/browser/resources/options/password_manager.js#newcode51 chrome/browser/resources/options/password_manager.js:51: didShowPage: function() { /** @inheritDoc */ http://codereview.chromium.org/6269014/diff/1/chrome/browser/resources/options/password_manager.js#newcode54 chrome/browser/resources/options/password_manager.js:54: ...

9 years, 11 months ago (2011-01-21 00:23:37 UTC) #2

James Hawkins

9 years, 11 months ago (2011-01-21 00:37:33 UTC) #3

http://codereview.chromium.org/6269014/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/password_manager.js (right):

http://codereview.chromium.org/6269014/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/password_manager.js:51: didShowPage: function()
{
On 2011/01/21 00:23:37, stuartmorgan wrote:
> /** @inheritDoc */

Done.

http://codereview.chromium.org/6269014/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/password_manager.js:54:
chrome.send('updatePasswordLists');
On 2011/01/21 00:23:37, stuartmorgan wrote:
> I assume this is okay to call more than once?

Correct.

Expand Messages | Collapse Messages

Issue 6269014: DOMUI: Delay loading the password lists until the password manager is shown. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Review fixes 1. #

Messages