Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: chrome/browser/resources/options/password_manager.js

Issue 6269014: DOMUI: Delay loading the password lists until the password manager is shown. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes 1. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/password_manager.js
diff --git a/chrome/browser/resources/options/password_manager.js b/chrome/browser/resources/options/password_manager.js
index ac3fc3aa67bfa2a750755578e0db3239dcb96ab5..a4ac06bdc82b8dfde2852fcbeacbfb052904545c 100644
--- a/chrome/browser/resources/options/password_manager.js
+++ b/chrome/browser/resources/options/password_manager.js
@@ -41,12 +41,18 @@ cr.define('options', function() {
*/
passwordExceptionsList_: null,
+ /** @inheritDoc */
initializePage: function() {
OptionsPage.prototype.initializePage.call(this);
this.createSavedPasswordsList_();
this.createPasswordExceptionsList_();
+ },
+ /** @inheritDoc */
+ didShowPage: function() {
+ // Updating the password lists may cause a blocking platform dialog pop up
+ // (Mac, Linux), so we delay this operation until the page is shown.
chrome.send('updatePasswordLists');
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698