Remove dead code per email with aa about the TODO saying that

Remove dead code per email with aa about the TODO saying that
this isn't needed any more.


BUG=none
TEST=trybots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71759

[Alex Nicolaou, 2011-01-17 20:55:35]

Aaron, per our somewhat stale email discussion - removing these lines.

Also, is there a manual test you'd like me to do to verify this is OK?

thanks
alex

[Aaron Boodman, 2011-01-18 23:00:53]

http://codereview.chromium.org/6269010/diff/1/chrome/browser/renderer_host/re...
File chrome/browser/renderer_host/render_view_host.cc (left):

http://codereview.chromium.org/6269010/diff/1/chrome/browser/renderer_host/re...
chrome/browser/renderer_host/render_view_host.cc:178:
webkit_prefs.databases_enabled = true;
Does this mean that these preferences will always be on, or is there some other
thing that can toggle them?

[Alex Nicolaou, 2011-01-19 00:43:37]

http://codereview.chromium.org/6269010/diff/1/chrome/browser/renderer_host/re...
File chrome/browser/renderer_host/render_view_host.cc (left):

http://codereview.chromium.org/6269010/diff/1/chrome/browser/renderer_host/re...
chrome/browser/renderer_host/render_view_host.cc:178:
webkit_prefs.databases_enabled = true;
On 2011/01/18 23:00:53, Aaron Boodman wrote:
> Does this mean that these preferences will always be on, or is there some
other
> thing that can toggle them?

I wouldn't know, I was going based on your TODO above and our email thread where
I asked if this could be removed :-)

My interpretation (but I'm just guessing) is that now that databases and local
storage are on by default, they'll be on when this code runs. But if I turn them
off, then they'll be off for my extensions too (which would be a change in
behaviour).

[Aaron Boodman, 2011-01-19 02:54:02]

On 2011/01/19 00:43:37, Alex Nicolaou wrote:
>
http://codereview.chromium.org/6269010/diff/1/chrome/browser/renderer_host/re...
> File chrome/browser/renderer_host/render_view_host.cc (left):
> 
>
http://codereview.chromium.org/6269010/diff/1/chrome/browser/renderer_host/re...
> chrome/browser/renderer_host/render_view_host.cc:178:
> webkit_prefs.databases_enabled = true;
> On 2011/01/18 23:00:53, Aaron Boodman wrote:
> > Does this mean that these preferences will always be on, or is there some
> other
> > thing that can toggle them?
> 
> I wouldn't know, I was going based on your TODO above and our email thread
where
> I asked if this could be removed :-)
> 
> My interpretation (but I'm just guessing) is that now that databases and local
> storage are on by default, they'll be on when this code runs. But if I turn
them
> off, then they'll be off for my extensions too (which would be a change in
> behaviour).

I did a quick search and didn't see any place where these are set to anything
different (except via a command line flag, which seems legit).

lgtm