Remove dead code per email with aa about the TODO saying that

chrome/browser/renderer_host/render_view_host.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/render_view_host.h"
 
 #include <string>
 #include <utility>
 #include <vector>
 
@@ skipping 150 matching lines @@
     ChildProcessSecurityPolicy::GetInstance()->GrantExtensionBindings(
         process()->id());
 
     // Extensions may have permission to access chrome:// URLs.
     ChildProcessSecurityPolicy::GetInstance()->GrantScheme(
         process()->id(), chrome::kChromeUIScheme);
   }
 
   renderer_initialized_ = true;
 
-  // Force local storage to be enabled for extensions. This is so that we can
-  // enable extensions by default before databases, if necessary.
-  // TODO(aa): This should be removed when local storage and databases are
-  // enabled by default (bugs 4359 and 4360).
-  WebPreferences webkit_prefs = delegate_->GetWebkitPrefs();
-  if (delegate_->GetURL().SchemeIs(chrome::kExtensionScheme)) {
-    webkit_prefs.local_storage_enabled = true;
-    webkit_prefs.databases_enabled = true;

[Aaron Boodman, 2011/01/18 23:00:53]

Does this mean that these preferences will always be on, or is there some other
thing that can toggle them?

[Alex Nicolaou, 2011/01/19 00:43:37]

I wouldn't know, I was going based on your TODO above and our email thread where
I asked if this could be removed :-)

My interpretation (but I'm just guessing) is that now that databases and local
storage are on by default, they'll be on when this code runs. But if I turn them
off, then they'll be off for my extensions too (which would be a change in
behaviour).

-  }
-
   ViewMsg_New_Params params;
   params.parent_window = GetNativeViewId();
   params.renderer_preferences =
       delegate_->GetRendererPrefs(process()->profile());
-  params.web_preferences = webkit_prefs;
+  params.web_preferences = delegate_->GetWebkitPrefs();
   params.view_id = routing_id();
   params.session_storage_namespace_id = session_storage_namespace_->id();
   params.frame_name = frame_name;
   Send(new ViewMsg_New(params));
 
   // Set the alternate error page, which is profile specific, in the renderer.
   GURL url = delegate_->GetAlternateErrorPageURL();
   SetAlternateErrorPageURL(url);
 
   // If it's enabled, tell the renderer to set up the Javascript bindings for
@@ skipping 1824 matching lines @@
   if (printer_query.get()) {
     BrowserThread::PostTask(
         BrowserThread::IO, FROM_HERE,
         NewRunnableMethod(printer_query.get(),
                           &printing::PrinterQuery::StopWorker));
   }
 
   // Send the printingDone msg for now.
   Send(new ViewMsg_PrintingDone(routing_id(), params.document_cookie, true));
 }