Release all DataSources before the main thread goes away.

Release all DataSources before the main thread goes away.

BUG=70782
TEST=Valgrind no longer needs suppressions for AddDataSource

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72638

[eroman, 2011-01-25 23:47:35]

lgtm

http://codereview.chromium.org/6268014/diff/1/chrome/browser/dom_ui/chrome_ur...
File chrome/browser/dom_ui/chrome_url_data_manager.cc (right):

http://codereview.chromium.org/6268014/diff/1/chrome/browser/dom_ui/chrome_ur...
chrome/browser/dom_ui/chrome_url_data_manager.cc:211: for
(DataSourceMap::iterator i = data_sources_.begin();
why not simply data_sources_.clear() ?

[ahendrickson, 2011-01-26 04:34:38]

http://codereview.chromium.org/6268014/diff/1/chrome/browser/dom_ui/chrome_ur...
File chrome/browser/dom_ui/chrome_url_data_manager.cc (right):

http://codereview.chromium.org/6268014/diff/1/chrome/browser/dom_ui/chrome_ur...
chrome/browser/dom_ui/chrome_url_data_manager.cc:211: for
(DataSourceMap::iterator i = data_sources_.begin();
On 2011/01/25 23:47:35, eroman wrote:
> why not simply data_sources_.clear() ?

I wanted to call Release() rather than destruct the items directly.

[Nico, 2011-01-26 15:20:09]

When you fix a valgrind issue, please remove the corresponding suppressions from
tools/valgrind/memcheck/suppressions.txt in the same CL.

[ahendrickson, 2011-01-26 15:25:50]

On 2011/01/26 15:20:09, Nico wrote:
> When you fix a valgrind issue, please remove the corresponding suppressions
from
> tools/valgrind/memcheck/suppressions.txt in the same CL.

My apologies.  I'll take care of it now.