Release all DataSources before the main thread goes away.

chrome/browser/dom_ui/chrome_url_data_manager.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/dom_ui/chrome_url_data_manager.h"
 
 #include "base/file_util.h"
 #include "base/i18n/rtl.h"
 #include "base/message_loop.h"
 #include "base/path_service.h"
@@ skipping 189 matching lines @@
   // If |AddDataSource| is called more than once, it will destruct the object
   // that it had before, as it is the only thing still holding a reference to
   // that object.  |DataSource| uses the |DeleteOnUIThread| trait to insure
   // that the destructor is called on the UI thread.
   //
   // TODO(jackson): A new data source with same name should not clobber the
   // existing one.
   data_sources_[source->source_name()] = source;
 }
 
+void ChromeURLDataManager::RemoveAllDataSources() {
+  for (DataSourceMap::iterator i = data_sources_.begin();

[eroman, 2011/01/25 23:47:35]

why not simply data_sources_.clear() ?

[ahendrickson, 2011/01/26 04:34:38]

I wanted to call Release() rather than destruct the items directly.

+       i != data_sources_.end();
+       i = data_sources_.begin()) {
+    (*i).second = NULL;  // Calls Release().
+    data_sources_.erase(i);
+  }
+}
+
 void ChromeURLDataManager::AddFileSource(const std::string& source_name,
                                          const FilePath& file_path) {
   DCHECK(file_sources_.count(source_name) == 0);
   file_sources_[source_name] = file_path;
 }
 
 void ChromeURLDataManager::RemoveFileSource(const std::string& source_name) {
   DCHECK(file_sources_.count(source_name) == 1);
   file_sources_.erase(source_name);
 }
@@ skipping 230 matching lines @@
                                            net::ERR_INVALID_URL));
   }
 }
 
 URLRequestChromeFileJob::URLRequestChromeFileJob(net::URLRequest* request,
                                                  const FilePath& path)
     : net::URLRequestFileJob(request, path) {
 }
 
 URLRequestChromeFileJob::~URLRequestChromeFileJob() { }