Issue 6267010: lastchange: handle the git-but-not-git-svn case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6267010: lastchange: handle the git-but-not-git-svn case (Closed)

Created:
9 years, 11 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
tony, battre

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

lastchange: handle the git-but-not-git-svn case When we're using a git checkout of WebKit that hasn't had git-svn set up, ignore the missing versioning information rather than failing. BUG=70606 ,private mails Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72351

Patch Set 1 #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -13 lines)			Patch
	M	build/util/lastchange.py	View		3 chunks	+19 lines, -3 lines	1 comment	Download
	M	webkit/build/webkit_version.py	View		1 chunk	+13 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

This makes webkit show up as "unknown@0" in about:version.

9 years, 11 months ago (2011-01-24 17:49:36 UTC) #2

tony

9 years, 11 months ago (2011-01-24 17:57:44 UTC) #3

LGTM

http://codereview.chromium.org/6267010/diff/1/build/util/lastchange.py
File build/util/lastchange.py (right):

http://codereview.chromium.org/6267010/diff/1/build/util/lastchange.py#newcode90
build/util/lastchange.py:90: if IsGitSVN(directory):
Nit: Maybe merge this condition with the 'not version_info' condition?

Expand Messages | Collapse Messages