Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: webkit/build/webkit_version.py

Issue 6267010: lastchange: handle the git-but-not-git-svn case (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/util/lastchange.py ('K') | « build/util/lastchange.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/build/webkit_version.py
diff --git a/webkit/build/webkit_version.py b/webkit/build/webkit_version.py
index 58110727fee9250058c4318e8f50eb402008f741..f488a2ed8242891542925b6aa21e38748268b253 100755
--- a/webkit/build/webkit_version.py
+++ b/webkit/build/webkit_version.py
@@ -45,21 +45,24 @@ def GetWebKitRevision(webkit_dir, version_file):
# "svn info" tells us what we want, but third_party/WebKit does *not*
# point at the upstream repo. So instead we run svn info on the directory
- # containing the versioning file (which is some subdirectory of WebKit),
- # then strip that path back off of the resulting URL.
+ # containing the versioning file (which is some subdirectory of WebKit).
version_file_dir = os.path.dirname(version_file)
version_info = lastchange.FetchVersionInfo(
default_lastchange=None,
directory=os.path.join(webkit_dir, version_file_dir))
- # Now compute the real WebKit URL by stripping off the version file
- # directory from the URL we get out of version_info.
- # Further, we want to strip off the "http://svn..." from the left.
- # This is the root URL from the repository.
- assert version_info.url.startswith(version_info.root)
- assert version_info.url.endswith(version_file_dir)
- webkit_url = version_info.url[len(version_info.root):-len(version_file_dir)]
- webkit_url = webkit_url.strip('/')
+ if (version_info.url.startswith(version_info.root) and
+ version_info.url.endswith(version_file_dir)):
+ # Now compute the real WebKit URL by stripping off the version file
+ # directory from the URL we get out of version_info.
+ # Further, we want to strip off the "http://svn..." from the left.
+ # This is the root URL from the repository.
+ webkit_url = version_info.url[len(version_info.root):-len(version_file_dir)]
+ webkit_url = webkit_url.strip('/')
+ else:
+ # The data isn't as we expect: perhaps they're using git without svn?
+ # Just dump the output directly.
+ webkit_url = version_info.url
return "%s@%s" % (webkit_url, version_info.revision)
« build/util/lastchange.py ('K') | « build/util/lastchange.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698