Issue 6266023: Revert "Fix crashes in ChromotingHost"

Issue 6266023: Revert "Fix crashes in ChromotingHost" (Closed)

Created:
9 years, 11 months ago by Alpha Left Google

Modified:
9 years, 6 months ago

Reviewers:
Nico

CC:
chromium-reviews, Alpha Left Google, Sergey Ulanov, dmac, awong, garykac, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Revert "Fix crashes in ChromotingHost" Reverting the patch since it exposed several memory leaks and threading problems. TBR=thakis BUG=70935 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72679

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -255 lines)			Patch
M	remoting/host/chromoting_host.h	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	remoting/host/chromoting_host.cc	View	9 chunks	+21 lines, -24 lines	0 comments	Download
D	remoting/host/chromoting_host_unittest.cc	View	1 chunk	+0 lines, -172 lines	0 comments	Download
M	remoting/host/screen_recorder.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	remoting/host/screen_recorder.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	remoting/host/screen_recorder_unittest.cc	View	4 chunks	+9 lines, -8 lines	0 comments	Download
M	remoting/host/simple_host_process.cc	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	remoting/protocol/connection_to_client.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	remoting/protocol/mock_objects.h	View	3 chunks	+1 line, -30 lines	0 comments	Download
M	remoting/remoting.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

LG On Wed, Jan 26, 2011 at 12:18 PM, <hclam@chromium.org> wrote: > Reviewers: Nico, > ...

9 years, 11 months ago (2011-01-26 20:18:47 UTC) #2

Nico

9 years, 11 months ago (2011-01-26 20:20:16 UTC) #3

Timur: fyi

On Wed, Jan 26, 2011 at 12:18 PM, Nico Weber <thakis@chromium.org> wrote:
> LG
>
> On Wed, Jan 26, 2011 at 12:18 PM,  <hclam@chromium.org> wrote:
>> Reviewers: Nico,
>>
>> Description:
>> Revert "Fix crashes in ChromotingHost"
>>
>> Reverting the patch since it exposed several memory leaks and threading
>> problems.
>>
>> BUG=70935
>> TEST=None
>>
>> Please review this at http://codereview.chromium.org/6266023/
>>
>> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>>
>> Affected files:
>>  M remoting/host/chromoting_host.h
>>  M remoting/host/chromoting_host.cc
>>  D remoting/host/chromoting_host_unittest.cc
>>  M remoting/host/screen_recorder.h
>>  M remoting/host/screen_recorder.cc
>>  M remoting/host/screen_recorder_unittest.cc
>>  M remoting/host/simple_host_process.cc
>>  M remoting/protocol/connection_to_client.h
>>  M remoting/protocol/mock_objects.h
>>  M remoting/remoting.gyp
>>
>>
>>
>

Expand Messages | Collapse Messages