Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 6266015: Fix range comparison. Get space to accept keyword work. (Closed)

Created:
9 years, 11 months ago by oshima
Modified:
9 years, 6 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix range comparison. Get space to accept keyword work. I overlooked this placeholder code to fix. BUG=none TEST=enabled AcceptKeywordBySpaceTest for views-implementation Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72185

Patch Set 1 #

Patch Set 2 : " #

Total comments: 2

Patch Set 3 : " #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_views.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M views/controls/textfield/textfield.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
oshima
red trybots are update failures. I kicked off new jobs with newer revistion.
9 years, 11 months ago (2011-01-21 19:08:20 UTC) #1
Peter Kasting
http://codereview.chromium.org/6266015/diff/2001/views/controls/textfield/textfield.h File views/controls/textfield/textfield.h (right): http://codereview.chromium.org/6266015/diff/2001/views/controls/textfield/textfield.h#newcode72 views/controls/textfield/textfield.h:72: // Returns true if the selected text will be ...
9 years, 11 months ago (2011-01-21 19:10:10 UTC) #2
oshima
http://codereview.chromium.org/6266015/diff/2001/views/controls/textfield/textfield.h File views/controls/textfield/textfield.h (right): http://codereview.chromium.org/6266015/diff/2001/views/controls/textfield/textfield.h#newcode72 views/controls/textfield/textfield.h:72: // Returns true if the selected text will be ...
9 years, 11 months ago (2011-01-21 20:05:01 UTC) #3
Peter Kasting
9 years, 11 months ago (2011-01-21 20:08:49 UTC) #4
OK

Powered by Google App Engine
This is Rietveld 408576698