Fix range comparison. Get space to accept keyword work.

views/controls/textfield/textfield.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_
 #define VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_
 #pragma once
 
 #include "build/build_config.h"
 
@@ skipping 51 matching lines @@
 
   // Returns true if the selection is made in reverse order.
   bool is_reverse() const { return start_ > end_; }
 
   // Returns the min of selected range.
   size_t GetMin() const;
 
   // Returns the max of selected range.
   size_t GetMax() const;
 
-  // Returns true if |range| has same start, end position.
-  bool Equals(const TextRange& range) const {
-    return start_ == range.start_ && end_ == range.end_;
+  // Returns true if the selected text will be the same.

[Peter Kasting, 2011/01/21 19:10:10]

I think the functionality here is confusing.  I'd prefer to leave Equals() and
add the empty range checks to the caller.

[oshima, 2011/01/21 20:05:01]

moved empty check to caller, but i prefer to keep the
non directional euqal check here.

+  // That is, if both range are empty, or both have same min and max;
+  bool HasSameSelectionWith(const TextRange& range) const {
+    return (is_empty() && range.is_empty()) ||
+        (GetMin() == range.GetMin() && GetMax() == range.GetMax());
   }
 
   // Set the range with |start| and |end|.
   void SetRange(size_t start, size_t end);
 
  private:
   size_t start_;
   size_t end_;
 
   // No assign.
@@ skipping 255 matching lines @@
 
   // Text to display when empty.
   string16 text_to_display_when_empty_;
 
   DISALLOW_COPY_AND_ASSIGN(Textfield);
 };
 
 }  // namespace views
 
 #endif  // VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_