Issue 6265008: Ensure that renderer crashes in pdf runner results in test failure...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6265008: Ensure that renderer crashes in pdf runner results in test failure... (Closed)

Created:
9 years, 11 months ago by Nirnimesh

Modified:
9 years, 7 months ago

Reviewers:
sunandt

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/test/

Visibility:
Public.

Description

Ensure that renderer crashes in pdf runner results in test failure Check for crash dump files Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71711

Patch Set 1 #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	functional/pdf.py	View		2 chunks	+6 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sunandt

http://codereview.chromium.org/6265008/diff/1/functional/pdf.py File functional/pdf.py (right): http://codereview.chromium.org/6265008/diff/1/functional/pdf.py#newcode60 functional/pdf.py:60: msg='Crash dump %s found' % dmp_file) What if there ...

9 years, 11 months ago (2011-01-18 20:04:25 UTC) #2

Nirnimesh

9 years, 11 months ago (2011-01-18 20:11:48 UTC) #3

sunandt

9 years, 11 months ago (2011-01-18 22:51:50 UTC) #4

LGTM

On 2011/01/18 20:11:48, Nirnimesh wrote:
> http://codereview.chromium.org/6265008/diff/1/functional/pdf.py
> File functional/pdf.py (right):
> 
> http://codereview.chromium.org/6265008/diff/1/functional/pdf.py#newcode60
> functional/pdf.py:60: msg='Crash dump %s found' % dmp_file)
> On 2011/01/18 20:04:26, sunandt wrote:
> > What if there are dump files from old runs or previous tests?
> 
> Which is why I make a copy of old dmp files in line 41 and verify that no new
> dump file was created.

Expand Messages | Collapse Messages