Ensure that renderer crashes in pdf runner results in test failure...

functional/pdf.py

 #!/usr/bin/python
 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 import glob
 
 import pyauto_functional  # Must be imported before pyauto
 import pyauto
@@ skipping 19 matching lines @@
     # (or else it hangs)
     return self.GetDOMValue('%s + ""' % js, 0, tab_index)
 
 
   def testPDFRunner(self):
     """Navigate to pdf files and verify that browser doesn't crash"""
     # bail out if not a branded build
     properties = self.GetBrowserInfo()['properties']
     if properties['branding'] != 'Google Chrome':
       return
+    breakpad_folder = properties['DIR_CRASH_DUMPS']
+    old_dmp_files = glob.glob(os.path.join(breakpad_folder, '*.dmp'))
     pdf_files_path = os.path.join(self.DataDir(), 'pyauto_private', 'pdf')
     pdf_files = glob.glob(os.path.join(pdf_files_path, '*.pdf'))
     for pdf_file in pdf_files:
       # Some pdfs cause known crashes. Exclude them. crbug.com/63549
       if os.path.basename(pdf_file) in ('nullip.pdf', 'sample.pdf'):
         continue
       url = self.GetFileURLForPath(pdf_file)
       self.AppendTab(pyauto.GURL(url))
     for tab_index in range(1, len(pdf_files) + 1):
       self.ActivateTab(tab_index)
       self._PerformPDFAction('fitToHeight', tab_index=tab_index)
       self._PerformPDFAction('fitToWidth', tab_index=tab_index)
     # Assert that there is at least 1 browser window.
     self.assertTrue(self.GetBrowserWindowCount(),
                     'Browser crashed, no window is open')
+    # Verify there're no crash dump files
+    for dmp_file in glob.glob(os.path.join(breakpad_folder, '*.dmp')):
+      self.assertTrue(dmp_file in old_dmp_files,
+          msg='Crash dump %s found' % dmp_file)

[sunandt, 2011/01/18 20:04:26]

What if there are dump files from old runs or previous tests?

[Nirnimesh, 2011/01/18 20:11:48]

Which is why I make a copy of old dmp files in line 41 and verify that no new
dump file was created.

 
 
 if __name__ == '__main__':
   pyauto_functional.Main()