Clean up net unit testing code.

Clean up net unit testing code.

- Move code included from blah_unittest.h (where blah_unittest.cc has actual
  unittests) into their own files, often completely out-of-lining the
  definitions.
- Remove anonymous namespaces from headers.
- Reorder method declarations.
- Make other unit test link against net_test_support instead of reaching in and
  including .h files in their targets directly.

BUG=68682
TEST=compiles

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72562

[Elliot Glaysher, 2011-01-25 20:33:07]

More cleanup. This time not directly related to my reordering cleanups.

[Randy Smith (Not in Mondays), 2011-01-25 23:29:02]

LGTM (though I just skimmed the url_request_unittest.h ->
url_request_test_util.* split.)

http://codereview.chromium.org/6264013/diff/5001/net/base/cookie_monster_stor...
File net/base/cookie_monster_store_test.h (right):

http://codereview.chromium.org/6264013/diff/5001/net/base/cookie_monster_stor...
net/base/cookie_monster_store_test.h:133: virtual void
SetClearLocalStateOnExit(bool clear_local_state) {}
nit: This is inconsistent; either both SetClearLocalStateOnExit methods should
be defined in the .cc files, or neither should be.

[willchan no longer on Chromium, 2011-01-25 23:47:39]

LGTM

http://codereview.chromium.org/6264013/diff/5001/chrome/common/net/url_fetche...
File chrome/common/net/url_fetcher_unittest.cc (right):

http://codereview.chromium.org/6264013/diff/5001/chrome/common/net/url_fetche...
chrome/common/net/url_fetcher_unittest.cc:15: #include
"net/url_request/url_request_test_util.h"
sort alphabetically

http://codereview.chromium.org/6264013/diff/5001/chrome/service/cloud_print/c...
File chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc (right):

http://codereview.chromium.org/6264013/diff/5001/chrome/service/cloud_print/c...
chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc:17: #include
"net/url_request/url_request_test_util.h"
sort alphabetically

http://codereview.chromium.org/6264013/diff/5001/net/base/mock_filter_context.cc
File net/base/mock_filter_context.cc (right):

http://codereview.chromium.org/6264013/diff/5001/net/base/mock_filter_context...
net/base/mock_filter_context.cc:27: *gurl = gurl_;
I think you need to #include "googleurl/src/gurl.h" in order to get the
definition for GURL::operator=

http://codereview.chromium.org/6264013/diff/5001/net/base/mock_filter_context.h
File net/base/mock_filter_context.h (right):

http://codereview.chromium.org/6264013/diff/5001/net/base/mock_filter_context...
net/base/mock_filter_context.h:1: // Copyright (c) 2010 The Chromium Authors.
All rights reserved.
2011

http://codereview.chromium.org/6264013/diff/5001/net/url_request/url_request_...
File net/url_request/url_request_test_util.h (right):

http://codereview.chromium.org/6264013/diff/5001/net/url_request/url_request_...
net/url_request/url_request_test_util.h:5: #ifndef
NET_URL_REQUEST_URL_REQUEST_UNITTEST_H_
Fix the include guards

http://codereview.chromium.org/6264013/diff/5001/net/url_request/url_request_...
File net/url_request/url_request_unittest.cc (right):

http://codereview.chromium.org/6264013/diff/5001/net/url_request/url_request_...
net/url_request/url_request_unittest.cc:45: #include
"net/url_request/url_request.h"
This header should go first.