net/http/http_auth_handler_factory_unittest.cc - Issue 6264013: Clean up net unit testing code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_auth_handler_factory_unittest.cc

Issue 6264013: Clean up net unit testing code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-virtualize TestDelegate::OnResponseCompleted Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_auth_handler_factory_unittest.cc

diff --git a/net/http/http_auth_handler_factory_unittest.cc b/net/http/http_auth_handler_factory_unittest.cc

index fb6e370829aede705d651187e0057c682e626da2..3145c4bcee4e876ca5fd7386fa5917f714630619 100644

--- a/net/http/http_auth_handler_factory_unittest.cc

+++ b/net/http/http_auth_handler_factory_unittest.cc

@@ -7,6 +7,7 @@

#include "net/base/net_errors.h"

#include "net/http/http_auth_handler.h"

#include "net/http/http_auth_handler_factory.h"

+#include "net/http/mock_allow_url_security_manager.h"

#include "net/http/url_security_manager.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -97,7 +98,7 @@ TEST(HttpAuthHandlerFactoryTest, RegistryFactory) {

TEST(HttpAuthHandlerFactoryTest, DefaultFactory) {

scoped_ptr<HostResolver> host_resolver(new MockHostResolver());

- URLSecurityManagerAllow url_security_manager;

+ MockAllowURLSecurityManager url_security_manager;

scoped_ptr<HttpAuthHandlerRegistryFactory> http_auth_handler_factory(

HttpAuthHandlerFactory::CreateDefault(host_resolver.get()));

http_auth_handler_factory->SetURLSecurityManager(