Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 6262002: Chromium build failed with heap leak checker, or configured with (Closed)

Created:
9 years, 11 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews, vrk (LEFT CHROMIUM), ncarter (slow), sjl, Alpha Left Google, idana, Raghu Simha, ddorwin+watch_chromium.org, cbentzel+watch_chromium.org, acolwell GONE FROM CHROMIUM, annacc, darin-cc_chromium.org, awong, pam+watch_chromium.org, tim (not reviewing), scherkus (not reviewing)
Visibility:
Public.

Description

Chromium build failed with heap leak checker, or configured with 'gyp_chromium -Dlinux_use_heapchecker=1 -Dlinux_keep_shadow_stacks=1' parameters. This configuration set gcc option '-finstrument-functions' and cause 'control reaches end of non-void function' error in some sources. Some errors occur in WebKit, and this changelist doesn't include patches for WebKit sources. TEST=pass sync_unit_tests, browser_tests, net_unittests Original patch by Takashi Toyoshima <toyoshim@google.com>; at http://codereview.chromium.org/5991005/ Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71274

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -17 lines) Patch
M chrome/browser/cookies_tree_model.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/syncable/model_type.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/net/gaia/gaia_auth_fetcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/video/ffmpeg_video_decode_engine.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698