Chromium build failed with heap leak checker, or configured with 'gyp_chromiu...

Chromium build failed with heap leak checker, or configured with 'gyp_chromium -Dlinux_use_heapchecker=1 -Dlinux_keep_shadow_stacks=1' parameters. This configuration set gcc option '-finstrument-functions' and cause 'control reaches end of non-void function' error in some sources. Some errors occur in WebKit, and this changelist doesn't include patches for WebKit sources.

TEST=pass sync_unit_tests, browser_tests, net_unittests

[Takashi Toyoshima (Google), 2010-12-27 12:04:14]

I explored svn history and chose you as reviewers.
This patches are spread over some directories, but each fix is very simple and
small one.
Would you guys mind reviewing each patch of my changelist?

Thanks

[Takashi Toyoshima (Google), 2010-12-28 07:48:11]

following issues are those of WebKit
https://bugs.webkit.org/show_bug.cgi?id=51668
https://bugs.webkit.org/show_bug.cgi?id=51669

[tony, 2011-01-03 17:13:42]

LGTM

[scherkus (not reviewing), 2011-01-05 01:50:48]

LGTM on media stuff

[Takashi Toyoshima (Google), 2011-01-12 04:53:35]

Tony and Scherkus,
thank you for reviewing.

If all patches are OK and it is convenient for you,
I would like you to commit this changelist because I am not a committer yet.

Thanks

[akalin, 2011-01-12 09:23:29]

LGTM

Although it's strange that the data flow analysis can't deduce that all paths
lead to a value being returned.

On 2011/01/12 04:53:35, Takashi Toyoshima wrote:
> Tony and Scherkus,
> thank you for reviewing.
> 
> If all patches are OK and it is convenient for you,
> I would like you to commit this changelist because I am not a committer yet.
> 
> Thanks

[tony, 2011-01-13 00:42:06]

Committed:
http://src.chromium.org/viewvc/chrome?view=rev&revision=71274