Once we initiate shutdown sequence, don't show crash bar on subsequent startu...

Once we initiate shutdown sequence, don't show crash bar on subsequent startup.
BUG=chromium-os:10923
TEST=Open 20 gmail windows in Chrome on ChromeOS, hit the power button twice to shutdown, then restart and login. With this chagne, you should see the 20 gmail windows instead of a crash bar.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72697

[achuithb, 2011-01-25 02:13:55]

bug is chromium-os:10923

[achuithb, 2011-01-25 02:14:28]

http://code.google.com/p/chromium-os/issues/detail?id=10923

[Daniel Erat, 2011-01-25 02:29:42]

http://codereview.chromium.org/6257014/diff/1/chrome/browser/ui/browser_list.cc
File chrome/browser/ui/browser_list.cc (right):

http://codereview.chromium.org/6257014/diff/1/chrome/browser/ui/browser_list....
chrome/browser/ui/browser_list.cc:361: MarkAsCleanShutdown(); // Don't notify
users of crashes beyond this point.
I think you might be missing the fast-shutdown path by putting this here; see
BrowserList::Exit().  NotifyAndTerminate() seemed to be a better choice for the
notifying-wm-about-signout stuff that I was working on (it also gets called by
CloseAllBrowsers(), as far as I can see).

[achuithb, 2011-01-25 08:39:56]

So the fast shutdown path goes like this - user pressed ctrl-shift-q or
wrench-menu signout, which ends with NotifyAndTerminate assuming no
downloads/unload handlers. LoginLibrary::StopSession calls into ChromeOS, which
then sends an abort signal, which is picked up in Chrome again at
BrowserList::CloseAllBrowsersAndExit (called from browser_main_posix.cc:116). So
MarkAsCleanShutdown gets called, albeit in a round-about way.

In the hardware shutdown path, aka hitting the power button, ChromeOS simply
sends the abort signal to Chrome, and the shutdown sequence *begins* at
BrowserList::CloseAllBrowsersAndExit. NotifyAndTerminate is never called in this
case, and we would see the crash bar on startup if we were to only insert
MarkAsCleanShutdown in NotifyAndTerminate.

Hope this is clear; if not, we can discuss it in person tomorrow!

[Daniel Erat, 2011-01-25 16:20:13]

Got it; thanks!  LGTM.