Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2983)

Unified Diff: chrome/browser/ui/browser_list.cc

Issue 6257014: Once we initiate shutdown sequence, don't show crash bar on subsequent startu... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_list.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_list.cc
===================================================================
--- chrome/browser/ui/browser_list.cc (revision 71980)
+++ chrome/browser/ui/browser_list.cc (working copy)
@@ -183,6 +183,12 @@
<< "observer list modified during notification";
}
+// static
+void BrowserList::MarkAsCleanShutdown() {
+ for (const_iterator i = begin(); i != end(); ++i) {
+ (*i)->profile()->MarkAsCleanShutdown();
+ }
+}
// static
void BrowserList::NotifyAndTerminate() {
@@ -262,8 +268,7 @@
// static
bool BrowserList::NeedBeforeUnloadFired() {
bool need_before_unload_fired = false;
- for (BrowserList::const_iterator i = BrowserList::begin();
- i != BrowserList::end(); ++i) {
+ for (const_iterator i = begin(); i != end(); ++i) {
need_before_unload_fired = need_before_unload_fired ||
(*i)->TabsNeedBeforeUnloadFired();
}
@@ -272,8 +277,7 @@
// static
bool BrowserList::PendingDownloads() {
- for (BrowserList::const_iterator i = BrowserList::begin();
- i != BrowserList::end(); ++i) {
+ for (const_iterator i = begin(); i != end(); ++i) {
bool normal_downloads_are_present = false;
bool incognito_downloads_are_present = false;
(*i)->CheckDownloadsInProgress(&normal_downloads_are_present,
@@ -354,6 +358,7 @@
// static
void BrowserList::CloseAllBrowsersAndExit() {
+ MarkAsCleanShutdown(); // Don't notify users of crashes beyond this point.
Daniel Erat 2011/01/25 02:29:42 I think you might be missing the fast-shutdown pat
NotificationService::current()->Notify(
NotificationType::APP_EXITING,
NotificationService::AllSources(),
« no previous file with comments | « chrome/browser/ui/browser_list.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698