Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6256010: Revert 72380 - Remove wstring from autocomplete.... (Closed)

Created:
9 years, 11 months ago by Avi (use Gerrit)
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, cbentzel+watch_chromium.org, Erik does not do reviews, Paweł Hajdan Jr., Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Revert 72380 - Remove wstring from autocomplete. BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6258015 TBR=avi@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1211 lines, -1311 lines) Patch
M chrome/browser/autocomplete/autocomplete.h View 12 chunks +25 lines, -26 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete.cc View 18 chunks +48 lines, -55 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_accessibility.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_browsertest.cc View 11 chunks +34 lines, -36 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_classifier.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_classifier.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit.h View 20 chunks +30 lines, -30 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit.cc View 28 chunks +44 lines, -44 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_unittest.cc View 7 chunks +29 lines, -30 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view.h View 6 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc View 24 chunks +45 lines, -48 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.h View 6 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc View 21 chunks +34 lines, -33 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_mac.h View 5 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_mac.mm View 20 chunks +33 lines, -33 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_mac_unittest.mm View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_views.h View 4 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_views.cc View 11 chunks +21 lines, -21 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_win.h View 9 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_win.cc View 24 chunks +36 lines, -36 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_match.h View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_match.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_model.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_model.cc View 5 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_view_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_view_gtk_unittest.cc View 7 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_view_mac.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_view_mac.mm View 5 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_view_mac_unittest.mm View 12 chunks +25 lines, -23 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_unittest.cc View 11 chunks +113 lines, -118 lines 0 comments Download
M chrome/browser/autocomplete/history_contents_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_contents_provider.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/history_contents_provider_unittest.cc View 5 chunks +19 lines, -23 lines 0 comments Download
M chrome/browser/autocomplete/history_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/history_provider.cc View 5 chunks +15 lines, -18 lines 0 comments Download
M chrome/browser/autocomplete/history_provider_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/history_provider_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.cc View 3 chunks +15 lines, -14 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 14 chunks +35 lines, -36 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider_unittest.cc View 14 chunks +52 lines, -59 lines 0 comments Download
M chrome/browser/autocomplete/keyword_provider.h View 4 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/autocomplete/keyword_provider.cc View 19 chunks +50 lines, -46 lines 0 comments Download
M chrome/browser/autocomplete/keyword_provider_unittest.cc View 4 chunks +56 lines, -71 lines 0 comments Download
M chrome/browser/autocomplete/search_provider.h View 7 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 21 chunks +42 lines, -41 lines 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 15 chunks +46 lines, -46 lines 0 comments Download
MM chrome/browser/extensions/extension_omnibox_api.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/extensions/extension_omnibox_apitest.cc View 5 chunks +17 lines, -21 lines 0 comments Download
MM chrome/browser/instant/instant_browsertest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
MM chrome/browser/net/url_fixer_upper.h View 2 chunks +1 line, -5 lines 0 comments Download
MM chrome/browser/net/url_fixer_upper.cc View 2 chunks +0 lines, -54 lines 0 comments Download
MM chrome/browser/omnibox_search_hint.cc View 1 chunk +2 lines, -2 lines 0 comments Download
MM chrome/browser/tab_contents/render_view_context_menu.cc View 1 chunk +2 lines, -1 line 0 comments Download
MM chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
MM chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 6 chunks +15 lines, -13 lines 0 comments Download
MM chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.h View 2 chunks +1 line, -2 lines 0 comments Download
MM chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.mm View 1 chunk +5 lines, -5 lines 0 comments Download
MM chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm View 2 chunks +1 line, -2 lines 0 comments Download
MM chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 chunk +2 lines, -1 line 0 comments Download
MM chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 1 chunk +2 lines, -1 line 0 comments Download
MM chrome/browser/ui/gtk/gtk_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
MM chrome/browser/ui/gtk/location_bar_view_gtk.h View 4 chunks +5 lines, -5 lines 0 comments Download
MM chrome/browser/ui/gtk/location_bar_view_gtk.cc View 11 chunks +18 lines, -16 lines 0 comments Download
MM chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/ui/toolbar/toolbar_model.cc View 1 chunk +3 lines, -5 lines 0 comments Download
MM chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc View 12 chunks +17 lines, -15 lines 0 comments Download
MM chrome/browser/ui/views/frame/browser_root_view.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/ui/views/location_bar/keyword_hint_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
MM chrome/browser/ui/views/location_bar/keyword_hint_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM chrome/browser/ui/views/location_bar/location_bar_view.h View 2 chunks +2 lines, -2 lines 0 comments Download
MM chrome/browser/ui/views/location_bar/location_bar_view.cc View 6 chunks +13 lines, -12 lines 0 comments Download
MM chrome/browser/ui/views/location_bar/selected_keyword_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
MM chrome/browser/ui/views/location_bar/selected_keyword_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM chrome/common/automation_messages_internal.h View 2 chunks +2 lines, -2 lines 0 comments Download
MM chrome/test/automation/autocomplete_edit_proxy.h View 4 chunks +11 lines, -11 lines 0 comments Download
MM chrome/test/automation/autocomplete_edit_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM chrome/test/automation/automation_proxy_uitest.cc View 5 chunks +8 lines, -10 lines 0 comments Download
MM chrome/test/ui/omnibox_uitest.cc View 3 chunks +10 lines, -12 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Avi (use Gerrit)
9 years, 11 months ago (2011-01-24 20:58:59 UTC) #1 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698