Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

Issue 6256010: Revert 72380 - Remove wstring from autocomplete.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
Property Changes:
Added: svn:mergeinfo
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/tabs/tab_strip_controller.h" 5 #import "chrome/browser/ui/cocoa/tabs/tab_strip_controller.h"
6 6
7 #import <QuartzCore/QuartzCore.h> 7 #import <QuartzCore/QuartzCore.h>
8 8
9 #include <limits> 9 #include <limits>
10 #include <string> 10 #include <string>
(...skipping 1735 matching lines...) Expand 10 before | Expand all | Expand 10 after
1746 [self openURL:&url inView:view at:point]; 1746 [self openURL:&url inView:view at:point];
1747 } 1747 }
1748 1748
1749 // (URLDropTargetController protocol) 1749 // (URLDropTargetController protocol)
1750 - (void)dropText:(NSString*)text inView:(NSView*)view at:(NSPoint)point { 1750 - (void)dropText:(NSString*)text inView:(NSView*)view at:(NSPoint)point {
1751 DCHECK_EQ(view, tabStripView_.get()); 1751 DCHECK_EQ(view, tabStripView_.get());
1752 1752
1753 // If the input is plain text, classify the input and make the URL. 1753 // If the input is plain text, classify the input and make the URL.
1754 AutocompleteMatch match; 1754 AutocompleteMatch match;
1755 browser_->profile()->GetAutocompleteClassifier()->Classify( 1755 browser_->profile()->GetAutocompleteClassifier()->Classify(
1756 base::SysNSStringToUTF16(text), string16(), false, &match, NULL); 1756 base::SysNSStringToWide(text),
1757 std::wstring(), false, &match, NULL);
1757 GURL url(match.destination_url); 1758 GURL url(match.destination_url);
1758 1759
1759 [self openURL:&url inView:view at:point]; 1760 [self openURL:&url inView:view at:point];
1760 } 1761 }
1761 1762
1762 // (URLDropTargetController protocol) 1763 // (URLDropTargetController protocol)
1763 - (void)indicateDropURLsInView:(NSView*)view at:(NSPoint)point { 1764 - (void)indicateDropURLsInView:(NSView*)view at:(NSPoint)point {
1764 DCHECK_EQ(view, tabStripView_.get()); 1765 DCHECK_EQ(view, tabStripView_.get());
1765 1766
1766 // The minimum y-coordinate at which one should consider place the arrow. 1767 // The minimum y-coordinate at which one should consider place the arrow.
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
1893 NSInteger index = [self indexFromModelIndex:modelIndex]; 1894 NSInteger index = [self indexFromModelIndex:modelIndex];
1894 BrowserWindowController* controller = 1895 BrowserWindowController* controller =
1895 (BrowserWindowController*)[[switchView_ window] windowController]; 1896 (BrowserWindowController*)[[switchView_ window] windowController];
1896 DCHECK(index >= 0); 1897 DCHECK(index >= 0);
1897 if (index >= 0) { 1898 if (index >= 0) {
1898 [controller setTab:[self viewAtIndex:index] isDraggable:YES]; 1899 [controller setTab:[self viewAtIndex:index] isDraggable:YES];
1899 } 1900 }
1900 } 1901 }
1901 1902
1902 @end 1903 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698