Adding ChromeVox as a component extensions (enabled only for ChromeOS, for no...

chrome/browser/profiles/profile_impl.cc

Index: chrome/browser/profiles/profile_impl.cc
===================================================================
--- chrome/browser/profiles/profile_impl.cc	(revision 71755)
+++ chrome/browser/profiles/profile_impl.cc	(working copy)
@@ -406,6 +406,21 @@
     extensions_service_->register_component_extension(
         ExtensionService::ComponentExtensionInfo(manifest, path));
   }
+
+#if defined(OS_CHROMEOS)
+  // Register access extensions only if accessibility is enabled.
+  if (g_browser_process->local_state()->
+      GetBoolean(prefs::kAccessibilityEnabled)) {
+    FilePath path = FilePath().AppendASCII(extension_misc::kAccessExtensionPath)

[asargent_no_longer_on_chrome, 2011/01/21 21:18:40]

nit: this should be:

FilePath path = FilePath(extension_misc::kAccessExtensionPath)
    .AppendASCII("access_chromevox");

eg you can use the FilePath constructor that takes a string argument, and the
overflow on the next line should be 4-spaced indented

[Chaitanya, 2011/01/21 21:38:49]

Done.

+                              .AppendASCII("access_chromevox");
+    std::string manifest =
+        ResourceBundle::GetSharedInstance().GetRawDataResource(
+            IDR_CHROMEVOX_MANIFEST).as_string();
+    extensions_service_->register_component_extension(
+        ExtensionService::ComponentExtensionInfo(manifest, path));
+  }
+#endif
+
 }
 
 void ProfileImpl::InstallDefaultApps() {