Adding ChromeVox as a component extensions (enabled only for ChromeOS, for no...

chrome/browser/profiles/profile_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_impl.h"
 
 #include "app/resource_bundle.h"
 #include "base/command_line.h"
 #include "base/environment.h"
 #include "base/file_path.h"
@@ skipping 388 matching lines @@
     } else {
       NOTREACHED();
     }
 
     std::string manifest =
         ResourceBundle::GetSharedInstance().GetRawDataResource(
             iter->second).as_string();
     extensions_service_->register_component_extension(
         ExtensionService::ComponentExtensionInfo(manifest, path));
   }
+
+#if defined(OS_CHROMEOS)
+  // Register access extensions only if accessibility is enabled.
+  if (g_browser_process->local_state()->
+      GetBoolean(prefs::kAccessibilityEnabled)) {
+    FilePath path = FilePath().AppendASCII(extension_misc::kAccessExtensionPath)

[asargent_no_longer_on_chrome, 2011/01/21 21:18:40]

nit: this should be:

FilePath path = FilePath(extension_misc::kAccessExtensionPath)
    .AppendASCII("access_chromevox");

eg you can use the FilePath constructor that takes a string argument, and the
overflow on the next line should be 4-spaced indented

[Chaitanya, 2011/01/21 21:38:49]

Done.

+                              .AppendASCII("access_chromevox");
+    std::string manifest =
+        ResourceBundle::GetSharedInstance().GetRawDataResource(
+            IDR_CHROMEVOX_MANIFEST).as_string();
+    extensions_service_->register_component_extension(
+        ExtensionService::ComponentExtensionInfo(manifest, path));
+  }
+#endif
+
 }
 
 void ProfileImpl::InstallDefaultApps() {
   ExtensionService* extension_service = GetExtensionService();
   DefaultApps* default_apps = extension_service->default_apps();
 
   if (!default_apps->ShouldInstallDefaultApps(extension_service->GetAppIds()))
     return;
 
   const ExtensionIdSet& app_ids = default_apps->default_apps();
@@ skipping 970 matching lines @@
 }
 
 PrerenderManager* ProfileImpl::GetPrerenderManager() {
   CommandLine* cl = CommandLine::ForCurrentProcess();
   if (!cl->HasSwitch(switches::kEnablePagePrerender))
     return NULL;
   if (!prerender_manager_)
     prerender_manager_ = new PrerenderManager(this);
   return prerender_manager_;
 }