Adding ChromeVox as a component extensions (enabled only for ChromeOS, for no...

chrome/browser/profiles/profile_impl.cc

Index: chrome/browser/profiles/profile_impl.cc
===================================================================
--- chrome/browser/profiles/profile_impl.cc	(revision 71755)
+++ chrome/browser/profiles/profile_impl.cc	(working copy)
@@ -381,6 +381,14 @@
   // Bookmark manager.
   component_extensions.push_back(
       std::make_pair("bookmark_manager", IDR_BOOKMARKS_MANIFEST));
+#if defined(OS_CHROMEOS)
+  // Register access extensions only if accessibility is enabled.
+  if (g_browser_process->local_state()->

[asargent_no_longer_on_chrome, 2011/01/21 05:53:44]

nit: I think you can just call GetPrefs() instead of
g_browser_process->local_state()

+      GetBoolean(prefs::kAccessibilityEnabled)) {

[asargent_no_longer_on_chrome, 2011/01/21 05:53:44]

Looks like this current patch set is missing the change to define and register
the kAccessibilityEnabled pref (I think you had this in one of the earlier patch
sets - did you accidentally remove it?).

+    component_extensions.push_back(
+        std::make_pair("access_chromevox", IDR_CHROMEVOX_MANIFEST));
+  }
+#endif
 
 #if defined(TOUCH_UI)
   component_extensions.push_back(
@@ -400,6 +408,13 @@
       NOTREACHED();
     }
 
+#if defined(OS_CHROMEOS)
+    if (StartsWithASCII(iter->first, "access_", true)) {

[asargent_no_longer_on_chrome, 2011/01/21 05:53:44]

Here's an idea - instead of pushing the ("access_chromevox",
IDR_CHROMEVOX_MANIFEST) pair into component_extensions and having to do this
special case inside the body of the for loop, instead move the test for whether
accessibility is enabled to be just after this for loop. Then, if it is enabled,
you construct the proper path and then call 

extensions_service_->register_component_extension(...)

[Chaitanya, 2011/01/21 20:09:32]

Done.

+      path = FilePath().AppendASCII(extension_misc::kAccessExtensionPath)
+          .AppendASCII(iter->first);
+    }
+#endif
+
     std::string manifest =
         ResourceBundle::GetSharedInstance().GetRawDataResource(
             iter->second).as_string();