Adding ChromeVox as a component extensions (enabled only for ChromeOS, for no...

chrome/browser/profiles/profile_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_impl.h"
 
 #include "app/resource_bundle.h"
 #include "base/command_line.h"
 #include "base/environment.h"
 #include "base/file_path.h"
@@ skipping 363 matching lines @@
 }
 
 void ProfileImpl::RegisterComponentExtensions() {
   // Register the component extensions.
   typedef std::list<std::pair<std::string, int> > ComponentExtensionList;
   ComponentExtensionList component_extensions;
 
   // Bookmark manager.
   component_extensions.push_back(
       std::make_pair("bookmark_manager", IDR_BOOKMARKS_MANIFEST));
+#if defined(OS_CHROMEOS)
+  // Register access extensions only if accessibility is enabled.
+  if (g_browser_process->local_state()->

[asargent_no_longer_on_chrome, 2011/01/21 05:53:44]

nit: I think you can just call GetPrefs() instead of
g_browser_process->local_state()

+      GetBoolean(prefs::kAccessibilityEnabled)) {

[asargent_no_longer_on_chrome, 2011/01/21 05:53:44]

Looks like this current patch set is missing the change to define and register
the kAccessibilityEnabled pref (I think you had this in one of the earlier patch
sets - did you accidentally remove it?).

+    component_extensions.push_back(
+        std::make_pair("access_chromevox", IDR_CHROMEVOX_MANIFEST));
+  }
+#endif
 
 #if defined(TOUCH_UI)
   component_extensions.push_back(
       std::make_pair("keyboard", IDR_KEYBOARD_MANIFEST));
 #endif
 
   // Web Store.
   component_extensions.push_back(
       std::make_pair("web_store", IDR_WEBSTORE_MANIFEST));
 
   for (ComponentExtensionList::iterator iter = component_extensions.begin();
     iter != component_extensions.end(); ++iter) {
     FilePath path;
     if (PathService::Get(chrome::DIR_RESOURCES, &path)) {
       path = path.AppendASCII(iter->first);
     } else {
       NOTREACHED();
     }
 
+#if defined(OS_CHROMEOS)
+    if (StartsWithASCII(iter->first, "access_", true)) {

[asargent_no_longer_on_chrome, 2011/01/21 05:53:44]

Here's an idea - instead of pushing the ("access_chromevox",
IDR_CHROMEVOX_MANIFEST) pair into component_extensions and having to do this
special case inside the body of the for loop, instead move the test for whether
accessibility is enabled to be just after this for loop. Then, if it is enabled,
you construct the proper path and then call 

extensions_service_->register_component_extension(...)

[Chaitanya, 2011/01/21 20:09:32]

Done.

+      path = FilePath().AppendASCII(extension_misc::kAccessExtensionPath)
+          .AppendASCII(iter->first);
+    }
+#endif
+
     std::string manifest =
         ResourceBundle::GetSharedInstance().GetRawDataResource(
             iter->second).as_string();
     extensions_service_->register_component_extension(
         ExtensionService::ComponentExtensionInfo(manifest, path));
   }
 }
 
 void ProfileImpl::InstallDefaultApps() {
   ExtensionService* extension_service = GetExtensionService();
@@ skipping 976 matching lines @@
 }
 
 PrerenderManager* ProfileImpl::GetPrerenderManager() {
   CommandLine* cl = CommandLine::ForCurrentProcess();
   if (!cl->HasSwitch(switches::kEnablePagePrerender))
     return NULL;
   if (!prerender_manager_)
     prerender_manager_ = new PrerenderManager(this);
   return prerender_manager_;
 }