Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1428)

Issue 6254003: Revert 71334 - Fix Pepper URL Loader callbacks.... (Closed)

Created:
9 years, 11 months ago by viettrungluu
Modified:
9 years, 6 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Revert 71334 - Fix Pepper URL Loader callbacks. [Not applying the "obvious" fix, since it might lead to callbacks being called incorrectly.] Add some tests (for aborting calls). BUG=none TEST=ppapi_tests Review URL: http://codereview.chromium.org/6220006 TBR=viettrungluu@chromium.org,jam@chromium.org,brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -141 lines) Patch
M ppapi/tests/test_file_io.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ppapi/tests/test_url_loader.h View 2 chunks +1 line, -2 lines 0 comments Download
M ppapi/tests/test_url_loader.cc View 6 chunks +6 lines, -67 lines 0 comments Download
M webkit/plugins/ppapi/ppb_url_loader_impl.h View 5 chunks +6 lines, -19 lines 0 comments Download
M webkit/plugins/ppapi/ppb_url_loader_impl.cc View 9 chunks +32 lines, -48 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
viettrungluu
9 years, 11 months ago (2011-01-14 00:37:53 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698