Issue 6220006: Fix Pepper URL Loader callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6220006: Fix Pepper URL Loader callbacks. (Closed)

Created:
9 years, 11 months ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
brettw

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix Pepper URL Loader callbacks. Add some tests (for aborting calls). BUG=none TEST=ppapi_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71334

Patch Set 1 #

Total comments: 1

Patch Set 2 : eliminated TODO per review #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+141 lines, -45 lines)			Patch
M	ppapi/tests/test_file_io.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	ppapi/tests/test_url_loader.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	ppapi/tests/test_url_loader.cc	View		6 chunks	+67 lines, -6 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_url_loader_impl.h	View	1	5 chunks	+19 lines, -6 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_url_loader_impl.cc	View		9 chunks	+48 lines, -32 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

9 years, 11 months ago (2011-01-13 03:08:30 UTC) #2

LGTM

http://codereview.chromium.org/6220006/diff/1/webkit/plugins/ppapi/ppb_url_lo...
File webkit/plugins/ppapi/ppb_url_loader_impl.h (right):

http://codereview.chromium.org/6220006/diff/1/webkit/plugins/ppapi/ppb_url_lo...
webkit/plugins/ppapi/ppb_url_loader_impl.h:150: // TODO(viettrungluu): does the
status callback need to be tracked? (and have
Extra tracking here shouldn't be necessary. This just allows the URLLoader to
call into the proxy without a direct dependency, and the proxy function should
handle everything.

Expand Messages | Collapse Messages