 Chromium Code Reviews
 Chromium Code Reviews Issue 6253012:
  Add ContentSettingsProvider Interface.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src
    
  
    Issue 6253012:
  Add ContentSettingsProvider Interface.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: chrome/browser/content_settings/content_identifier.h | 
| diff --git a/chrome/browser/content_settings/content_identifier.h b/chrome/browser/content_settings/content_identifier.h | 
| new file mode 100644 | 
| index 0000000000000000000000000000000000000000..f48a33724d4c16a8fc8ae64757993bddd00bba1b | 
| --- /dev/null | 
| +++ b/chrome/browser/content_settings/content_identifier.h | 
| @@ -0,0 +1,35 @@ | 
| +// Copyright (c) 2011 The Chromium Authors. All rights reserved. | 
| +// Use of this source code is governed by a BSD-style license that can be | 
| +// found in the LICENSE file. | 
| + | 
| +#ifndef CHROME_BROWSER_CONTENT_SETTINGS_CONTENT_IDENTIFIER_H_ | 
| +#define CHROME_BROWSER_CONTENT_SETTINGS_CONTENT_IDENTIFIER_H_ | 
| +#pragma once | 
| + | 
| +#include <string> | 
| + | 
| +#include "chrome/common/content_settings_types.h" | 
| + | 
| +namespace content_settings { | 
| + | 
| +typedef std::string ResourceIdentifier; | 
| 
jochen (gone - plz use gerrit)
2011/01/26 11:29:18
I think this should be part of the ProviderInterfa
 
markusheintz_
2011/01/26 15:27:08
Moved into the ContentSettingsProvider class.
 | 
| + | 
| +class ContentIdentifier { | 
| 
jochen (gone - plz use gerrit)
2011/01/26 11:29:18
This class should be std::pair<ContentSettingsType
 
markusheintz_
2011/01/26 15:27:08
Defined the pair in the ContentSettingsProvider In
 | 
| + public: | 
| + ContentIdentifier( | 
| + const ContentSettingsType& content_type, | 
| + const ResourceIdentifier& resource_identifier); | 
| 
Bernhard Bauer
2011/01/26 10:25:18
Are you going to implement these declared methods
 
markusheintz_
2011/01/26 15:27:08
uups will do if we keep the class. otherwise obsol
 | 
| + | 
| + bool operator==(const ContentIdentifier& other) const { | 
| + return (content_type_ == other.content_type_) && | 
| + (resource_identifier_ == other.resource_identifier_); | 
| + } | 
| + | 
| + private: | 
| + const ContentSettingsType content_type_; | 
| + const ResourceIdentifier resource_identifier_; | 
| +}; | 
| + | 
| +} // namespace content_Settings | 
| + | 
| +#endif // CHROME_BROWSER_CONTENT_SETTINGS_CONTENT_IDENTIFIER_H_ |