Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Side by Side Diff: chrome/browser/content_settings/content_identifier.h

Issue 6253012: Add ContentSettingsProvider Interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_CONTENT_SETTINGS_CONTENT_IDENTIFIER_H_
6 #define CHROME_BROWSER_CONTENT_SETTINGS_CONTENT_IDENTIFIER_H_
7 #pragma once
8
9 #include <string>
10
11 #include "chrome/common/content_settings_types.h"
12
13 namespace content_settings {
14
15 typedef std::string ResourceIdentifier;
jochen (gone - plz use gerrit) 2011/01/26 11:29:18 I think this should be part of the ProviderInterfa
markusheintz_ 2011/01/26 15:27:08 Moved into the ContentSettingsProvider class.
16
17 class ContentIdentifier {
jochen (gone - plz use gerrit) 2011/01/26 11:29:18 This class should be std::pair<ContentSettingsType
markusheintz_ 2011/01/26 15:27:08 Defined the pair in the ContentSettingsProvider In
18 public:
19 ContentIdentifier(
20 const ContentSettingsType& content_type,
21 const ResourceIdentifier& resource_identifier);
Bernhard Bauer 2011/01/26 10:25:18 Are you going to implement these declared methods
markusheintz_ 2011/01/26 15:27:08 uups will do if we keep the class. otherwise obsol
22
23 bool operator==(const ContentIdentifier& other) const {
24 return (content_type_ == other.content_type_) &&
25 (resource_identifier_ == other.resource_identifier_);
26 }
27
28 private:
29 const ContentSettingsType content_type_;
30 const ResourceIdentifier resource_identifier_;
31 };
32
33 } // namespace content_Settings
34
35 #endif // CHROME_BROWSER_CONTENT_SETTINGS_CONTENT_IDENTIFIER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698