Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 6250198: More out-of-lining of test code, along with a bunch of GMOCK objects. (Closed)

Created:
9 years, 10 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
Reviewers:
Nico, awong
CC:
chromium-reviews, vrk (LEFT CHROMIUM), annacc, ajwong+watch_chromium.org, cbentzel+watch_chromium.org, Erik does not do reviews, dmaclach+watch_chromium.org, apatrick_chromium, darin-cc_chromium.org, ddorwin+watch_chromium.org, wez+watch_chromium.org, simonmorris+watch_chromium.org, pam+watch_chromium.org, piman+watch_chromium.org, sergeyu+watch_chromium.org, scherkus (not reviewing), jamiewalch+watch_chromium.org, hclam+watch_chromium.org, sjl, garykac+watch_chromium.org, Aaron Boodman, acolwell GONE FROM CHROMIUM, lambroslambrou+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

More out-of-lining of test code, along with a bunch of GMOCK objects. Most notably, rename various mock_objects.h files in remoting/ because after deinlining, there were compile failures. This fixes Windows compiling because you can't have two implementation files with the same name in a project, even if they are in different directories. (The output from one compile will clobber the others!) BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74059

Patch Set 1 #

Patch Set 2 : Remove automated updated copyrights #

Patch Set 3 : Fix Windows build by making file names unique across directories #

Patch Set 4 : Really fix the gyp files this time #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+491 lines, -216 lines) Patch
M chrome/browser/extensions/extension_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/net/test_url_fetcher_factory.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/common/net/test_url_fetcher_factory.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/service/service_process_prefs.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/service/service_process_prefs.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/test_url_request_context_getter.h View 2 chunks +10 lines, -10 lines 0 comments Download
A chrome/test/test_url_request_context_getter.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/test/testing_browser_process.h View 2 chunks +63 lines, -149 lines 1 comment Download
A chrome/test/testing_browser_process.cc View 1 1 chunk +194 lines, -0 lines 0 comments Download
M chrome/test/unit/chrome_test_suite.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 2 chunks +3 lines, -8 lines 0 comments Download
A gpu/command_buffer/service/gles2_cmd_decoder_mock.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 chunk +2 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M gpu/gpu.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M media/tools/omx_test/file_reader_util.h View 2 chunks +3 lines, -0 lines 0 comments Download
M media/tools/omx_test/file_reader_util.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M remoting/host/chromoting_host_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/host/host_mock_objects.h View 1 2 4 chunks +8 lines, -6 lines 0 comments Download
A remoting/host/host_mock_objects.cc View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
M remoting/host/screen_recorder_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/jingle_glue/jingle_glue_mock_objects.h View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
A remoting/jingle_glue/jingle_glue_mock_objects.cc View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M remoting/jingle_glue/stream_socket_adapter_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/connection_to_client_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + remoting/protocol/protocol_mock_objects.h View 1 2 9 chunks +19 lines, -12 lines 0 comments Download
A remoting/protocol/protocol_mock_objects.cc View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
M remoting/remoting.gyp View 1 2 3 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Elliot Glaysher
Review to thakis, FYI to ajwong about the file name issue on windows.
9 years, 10 months ago (2011-02-07 21:24:28 UTC) #1
Nico
LG Are you sure the obj files clobber each other? Is that per vcproj / ...
9 years, 10 months ago (2011-02-07 23:24:28 UTC) #2
Elliot Glaysher
9 years, 10 months ago (2011-02-07 23:36:09 UTC) #3
On 2011/02/07 23:24:28, Nico wrote:
> Are you sure the obj files clobber each other? Is that per vcproj / gyp?

Yes and it's per vcproj. Check the earlier runs that failed to compile and were
fixed by simple renames, along with general experience with this happening in
the past.

> (linux trybot red, not sure if related)

Green trybot run right before. Flake.

Powered by Google App Engine
This is Rietveld 408576698