Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: chrome/common/net/test_url_fetcher_factory.cc

Issue 6250198: More out-of-lining of test code, along with a bunch of GMOCK objects. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Really fix the gyp files this time Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/net/test_url_fetcher_factory.h" 5 #include "chrome/common/net/test_url_fetcher_factory.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/message_loop.h" 10 #include "base/message_loop.h"
11 #include "net/url_request/url_request_status.h" 11 #include "net/url_request/url_request_status.h"
12 12
13 TestURLFetcher::TestURLFetcher(int id, 13 TestURLFetcher::TestURLFetcher(int id,
14 const GURL& url, 14 const GURL& url,
15 URLFetcher::RequestType request_type, 15 URLFetcher::RequestType request_type,
16 URLFetcher::Delegate* d) 16 URLFetcher::Delegate* d)
17 : URLFetcher(url, request_type, d), 17 : URLFetcher(url, request_type, d),
18 id_(id), 18 id_(id),
19 original_url_(url) { 19 original_url_(url) {
20 } 20 }
21 21
22 TestURLFetcherFactory::TestURLFetcherFactory() {}
23
24 TestURLFetcherFactory::~TestURLFetcherFactory() {}
25
22 URLFetcher* TestURLFetcherFactory::CreateURLFetcher( 26 URLFetcher* TestURLFetcherFactory::CreateURLFetcher(
23 int id, 27 int id,
24 const GURL& url, 28 const GURL& url,
25 URLFetcher::RequestType request_type, 29 URLFetcher::RequestType request_type,
26 URLFetcher::Delegate* d) { 30 URLFetcher::Delegate* d) {
27 TestURLFetcher* fetcher = new TestURLFetcher(id, url, request_type, d); 31 TestURLFetcher* fetcher = new TestURLFetcher(id, url, request_type, d);
28 fetchers_[id] = fetcher; 32 fetchers_[id] = fetcher;
29 return fetcher; 33 return fetcher;
30 } 34 }
31 35
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 GURL url_; 84 GURL url_;
81 std::string response_data_; 85 std::string response_data_;
82 bool success_; 86 bool success_;
83 87
84 // Method factory used to run the delegate. 88 // Method factory used to run the delegate.
85 ScopedRunnableMethodFactory<FakeURLFetcher> method_factory_; 89 ScopedRunnableMethodFactory<FakeURLFetcher> method_factory_;
86 90
87 DISALLOW_COPY_AND_ASSIGN(FakeURLFetcher); 91 DISALLOW_COPY_AND_ASSIGN(FakeURLFetcher);
88 }; 92 };
89 93
94 FakeURLFetcherFactory::FakeURLFetcherFactory() {}
95
96 FakeURLFetcherFactory::~FakeURLFetcherFactory() {}
97
90 URLFetcher* FakeURLFetcherFactory::CreateURLFetcher( 98 URLFetcher* FakeURLFetcherFactory::CreateURLFetcher(
91 int id, 99 int id,
92 const GURL& url, 100 const GURL& url,
93 URLFetcher::RequestType request_type, 101 URLFetcher::RequestType request_type,
94 URLFetcher::Delegate* d) { 102 URLFetcher::Delegate* d) {
95 FakeResponseMap::const_iterator it = fake_responses_.find(url); 103 FakeResponseMap::const_iterator it = fake_responses_.find(url);
96 if (it == fake_responses_.end()) { 104 if (it == fake_responses_.end()) {
97 // If we don't have a baked response for that URL we return NULL. 105 // If we don't have a baked response for that URL we return NULL.
98 DLOG(ERROR) << "No baked response for URL: " << url.spec(); 106 DLOG(ERROR) << "No baked response for URL: " << url.spec();
99 return NULL; 107 return NULL;
100 } 108 }
101 return new FakeURLFetcher(url, request_type, d, 109 return new FakeURLFetcher(url, request_type, d,
102 it->second.first, it->second.second); 110 it->second.first, it->second.second);
103 } 111 }
104 112
105 void FakeURLFetcherFactory::SetFakeResponse(const std::string& url, 113 void FakeURLFetcherFactory::SetFakeResponse(const std::string& url,
106 const std::string& response_data, 114 const std::string& response_data,
107 bool success) { 115 bool success) {
108 // Overwrite existing URL if it already exists. 116 // Overwrite existing URL if it already exists.
109 fake_responses_[GURL(url)] = std::make_pair(response_data, success); 117 fake_responses_[GURL(url)] = std::make_pair(response_data, success);
110 } 118 }
111 119
112 void FakeURLFetcherFactory::ClearFakeReponses() { 120 void FakeURLFetcherFactory::ClearFakeReponses() {
113 fake_responses_.clear(); 121 fake_responses_.clear();
114 } 122 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698