Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 6250180: Merge 77705 - 2011-02-04 Charlie Reis <creis@chromium.org>... (Closed)

Created:
9 years, 10 months ago by Mihai Parparita -not on Chrome
Modified:
9 years, 6 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/648/
Visibility:
Public.

Description

Merge 77705 - 2011-02-04 Charlie Reis <creis@chromium.org>; Reviewed by Mihai Parparita. Crash in WebCore::HistoryController::itemsAreClones https://bugs.webkit.org/show_bug.cgi?id=52819 Tests that navigating back and forward between hash items works. * fast/history/history-back-forward-within-subframe-hash.html: Added. * fast/history/history-back-forward-within-subframe-hash-expected.txt: Added. 2011-02-04 Charlie Reis <creis@chromium.org>; Reviewed by Mihai Parparita. Crash in WebCore::HistoryController::itemsAreClones https://bugs.webkit.org/show_bug.cgi?id=52819 Avoids deleting the current HistoryItem while it is still in use. Ensures that provisional items are committed for same document navigations. Ensures that error pages are committed on back/forward navigations. Also removes unneeded sanity checks used for diagnosing the problem. * loader/HistoryController.cpp: * loader/HistoryController.h: 2011-02-04 Charlie Reis <creis@chromium.org>; Reviewed by Mihai Parparita. Crash in WebCore::HistoryController::itemsAreClones https://bugs.webkit.org/show_bug.cgi?id=52819 Removes unneeded sanity checks used for diagnosing a memory error. * src/WebFrameImpl.cpp: BUG=70315 TBR=creis@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77736

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6216 lines, -22 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +2364 lines, -0 lines 0 comments Download
A + LayoutTests/fast/history/history-back-forward-within-subframe-hash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/history/history-back-forward-within-subframe-hash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +3082 lines, -0 lines 0 comments Download
M Source/WebCore/loader/HistoryController.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/loader/HistoryController.cpp View 7 chunks +33 lines, -13 lines 0 comments Download
M Source/WebKit/chromium/ChangeLog View 1 chunk +737 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebFrameImpl.cpp View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Mihai Parparita -not on Chrome
9 years, 10 months ago (2011-02-05 07:37:47 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698