Index: Source/WebCore/ChangeLog |
=================================================================== |
--- Source/WebCore/ChangeLog (revision 77734) |
+++ Source/WebCore/ChangeLog (working copy) |
@@ -1,3 +1,3085 @@ |
+2011-02-04 Charlie Reis <creis@chromium.org> |
+ |
+ Reviewed by Mihai Parparita. |
+ |
+ Crash in WebCore::HistoryController::itemsAreClones |
+ https://bugs.webkit.org/show_bug.cgi?id=52819 |
+ |
+ Avoids deleting the current HistoryItem while it is still in use. |
+ Ensures that provisional items are committed for same document navigations. |
+ Ensures that error pages are committed on back/forward navigations. |
+ Also removes unneeded sanity checks used for diagnosing the problem. |
+ |
+ * loader/HistoryController.cpp: |
+ * loader/HistoryController.h: |
+ |
+2011-02-04 Carol Szabo <carol.szabo@nokia.com> |
+ |
+ Reviewed by David Hyatt. |
+ |
+ Code Changes. |
+ |
+ CSS 2.1 failure: content-* |
+ https://bugs.webkit.org/show_bug.cgi?id=52126 |
+ |
+ Test: fast/css/counters/content-021.html |
+ |
+ * rendering/CounterNode.cpp: |
+ (showCounterTree): |
+ Made parameter const because it is supposed to be so. |
+ * rendering/RenderCounter.cpp: |
+ (WebCore::previousInPreOrder): |
+ (WebCore::previousSiblingOrParent): |
+ (WebCore::parentElement): |
+ (WebCore::areRenderersElementsSiblings): |
+ (WebCore::nextInPreOrder): |
+ Added these local helper functions to help navigate the DOM tree |
+ enriched with :before and :after pseudo elements. |
+ (WebCore::planCounter): |
+ Fixed bug that would create a repeat counter for second and |
+ subsequent renderers associated with the same DOM element. |
+ (WebCore::findPlaceForCounter): |
+ (WebCore::makeCounterNode): |
+ Changed to use the new tree navigation functions described above |
+ instead of the Renderer Tree navigation functions. |
+ (WebCore::RenderCounter::rendererSubtreeAttached): |
+ (WebCore::RenderCounter::rendererStyleChanged): |
+ Optimized to not bother about counters until the renderers are |
+ finally attached. |
+ (showRendererTree): |
+ (showNodeTree): |
+ Debug helper functions used to debug Counter bugs. |
+ |
+2011-02-04 Dan Bernstein <mitz@apple.com> |
+ |
+ Typo fix. |
+ |
+ * html/parser/XSSFilter.cpp: |
+ (WebCore::HTMLNames::containsJavaScriptURL): |
+ |
+2011-02-04 Dan Bernstein <mitz@apple.com> |
+ |
+ Reviewed by Anders Carlsson. |
+ |
+ Make an infinite loop introduced in r77454 finite. |
+ |
+ * html/parser/XSSFilter.cpp: |
+ (WebCore::HTMLNames::containsJavaScriptURL): |
+ |
+2011-02-04 Jer Noble <jer.noble@apple.com> |
+ |
+ Reviewed by Eric Carlson. |
+ |
+ Frame accurate seeking isn't always accurate |
+ https://bugs.webkit.org/show_bug.cgi?id=52697 |
+ |
+ Test: media/video-frame-accurate-seek.html |
+ |
+ Make seeking slightly more accurate by rounding instead of truncating |
+ when converting from seconds-in-float to time/timeScale. |
+ |
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: |
+ (WebCore::MediaPlayerPrivateQTKit::createQTTime): |
+ * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: |
+ (WebCore::MediaPlayerPrivateQuickTimeVisualContext::mediaTimeForTimeValue): |
+ * platform/graphics/win/QTMovie.cpp: |
+ (QTMovie::setCurrentTime): |
+ |
+2011-02-04 Jeremy Orlow <jorlow@chromium.org> |
+ |
+ Reviewed by Nate Chapin. |
+ |
+ Second IndexedDB events overhaul patch |
+ https://bugs.webkit.org/show_bug.cgi?id=53813 |
+ |
+ If an IDBRequest has a IDBTransaction, it should propogate |
+ events through it. In order to do this, IDBRequest needs to |
+ hold a transaction frontend object rather than a backend one. |
+ |
+ Test: storage/indexeddb/request-event-propagation.html |
+ |
+ * storage/IDBCursor.cpp: |
+ (WebCore::IDBCursor::IDBCursor): |
+ * storage/IDBCursor.h: |
+ (WebCore::IDBCursor::create): |
+ * storage/IDBDatabase.cpp: |
+ (WebCore::IDBDatabase::setSetVersionTransaction): |
+ (WebCore::IDBDatabase::createObjectStore): |
+ (WebCore::IDBDatabase::deleteObjectStore): |
+ * storage/IDBDatabase.h: |
+ * storage/IDBIndex.cpp: |
+ (WebCore::IDBIndex::IDBIndex): |
+ (WebCore::IDBIndex::openCursor): |
+ (WebCore::IDBIndex::openKeyCursor): |
+ (WebCore::IDBIndex::get): |
+ (WebCore::IDBIndex::getKey): |
+ * storage/IDBIndex.h: |
+ (WebCore::IDBIndex::create): |
+ * storage/IDBObjectStore.cpp: |
+ (WebCore::IDBObjectStore::IDBObjectStore): |
+ (WebCore::IDBObjectStore::get): |
+ (WebCore::IDBObjectStore::add): |
+ (WebCore::IDBObjectStore::put): |
+ (WebCore::IDBObjectStore::deleteFunction): |
+ (WebCore::IDBObjectStore::createIndex): |
+ (WebCore::IDBObjectStore::deleteIndex): |
+ (WebCore::IDBObjectStore::openCursor): |
+ * storage/IDBObjectStore.h: |
+ (WebCore::IDBObjectStore::create): |
+ * storage/IDBRequest.cpp: |
+ (WebCore::IDBRequest::create): |
+ (WebCore::IDBRequest::IDBRequest): |
+ (WebCore::IDBRequest::resetReadyState): |
+ (WebCore::IDBRequest::onSuccess): |
+ (WebCore::IDBRequest::dispatchEvent): |
+ * storage/IDBRequest.h: |
+ * storage/IDBTransaction.cpp: |
+ (WebCore::IDBTransaction::IDBTransaction): |
+ (WebCore::IDBTransaction::objectStore): |
+ (WebCore::IDBTransaction::contextDestroyed): |
+ (WebCore::IDBTransaction::enqueueEvent): |
+ * storage/IDBTransaction.h: |
+ * storage/IDBTransaction.idl: |
+ |
+2011-02-04 Jeremy Orlow <jorlow@chromium.org> |
+ |
+ Reviewed by Nate Chapin. |
+ |
+ First step towards event propogation within IndexedDB |
+ https://bugs.webkit.org/show_bug.cgi?id=53795 |
+ |
+ This is the first step towards implementing |
+ http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348 |
+ within IndexedDB. I've created a method that knows how |
+ to capture and bubble (based on Node's dispatchGenericEvent). |
+ I've then changed IDBRequest to use it. |
+ |
+ The only functional change is that preventDefault now must |
+ be called in error events to prevent the transaction from |
+ being aborted. The tests reflect this change and there's one |
+ specific test to look at this behavior. |
+ |
+ Test: storage/indexeddb/error-causes-abort-by-default.html |
+ |
+ * storage/IDBAbortEvent.cpp: |
+ (WebCore::IDBAbortEvent::create): |
+ (WebCore::IDBAbortEvent::IDBAbortEvent): |
+ * storage/IDBAbortEvent.h: |
+ * storage/IDBCompleteEvent.cpp: |
+ (WebCore::IDBCompleteEvent::create): |
+ (WebCore::IDBCompleteEvent::IDBCompleteEvent): |
+ * storage/IDBCompleteEvent.h: |
+ * storage/IDBErrorEvent.cpp: |
+ (WebCore::IDBErrorEvent::IDBErrorEvent): |
+ * storage/IDBEvent.cpp: |
+ (WebCore::IDBEvent::IDBEvent): |
+ (WebCore::IDBEvent::dispatch): |
+ * storage/IDBEvent.h: |
+ * storage/IDBRequest.cpp: |
+ (WebCore::IDBRequest::dispatchEvent): |
+ * storage/IDBRequest.h: |
+ * storage/IDBSuccessEvent.cpp: |
+ (WebCore::IDBSuccessEvent::IDBSuccessEvent): |
+ * storage/IDBTransaction.cpp: |
+ (WebCore::IDBTransaction::onAbort): |
+ (WebCore::IDBTransaction::onComplete): |
+ * storage/IDBTransaction.h: |
+ (WebCore::IDBTransaction::backend): |
+ * storage/IDBTransactionBackendImpl.cpp: |
+ (WebCore::IDBTransactionBackendImpl::taskTimerFired): |
+ |
+2011-02-04 Daniel Cheng <dcheng@chromium.org> |
+ |
+ Reviewed by Dmitry Titov. |
+ |
+ Clone WebClipboard to be frame-specific. |
+ https://bugs.webkit.org/show_bug.cgi?id=53727 |
+ |
+ For drop operations, Chrome currently snapshots the data and copies it |
+ into the renderer process. As we add more supported drag data types, the |
+ copy will become increasingly expensive. Instead, we'd like to snapshot |
+ data in the browser to reduce the amount of data copied and to support |
+ Blob in DataTransferItem. In order to allow this, we associated |
+ WebClipboard with a frame so it can correctly route its IPCs to the |
+ corresponding Chromium host. |
+ |
+ No new tests because no new functionality. |
+ |
+ * platform/chromium/ChromiumDataObject.cpp: |
+ (WebCore::ChromiumDataObject::createReadable): |
+ * platform/chromium/ChromiumDataObject.h: |
+ * platform/chromium/ClipboardChromium.cpp: |
+ (WebCore::ClipboardChromium::create): |
+ * platform/chromium/PlatformBridge.h: |
+ * platform/chromium/ReadableDataObject.cpp: |
+ (WebCore::ReadableDataObject::create): |
+ (WebCore::ReadableDataObject::ReadableDataObject): |
+ (WebCore::ReadableDataObject::getData): |
+ (WebCore::ReadableDataObject::urlTitle): |
+ (WebCore::ReadableDataObject::htmlBaseUrl): |
+ (WebCore::ReadableDataObject::filenames): |
+ (WebCore::ReadableDataObject::ensureTypeCacheInitialized): |
+ * platform/chromium/ReadableDataObject.h: |
+ |
+2011-02-04 Jeremy Orlow <jorlow@chromium.org> |
+ |
+ Revert https://bugs.webkit.org/show_bug.cgi?id=53795 |
+ |
+ * storage/IDBAbortEvent.cpp: |
+ (WebCore::IDBAbortEvent::create): |
+ (WebCore::IDBAbortEvent::IDBAbortEvent): |
+ * storage/IDBAbortEvent.h: |
+ * storage/IDBCompleteEvent.cpp: |
+ (WebCore::IDBCompleteEvent::create): |
+ (WebCore::IDBCompleteEvent::IDBCompleteEvent): |
+ * storage/IDBCompleteEvent.h: |
+ * storage/IDBErrorEvent.cpp: |
+ (WebCore::IDBErrorEvent::IDBErrorEvent): |
+ * storage/IDBEvent.cpp: |
+ (WebCore::IDBEvent::IDBEvent): |
+ * storage/IDBEvent.h: |
+ * storage/IDBRequest.cpp: |
+ (WebCore::IDBRequest::dispatchEvent): |
+ * storage/IDBRequest.h: |
+ * storage/IDBSuccessEvent.cpp: |
+ (WebCore::IDBSuccessEvent::IDBSuccessEvent): |
+ * storage/IDBTransaction.cpp: |
+ (WebCore::IDBTransaction::onAbort): |
+ (WebCore::IDBTransaction::onComplete): |
+ * storage/IDBTransaction.h: |
+ * storage/IDBTransactionBackendImpl.cpp: |
+ (WebCore::IDBTransactionBackendImpl::taskTimerFired): |
+ |
+2011-02-04 Martin Galpin <martin@66laps.com> |
+ |
+ Reviewed by David Levin. |
+ |
+ CORS origin header not set on GET when a preflight request is required. |
+ https://bugs.webkit.org/show_bug.cgi?id=50773 |
+ |
+ Test: http/tests/xmlhttprequest/cross-origin-preflight-get.html |
+ |
+ * loader/DocumentThreadableLoader.cpp: |
+ (WebCore::DocumentThreadableLoader::preflightSuccess): |
+ Explicitly set the request origin after a preflight request succeeds. |
+ |
+2011-02-04 Jeremy Orlow <jorlow@chromium.org> |
+ |
+ Reviewed by Nate Chapin. |
+ |
+ First step towards event propogation within IndexedDB |
+ https://bugs.webkit.org/show_bug.cgi?id=53795 |
+ |
+ This is the first step towards implementing |
+ http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348 |
+ within IndexedDB. I've created a method that knows how |
+ to capture and bubble (based on Node's dispatchGenericEvent). |
+ I've then changed IDBRequest to use it. |
+ |
+ The only functional change is that preventDefault now must |
+ be called in error events to prevent the transaction from |
+ being aborted. The tests reflect this change and there's one |
+ specific test to look at this behavior. |
+ |
+ Test: storage/indexeddb/error-causes-abort-by-default.html |
+ |
+ * storage/IDBAbortEvent.cpp: |
+ (WebCore::IDBAbortEvent::create): |
+ (WebCore::IDBAbortEvent::IDBAbortEvent): |
+ * storage/IDBAbortEvent.h: |
+ * storage/IDBCompleteEvent.cpp: |
+ (WebCore::IDBCompleteEvent::create): |
+ (WebCore::IDBCompleteEvent::IDBCompleteEvent): |
+ * storage/IDBCompleteEvent.h: |
+ * storage/IDBErrorEvent.cpp: |
+ (WebCore::IDBErrorEvent::IDBErrorEvent): |
+ * storage/IDBEvent.cpp: |
+ (WebCore::IDBEvent::IDBEvent): |
+ (WebCore::IDBEvent::dispatch): |
+ * storage/IDBEvent.h: |
+ * storage/IDBRequest.cpp: |
+ (WebCore::IDBRequest::dispatchEvent): |
+ * storage/IDBRequest.h: |
+ * storage/IDBSuccessEvent.cpp: |
+ (WebCore::IDBSuccessEvent::IDBSuccessEvent): |
+ * storage/IDBTransaction.cpp: |
+ (WebCore::IDBTransaction::onAbort): |
+ (WebCore::IDBTransaction::onComplete): |
+ * storage/IDBTransaction.h: |
+ (WebCore::IDBTransaction::backend): |
+ * storage/IDBTransactionBackendImpl.cpp: |
+ (WebCore::IDBTransactionBackendImpl::taskTimerFired): |
+ |
+2011-02-04 Dimitri Glazkov <dglazkov@chromium.org> |
+ |
+ Reviewed by Csaba Osztrogonác. |
+ |
+ [Qt]REGRESSION(r76951): media/controls-without-preload.html fails |
+ https://bugs.webkit.org/show_bug.cgi?id=53674 |
+ |
+ * css/mediaControlsQt.css: |
+ |
+2011-02-04 Dan Bernstein <mitz@apple.com> |
+ |
+ Reviewed by Darin Adler and Dave Hyatt. |
+ |
+ <rdar://problem/8902704> Make ruby text size 50% by default |
+ https://bugs.webkit.org/show_bug.cgi?id=53723 |
+ |
+ * css/html.css: |
+ (ruby > rt): Changed the font-size from 60% to 50%. |
+ |
+2011-02-04 Antti Koivisto <antti@apple.com> |
+ |
+ Reviewed by Dimitri Glazkov. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=53610 |
+ Regression: adjacent sibling selector not working as expected |
+ <rdar://problem/8960033> |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=53574 |
+ REGRESSION (r76012): :last-child:after not working as expected |
+ <rdar://problem/8948643> |
+ |
+ Test for additional conditions in parent style that prevent sharing. |
+ |
+ Tests: fast/selectors/style-sharing-adjacent-selector.html |
+ fast/selectors/style-sharing-last-child.html |
+ |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::parentStylePreventsSharing): |
+ (WebCore::CSSStyleSelector::locateSharedStyle): |
+ |
+2011-02-04 Mark Mentovai <mark@chromium.org> |
+ |
+ Reviewed by Dimitri Glazkov. |
+ |
+ Chromium GYP build fix. |
+ |
+ When various settings were moved to webcore_prerequisites in r66364, |
+ things that should have been direct_dependent_settings were not marked |
+ as such. GYP 'defines', for example, make no sense on a 'none'-type |
+ target such as webcore_prerequisites. It appears that it was intended |
+ for these settings to be pushed to direct dependents, which would make |
+ direct_dependent_settings correct. |
+ |
+ Losing the ChromiumWebCoreObjC defines on the Mac, for example, caused |
+ http://crbug.com/71537, which at best causes Mac console log spew, and |
+ at worst may result in Chromium's copy of WebCore using system |
+ definitions of certain Objective-C classes at runtime, or vice-versa. |
+ |
+ The build now includes a postbuild step to prevent |
+ http://crbug.com/71537 from regressing again. The build will fail upon |
+ regression. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=53630 |
+ |
+ * WebCore.gyp/WebCore.gyp: Move things in webcore_prerequisites into |
+ direct_dependent_settings as needed, add the check_objc_rename |
+ postbuild step. |
+ * WebCore.gyp/mac/check_objc_rename.sh: Added. |
+ |
+2011-02-04 Robert Hogan <robert@webkit.org> |
+ |
+ Reviewed by Darin Fisher. |
+ |
+ Move chromium iframe shim code to cross-platform file |
+ https://bugs.webkit.org/show_bug.cgi?id=52594 |
+ |
+ Move Chromium code for identifying and cutting out |
+ iframe shims from plugins to cross-platform utility file |
+ IFrameShimSupport.cpp. |
+ Amend PluginViewQt to use this code to handle shims correctly. |
+ |
+ * WebCore.gypi: Add Chromium support for IFrameShimSupport.cpp |
+ * WebCore.pro: Add Qt support for IFrameShimSupport.cpp |
+ * plugins/IFrameShimSupport.cpp: Added. |
+ (WebCore::getObjectStack): |
+ (WebCore::iframeIsAbovePlugin): |
+ (WebCore::getPluginOcclusions): |
+ * plugins/IFframeShimSupport.h: Added. |
+ * plugins/qt/PluginViewQt.cpp: |
+ (WebCore::PluginView::setNPWindowIfNeeded): |
+ |
+2011-02-04 Xiaomei Ji <xji@chromium.org> |
+ |
+ Reviewed by David Levin. |
+ |
+ Implement "<option> should implement the dir attribute" for chromium port after r76983. |
+ https://bugs.webkit.org/show_bug.cgi?id=50969 |
+ |
+ Use manual test Source/WebCore/manual-tests/pop-up-alignment-and-direction.html |
+ added in r76983. |
+ |
+ * platform/chromium/PopupMenuChromium.cpp: Remove directionality hint from |
+ <select> drop-down setting. |
+ (WebCore::PopupListBox::paintRow): Use <option>'s directionality to paint |
+ items in drop-down and pass-in bidi override flag when creating text run. |
+ * platform/chromium/PopupMenuChromium.h: Remove directionalityHint from |
+ PopupContainerSettings. |
+ |
+2011-02-04 Jeremy Orlow <jorlow@chromium.org> |
+ |
+ Build fix from merge mistake. |
+ |
+ * storage/IDBTransaction.cpp: |
+ (WebCore::IDBTransaction::ensureEventTargetData): |
+ |
+2011-02-04 Levi Weintraub <leviw@chromium.org> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Remove unneeded function declarations in comments in EditorClient.h |
+ https://bugs.webkit.org/show_bug.cgi?id=53745 |
+ |
+ Removing unused commented out function declarations. No tests since this is just cleanup. |
+ |
+ * page/EditorClient.h: |
+ |
+2011-02-03 Jeremy Orlow <jorlow@chromium.org> |
+ |
+ Reviewed by Nate Chapin. |
+ |
+ Refactor IDBRequest and IDBTransaction a bit |
+ https://bugs.webkit.org/show_bug.cgi?id=53565 |
+ |
+ There were a lot of subtle issues with the way IDBTransaction |
+ and IDBRequest used to be written. This cleans a lot of them up |
+ and largely simplifies the logic. Using EventQueue rather than |
+ timers is one example of the simplification. |
+ |
+ * bindings/scripts/CodeGeneratorV8.pm: |
+ * dom/EventQueue.cpp: |
+ (WebCore::EventQueue::enqueueEvent): |
+ (WebCore::EventQueue::dispatchEvent): |
+ * storage/IDBCursor.cpp: |
+ (WebCore::IDBCursor::continueFunction): |
+ * storage/IDBRequest.cpp: |
+ (WebCore::IDBRequest::create): |
+ (WebCore::IDBRequest::IDBRequest): |
+ (WebCore::IDBRequest::resetReadyState): |
+ (WebCore::IDBRequest::onError): |
+ (WebCore::IDBRequest::onSuccess): |
+ (WebCore::IDBRequest::dispatchEvent): |
+ (WebCore::IDBRequest::enqueueEvent): |
+ (WebCore::IDBRequest::eventTargetData): |
+ (WebCore::IDBRequest::ensureEventTargetData): |
+ * storage/IDBRequest.h: |
+ (WebCore::IDBRequest::dispatchEvent): |
+ * storage/IDBTransaction.cpp: |
+ (WebCore::IDBTransaction::create): |
+ (WebCore::IDBTransaction::IDBTransaction): |
+ (WebCore::IDBTransaction::objectStore): |
+ (WebCore::IDBTransaction::abort): |
+ (WebCore::IDBTransaction::onAbort): |
+ (WebCore::IDBTransaction::onComplete): |
+ (WebCore::IDBTransaction::onTimeout): |
+ (WebCore::IDBTransaction::canSuspend): |
+ (WebCore::IDBTransaction::stop): |
+ (WebCore::IDBTransaction::enqueueEvent): |
+ (WebCore::IDBTransaction::eventTargetData): |
+ (WebCore::IDBTransaction::ensureEventTargetData): |
+ * storage/IDBTransaction.h: |
+ |
+2011-02-01 Jeremy Orlow <jorlow@chromium.org> |
+ |
+ Reviewed by Nate Chapin. |
+ |
+ Remove the timeout event from IndexedDB |
+ https://bugs.webkit.org/show_bug.cgi?id=53521 |
+ |
+ Remove timeout and ontimeout from IDBTransaction per the spec. |
+ |
+ * WebCore.gypi: |
+ * storage/IDBDatabase.cpp: |
+ (WebCore::IDBDatabase::transaction): |
+ * storage/IDBDatabase.h: |
+ (WebCore::IDBDatabase::transaction): |
+ * storage/IDBDatabase.idl: |
+ * storage/IDBDatabaseBackendImpl.cpp: |
+ (WebCore::IDBDatabaseBackendImpl::setVersion): |
+ (WebCore::IDBDatabaseBackendImpl::transaction): |
+ * storage/IDBDatabaseBackendImpl.h: |
+ * storage/IDBDatabaseBackendInterface.h: |
+ * storage/IDBTimeoutEvent.cpp: Removed. |
+ * storage/IDBTimeoutEvent.h: Removed. |
+ * storage/IDBTransaction.cpp: |
+ (WebCore::IDBTransaction::IDBTransaction): |
+ (WebCore::IDBTransaction::onAbort): |
+ (WebCore::IDBTransaction::onComplete): |
+ * storage/IDBTransaction.h: |
+ * storage/IDBTransaction.idl: |
+ * storage/IDBTransactionBackendImpl.cpp: |
+ (WebCore::IDBTransactionBackendImpl::create): |
+ (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl): |
+ * storage/IDBTransactionBackendImpl.h: |
+ * storage/IDBTransactionCallbacks.h: |
+ |
+2011-02-04 Chris Fleizach <cfleizach@apple.com> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ AX: Can't set accessibility overridden attributes on web objects |
+ https://bugs.webkit.org/show_bug.cgi?id=53725 |
+ |
+ accessibilitySetOverriddenValue does not work on AX objects from WebCore because |
+ the right method needed to be overridden (accessibilitySupportsOverriddenAttributes). |
+ Unfortunately, there's no way to test this from DRT, since AppKit returns the overridden |
+ attribute only when an AX client asks for it through the AX frameworks. |
+ |
+ * accessibility/mac/AccessibilityObjectWrapper.mm: |
+ (-[AccessibilityObjectWrapper accessibilitySupportsOverriddenAttributes]): |
+ |
+2011-02-03 Dimitri Glazkov <dglazkov@chromium.org> |
+ |
+ Reviewed by Kent Tamura. |
+ |
+ REGRESSION(r76147): Slider thumb is not repainted when let go outside of the slider track. |
+ https://bugs.webkit.org/show_bug.cgi?id=53691 |
+ |
+ Test: fast/repaint/slider-thumb-drag-release.html |
+ |
+ * html/shadow/SliderThumbElement.cpp: |
+ (WebCore::SliderThumbElement::stopDragging): Added dirtying the layout bit to ensure |
+ that the thumb is repainted. |
+ |
+2011-02-04 Mikhail Naganov <mnaganov@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: Add "show more" data grid node and waiting message UI components. |
+ https://bugs.webkit.org/show_bug.cgi?id=53763 |
+ |
+ - "show more" data grid node is used for on-demand population of |
+ data grid contents (similar to DOM tree capability for limiting |
+ displayed nodes count); |
+ |
+ - waiting message is used for informing user about long lasting |
+ operations (with a possibility to cancel them). |
+ |
+ * English.lproj/localizedStrings.js: |
+ * WebCore.gypi: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * inspector/front-end/PleaseWaitMessage.js: Added. |
+ (WebInspector.PleaseWaitMessage): |
+ * inspector/front-end/ShowMoreDataGridNode.js: Added. |
+ (WebInspector.ShowMoreDataGridNode): |
+ * inspector/front-end/WebKit.qrc: |
+ * inspector/front-end/inspector.css: |
+ (.data-grid button): |
+ (.please-wait-msg): |
+ * inspector/front-end/inspector.html: |
+ |
+2011-02-04 Adele Peterson <adele@apple.com> |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=53740 |
+ <rdar://problem/8503629> Allow platforms to specify if the placeholder should be visible when text controls are focused |
+ |
+ Tests: |
+ fast/forms/textarea-placeholder-visibility-1.html |
+ fast/forms/textarea-placeholder-visibility-2.html |
+ fast/forms/input-placeholder-visibility-1.html |
+ fast/forms/input-placeholder-visibility-2.html |
+ fast/forms/input-placeholder-visibility-3.html |
+ |
+ * html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible): |
+ Add a check for shouldShowPlaceholderWhenFocused. |
+ * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateValue): |
+ Whenever the value is updated, we should also update placeholder visibility. |
+ * rendering/RenderTheme.h: (WebCore::RenderTheme::shouldShowPlaceholderWhenFocused): |
+ Make the default the same as the existing behavior. |
+ * rendering/RenderThemeMac.h: |
+ * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused): |
+ Show placeholder when appropriate. |
+ |
+2011-02-04 Pavel Podivilov <podivilov@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: evaluate on hover does not work on a breakpoint. |
+ https://bugs.webkit.org/show_bug.cgi?id=53768 |
+ |
+ * inspector/front-end/SourceFrame.js: |
+ (WebInspector.SourceFrame.prototype._mouseHover): |
+ |
+2011-02-04 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r77625 and r77626. |
+ http://trac.webkit.org/changeset/77625 |
+ http://trac.webkit.org/changeset/77626 |
+ https://bugs.webkit.org/show_bug.cgi?id=53765 |
+ |
+ It broke Windows builds (Requested by Ossy_ on #webkit). |
+ |
+ * Android.jscbindings.mk: |
+ * CMakeLists.txt: |
+ * ForwardingHeaders/pcre/pcre.h: Added. |
+ * ForwardingHeaders/yarr/Yarr.h: Removed. |
+ * ForwardingHeaders/yarr/YarrInterpreter.h: Removed. |
+ * ForwardingHeaders/yarr/YarrPattern.h: Removed. |
+ * WebCore.gyp/WebCore.gyp: |
+ * WebCore.pro: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.vcproj/copyForwardingHeaders.cmd: |
+ * platform/text/RegularExpression.cpp: |
+ (WebCore::RegularExpression::Private::regexp): |
+ (WebCore::RegularExpression::Private::compile): |
+ (WebCore::RegularExpression::Private::Private): |
+ (WebCore::RegularExpression::Private::create): |
+ (WebCore::RegularExpression::Private::~Private): |
+ (WebCore::RegularExpression::match): |
+ |
+2011-02-04 Peter Varga <pvarga@webkit.org> |
+ |
+ Rubber-stamped by Csaba Osztrogonác. |
+ |
+ Replace PCRE with Yarr in WebCore |
+ https://bugs.webkit.org/show_bug.cgi?id=53496 |
+ |
+ Speculative windows build fix. |
+ |
+ No new tests needed. |
+ |
+ * platform/text/RegularExpression.cpp: |
+ |
+2011-02-04 Peter Varga <pvarga@webkit.org> |
+ |
+ |
+ Reviewed by Gavin Barraclough. |
+ |
+ Replace PCRE with Yarr in WebCore |
+ https://bugs.webkit.org/show_bug.cgi?id=53496 |
+ |
+ No new tests needed. |
+ |
+ * Android.jscbindings.mk: |
+ * CMakeLists.txt: |
+ * ForwardingHeaders/pcre/pcre.h: Removed. |
+ * ForwardingHeaders/yarr/Yarr.h: Added. |
+ * ForwardingHeaders/yarr/YarrInterpreter.h: Added. |
+ * ForwardingHeaders/yarr/YarrPattern.h: Added. |
+ * WebCore.gyp/WebCore.gyp: |
+ * WebCore.pro: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.vcproj/copyForwardingHeaders.cmd: |
+ * platform/text/RegularExpression.cpp: |
+ (WebCore::RegularExpression::Private::create): |
+ (WebCore::RegularExpression::Private::Private): |
+ (WebCore::RegularExpression::Private::compile): |
+ (WebCore::RegularExpression::match): |
+ |
+2011-02-04 Pavel Feldman <pfeldman@chromium.org> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: Network panel filtering is broken. |
+ https://bugs.webkit.org/show_bug.cgi?id=53764 |
+ |
+ * inspector/front-end/NetworkPanel.js: |
+ (WebInspector.NetworkPanel.prototype._sortItems): |
+ (WebInspector.NetworkPanel.prototype._sortByTimeline): |
+ (WebInspector.NetworkPanel.prototype._filter): |
+ (WebInspector.NetworkPanel.prototype._updateOffscreenRows): |
+ (WebInspector.NetworkDataGridNode.prototype.isFilteredOut): |
+ (WebInspector.NetworkDataGridNode.prototype.get selectable): |
+ (WebInspector.NetworkTotalGridNode.prototype.isFilteredOut): |
+ (WebInspector.NetworkTotalGridNode.prototype.get selectable): |
+ |
+2011-02-04 Andrey Kosyakov <caseq@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: support overriding user agent strings |
+ https://bugs.webkit.org/show_bug.cgi?id=51485 |
+ |
+ Test: http/tests/inspector/extensions-useragent.html |
+ |
+ * inspector/Inspector.idl: |
+ * inspector/InspectorController.cpp: |
+ (WebCore::InspectorController::disconnectFrontend): |
+ (WebCore::InspectorController::setUserAgentOverride): |
+ (WebCore::InspectorController::userAgentOverride): |
+ * inspector/InspectorController.h: |
+ * inspector/front-end/ExtensionAPI.js: |
+ (WebInspector.injectedExtensionAPI.InspectedWindow.prototype.reload): |
+ * inspector/front-end/ExtensionServer.js: |
+ (WebInspector.ExtensionServer.prototype._onReload): |
+ * loader/FrameLoader.cpp: |
+ (WebCore::FrameLoader::userAgent): |
+ (WebCore::FrameLoader::applyUserAgent): |
+ |
+2011-02-04 Pavel Podivilov <podivilov@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: scripts panel displays wrong file name after reload. |
+ https://bugs.webkit.org/show_bug.cgi?id=53761 |
+ |
+ * inspector/front-end/ScriptsPanel.js: |
+ (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished): |
+ |
+2011-02-03 Yury Semikhatsky <yurys@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: remove settings related methods from InspectorClient |
+ https://bugs.webkit.org/show_bug.cgi?id=53686 |
+ |
+ * WebCore.exp.in: |
+ * inspector/CodeGeneratorInspector.pm: |
+ * inspector/InspectorClient.h: |
+ * inspector/InspectorFrontendClientLocal.cpp: |
+ (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal): |
+ (WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight): |
+ (WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight): |
+ * inspector/InspectorFrontendClientLocal.h: ports that provide in-process implementation of the inspector front-end can |
+ provide platform-specific settings accessor. |
+ (WebCore::InspectorFrontendClientLocal::Settings::Settings): |
+ (WebCore::InspectorFrontendClientLocal::Settings::~Settings): |
+ (WebCore::InspectorFrontendClientLocal::Settings::inspectorAttachedHeight): |
+ (WebCore::InspectorFrontendClientLocal::Settings::storeInspectorAttachedHeight): |
+ * loader/EmptyClients.h: |
+ |
+2011-02-03 Anton Muhin <antonm@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ [v8] frame several more JS code invocations into v8::TryCatch |
+ https://bugs.webkit.org/show_bug.cgi?id=53594 |
+ |
+ This patch is preemptive and adjusts v8 bindings code to forthcoming small change |
+ in v8::ThrowException---currently sometimes exceptions thrown by this method |
+ do not reach surrounding v8::TryCatch handler (see |
+ http://code.google.com/p/v8/issues/detail?id=1072 and |
+ http://codereview.chromium.org/6397011/). Therefore the goal of this patch |
+ is to make forthcoming v8 roll as smooth as possible (alas, we'll still need |
+ one rebaseline as of now.) |
+ |
+ * bindings/v8/V8Proxy.cpp: |
+ (WebCore::V8Proxy::runScript): Do not rely on empty handle as a signal of exception, wrap into v8::TryCatch instead |
+ * bindings/v8/V8WindowErrorHandler.cpp: |
+ (WebCore::V8WindowErrorHandler::callListenerFunction): Ditto |
+ |
+2011-02-03 Maciej Stachowiak <mjs@apple.com> |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle |
+ https://bugs.webkit.org/show_bug.cgi?id=52897 |
+ <rdar://problem/8898294> |
+ |
+ * WebCore.exp.in: Add export now needed by WebKit2 |
+ |
+2011-02-03 Victoria Kirst <vrk@google.com> |
+ |
+ Reviewed by James Robinson. |
+ |
+ Replaces float literals with uniform values in shader code |
+ so that buggy drivers unable to parse float values in different |
+ locales will not produce a pink video. |
+ |
+ [chromium] Fix pink video bug with gpu-acceleration enabled |
+ https://bugs.webkit.org/show_bug.cgi?id=53568 |
+ |
+ * platform/graphics/chromium/VideoLayerChromium.cpp: |
+ (WebCore::VideoLayerChromium::SharedValues::SharedValues): |
+ (WebCore::VideoLayerChromium::drawYUV): |
+ * platform/graphics/chromium/VideoLayerChromium.h: |
+ (WebCore::VideoLayerChromium::SharedValues::signAdjLocation): |
+ |
+2011-02-03 James Kozianski <koz@chromium.org> |
+ |
+ Reviewed by Dimitri Glazkov. |
+ |
+ Add navigator.registerProtocolHandler behind a flag. |
+ https://bugs.webkit.org/show_bug.cgi?id=52609 |
+ |
+ This method is described in the HTML5 specification here, |
+ http://dev.w3.org/html5/spec/Overview.html#dom-navigator-registerprotocolhandler |
+ |
+ This change is largely cribbed from B. Green's 29651 patches. It is |
+ behind a flag so as not to break JS feature detection. |
+ |
+ New layout test fast/dom/registerProtocolHandler.html. |
+ |
+ * Configurations/FeatureDefines.xcconfig: |
+ * loader/EmptyClients.h: |
+ (WebCore::EmptyChromeClient::registerProtocolHandler): |
+ * page/Chrome.cpp: |
+ (WebCore::Chrome::registerProtocolHandler): |
+ * page/Chrome.h: |
+ * page/ChromeClient.h: |
+ * page/Navigator.cpp: |
+ (WebCore::verifyCustomHandlerURL): |
+ (WebCore::verifyProtocolHandlerScheme): |
+ (WebCore::Navigator::registerProtocolHandler): |
+ * page/Navigator.h: |
+ * page/Navigator.idl: |
+ |
+2011-02-03 Brian Ryner <bryner@chromium.org> |
+ |
+ Reviewed by Darin Fisher. |
+ |
+ Add a field to the ResourceResponse for tracking the socket address |
+ of the host that the resource was fetched from. Patch was originally |
+ by Paul Marks. |
+ https://bugs.webkit.org/show_bug.cgi?id=53699 |
+ |
+ * platform/network/chromium/ResourceResponse.cpp: |
+ (WebCore::ResourceResponse::doPlatformCopyData): |
+ (WebCore::ResourceResponse::doPlatformAdopt): |
+ * platform/network/chromium/ResourceResponse.h: |
+ (WebCore::ResourceResponse::socketAddress): |
+ (WebCore::ResourceResponse::setSocketAddress): |
+ |
+2011-02-03 Adam Langley <agl@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Plumb mixed script URL to FrameLoaderClient |
+ https://bugs.webkit.org/show_bug.cgi?id=52384 |
+ |
+ Regressions covered by http/tests/security/mixedContent/* |
+ |
+ * loader/EmptyClients.h: |
+ (WebCore::EmptyFrameLoaderClient::didRunInsecureContent): |
+ * loader/FrameLoader.cpp: |
+ (WebCore::FrameLoader::checkIfRunInsecureContent): |
+ * loader/FrameLoaderClient.h: |
+ |
+2011-02-03 Simon Fraser <simon.fraser@apple.com> |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ REGRESSION: Artifacts on box-shadow corners in some cases |
+ https://bugs.webkit.org/show_bug.cgi?id=53731 |
+ |
+ Fix overdrawing artifacts in ShadowBlur's tiling code path, |
+ which show up in shadows using a color with alpha. |
+ |
+ Test: fast/box-shadow/shadow-tiling-artifact.html |
+ |
+ * platform/graphics/ShadowBlur.cpp: |
+ (WebCore::ShadowBlur::drawRectShadowWithTiling): Ensure |
+ that the inner rect that gets filled does not overlap with any |
+ of the eight tiled areas by having the corner and side dimensions |
+ be the same for contiguous areas. |
+ |
+2011-02-03 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Alexey Proskuryakov. |
+ |
+ XSS Auditor is spinning inside decodeURLEscapeSequences() if there are |
+ percent signs in large posted data |
+ https://bugs.webkit.org/show_bug.cgi?id=53405 |
+ |
+ If the input string contains many non-% characters followed by a % |
+ character that is not a valid URL escape sequence, then the old |
+ algorithm would only advance the initial search by one character |
+ (instead of jumping to just after the % character). That would cause |
+ the algorithm to take N^2 time (in the number of characters before the |
+ first % character). This patch just advances the search past the first |
+ % character so we can start looking for next % character sooner. |
+ |
+ * platform/KURL.cpp: |
+ (WebCore::decodeURLEscapeSequences): |
+ |
+2011-02-03 Pavel Podivilov <podivilov@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: click on a breakpoint highlights wrong line in source frame. |
+ https://bugs.webkit.org/show_bug.cgi?id=53692 |
+ |
+ * inspector/front-end/BreakpointsSidebarPane.js: |
+ (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setupBreakpointElement): |
+ |
+2011-02-03 Anton Muhin <antonm@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ [v8] Bail out if to string conversion returned empty handle |
+ https://bugs.webkit.org/show_bug.cgi?id=53687 |
+ |
+ This a temporary measure: actually one probably should never get empty handle |
+ if there was no exception. The root cause is under investigation. |
+ The bailout though allows Chromium not to crash---attempt to convert an empty |
+ v8 hande into WebCore string crashes with invalid memory access. |
+ |
+ See http://code.google.com/p/chromium/issues/detail?id=71544 |
+ |
+ There is no known reduction expressible as a layout test so far. The crash found with automated testing tools. |
+ |
+ * bindings/v8/V8Binding.cpp: |
+ (WebCore::v8NonStringValueToWebCoreString): Bail out on empty handle |
+ * bindings/v8/V8Binding.h: |
+ (WebCore::V8ParameterBase::prepareBase): Ditto |
+ |
+2011-02-03 Adam Barth <abarth@webkit.org> |
+ |
+ Attempt to fix Chromium build. |
+ |
+ * html/parser/XSSFilter.cpp: |
+ |
+2011-02-03 Dirk Pranke <dpranke@chromium.org> |
+ |
+ Unreviewed, rolling out r77562. |
+ http://trac.webkit.org/changeset/77562 |
+ https://bugs.webkit.org/show_bug.cgi?id=53630 |
+ |
+ broke chromium mac build |
+ |
+ * WebCore.gyp/WebCore.gyp: |
+ * WebCore.gyp/mac/check_objc_rename.sh: Removed. |
+ |
+2011-02-03 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Daniel Bates. |
+ |
+ XSS Auditor severely affects loading performance after submitting a large form |
+ https://bugs.webkit.org/show_bug.cgi?id=49845 |
+ |
+ Switch over from the XSSAuditor to the XSSFilter, improving performance |
+ on this example. |
+ |
+ * html/parser/XSSFilter.cpp: |
+ (WebCore::XSSFilter::filterToken): |
+ * page/XSSAuditor.cpp: |
+ (WebCore::XSSAuditor::isEnabled): |
+ |
+2011-02-03 Dirk Pranke <dpranke@chromium.org> |
+ |
+ Unreviewed, rolling out r77567. |
+ http://trac.webkit.org/changeset/77567 |
+ https://bugs.webkit.org/show_bug.cgi?id=53468 |
+ |
+ broke chromium linux svg, canvas tests, possibly win also? |
+ |
+ * platform/graphics/skia/ImageBufferSkia.cpp: |
+ (WebCore::getImageData): |
+ (WebCore::ImageBuffer::getUnmultipliedImageData): |
+ (WebCore::ImageBuffer::getPremultipliedImageData): |
+ (WebCore::putImageData): |
+ (WebCore::ImageBuffer::putUnmultipliedImageData): |
+ (WebCore::ImageBuffer::putPremultipliedImageData): |
+ |
+2011-02-02 MORITA Hajime <morrita@google.com> |
+ |
+ Reviewed by Dimitri Glazkov. |
+ |
+ Refactoring: <progress> should not use ShadowElement |
+ https://bugs.webkit.org/show_bug.cgi?id=53583 |
+ |
+ - Introduced RenderIndicatorPart and RenderProgressBarValuePart |
+ to be responsible for bar-part layout, |
+ which adopted layout logic from ShadowBlockElement. |
+ - ProgressBarValueElement is no longer a subclass of ShadowBlockElement. |
+ - Remove dependency from RenderProgress to HTMLProgressElement and |
+ ShadowBlockElement. |
+ - The shadow tree is no longer removed on detach(). It becomes persistent. |
+ This is now possible because the ShadowBlockElement dependency is gone. |
+ - ::-webkit-appearance for -webkit-progress-bar-value is no longer referred. |
+ That didn't make sense. |
+ |
+ * html/HTMLProgressElement.cpp: |
+ (WebCore::HTMLProgressElement::createShadowSubtreeIfNeeded): |
+ * html/HTMLProgressElement.h: |
+ * html/shadow/ProgressBarValueElement.h: Added. |
+ (WebCore::ProgressBarValueElement::ProgressBarValueElement): |
+ (WebCore::ProgressBarValueElement::shadowPseudoId): |
+ (WebCore::ProgressBarValueElement::createRenderer): |
+ (WebCore::ProgressBarValueElement::create): |
+ * rendering/RenderIndicator.cpp: |
+ (WebCore::RenderIndicatorPart::RenderIndicatorPart): |
+ (WebCore::RenderIndicatorPart::~RenderIndicatorPart): |
+ (WebCore::RenderIndicatorPart::layout): |
+ (WebCore::RenderIndicatorPart::styleDidChange): |
+ * rendering/RenderIndicator.h: Added RenderIndicatorPart class |
+ (WebCore::RenderIndicatorPart::originalVisibility): |
+ (WebCore::RenderIndicatorPart::requiresForcedStyleRecalcPropagation): |
+ (WebCore::RenderIndicatorPart::canHaveChildren): |
+ * rendering/RenderProgress.cpp: |
+ (WebCore::RenderProgressBarValuePart::preferredFrameRect): |
+ (WebCore::RenderProgressBarValuePart::shouldBeHidden): |
+ (WebCore::RenderProgress::updateFromElement): |
+ (WebCore::RenderProgress::layoutParts): |
+ (WebCore::RenderProgress::shouldHaveParts): |
+ * rendering/RenderProgress.h: |
+ (WebCore::RenderProgressBarValuePart::RenderProgressBarValuePart): |
+ |
+2011-02-03 Jia Pu <jpu@apple.com> |
+ |
+ Reversion should not be marked as misspelled. |
+ https://bugs.webkit.org/show_bug.cgi?id=53255 |
+ |
+ This patch includes fix for reported bug, and also some housekeeping changes. |
+ |
+ To implement desired behavior, we need: |
+ 1. Add a new marker type, SpellCheckingExemption, since now we distingusish between text |
+ that shouldn't be spellchecked and text shouldn't be autocorrected. |
+ 2. Make sure that there is no pending correction panel when we enter markAllMisspellingsAndBadGrammarInRanges(). |
+ Otherwise the spell checking code in that function may interfere with autocorrection. This |
+ is achieved by explicitly applying pending correction when user types space, line break or |
+ paragraph break. |
+ |
+ Housekeeping code changes include: |
+ 1. Change manual-tests that were broken by relocated WebCore directory. |
+ 2. Use TextIterator in various DocumentMarkerController functions instead of using |
+ Node::traverseNextNode() directly. |
+ 3. Allow passing multiple marker types into DocumentMarkerController::removeMarkers() and |
+ DocumentMarkerController::hasMarkers() to improve clarity and efficiency. |
+ 4. Fixes of minor bugs that were exposed previously. |
+ |
+ * WebCore.exp.in: Change signature of DocumentMarkerController::removeMarkers(). |
+ |
+ * dom/DocumentMarker.h: Added new marker type SpellCheckingExemption. |
+ |
+ * dom/DocumentMarkerController.cpp: |
+ (WebCore::DocumentMarkerController::removeMarkers): Use TextIterator to scan the range to be |
+ consistent with addMarker() function. Allow passing in multiple marker types in one call. |
+ Added a boolean argument to specify the behavior when removing markers that partially |
+ overlap the specified range. |
+ (WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair): Allow passing in |
+ multiple marker types in one call. |
+ (WebCore::DocumentMarkerController::hasMarkers): Use TextIterator to scan the range to be |
+ consistent with addMarker() function. Allow passing in multiple marker types in one call. |
+ |
+ * dom/DocumentMarkerController.h: Allow passing in multiple marker types to removeMarkers() |
+ and hasMarkers(). Added a boolean argument to removeMarkers() to specify the behavior when |
+ removing markers that partially overlap the specified range. |
+ |
+ * editing/Editor.cpp: |
+ (WebCore::markerTypesForAutocorrection): Add SpellCheckingExemption marker when apply correction. |
+ (WebCore::markerTypesForReplacement): Ditto. |
+ (WebCore::Editor::respondToChangedSelection): Reordered call to dismissCorrectionPanel() and |
+ setSelection() to make sure there is no pending correction when entering |
+ markAllMisspellingsAndBadGrammarInRanges(). |
+ (WebCore::Editor::appliedEditing): Only remove CorrectionIndicator markers when the command |
+ is a top level command to improve efficiency. |
+ (WebCore::Editor::insertTextWithoutSendingTextEvent): Added code to applying pending correction. |
+ (WebCore::Editor::insertLineBreak): Ditto. |
+ (WebCore::Editor::insertParagraphSeparator): Ditto. |
+ (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Don't mark mispelling if the |
+ text carries SpellCheckingExemption marker. |
+ (WebCore::Editor::correctionPanelTimerFired): Reset correction panel if the returned suggestion |
+ from spellchecker is an empty string. |
+ (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited): |
+ Use new DocumentMarkerController::removeMarkers() to replace custom implemenation to improve |
+ efficiency and readability. |
+ (WebCore::Editor::applyCorrectionPanelInfo): Remove the code that set caret position after |
+ applying correction, since it's unnecessary. Also, store pre-correction string together with |
+ the marker for reversion panel to use. |
+ (WebCore::Editor::applyAutocorrectionBeforeTypingIfAppropriate): Apply pending correction. |
+ (WebCore::Editor::changeSelectionAfterCommand): Moved marker removal code to Editor::appliedEditing() |
+ where we have access to EditCommand object. |
+ |
+ * editing/Editor.h: Added new function applyAutocorrectionAfterTypingIfAppropriate(). |
+ |
+ * manual-tests/autocorrection/autocorrection-cancelled-by-ESC.html: Change manual-tests that |
+ were broken by relocated WebCore directory. |
+ |
+ * manual-tests/autocorrection/autocorrection-cancelled-by-typing-1.html: Ditto. |
+ |
+ * manual-tests/autocorrection/autocorrection-contraction.html: Ditto. |
+ |
+ * manual-tests/autocorrection/continue-typing-to-dismiss-reversion.html: Ditto. |
+ |
+ * manual-tests/autocorrection/delete-to-dismiss-reversion.html: Ditto. |
+ |
+ * manual-tests/autocorrection/delete-to-end-of-word-to-show-reversion.html: Ditto. |
+ |
+ * manual-tests/autocorrection/dismiss-multiple-guesses.html: Ditto. |
+ |
+ * manual-tests/autocorrection/move-to-end-of-word-to-show-reversion.html: Ditto. |
+ |
+ * manual-tests/autocorrection/select-from-multiple-guesses.html: Ditto. |
+ |
+ * manual-tests/autocorrection/spell-checking-after-reversion.html: Added. |
+ |
+ * manual-tests/autocorrection/type-whitespace-to-dismiss-reversion.html: Change manual-tests that |
+ were broken by relocated WebCore directory. |
+ |
+ * rendering/InlineTextBox.cpp: |
+ (WebCore::InlineTextBox::paintDocumentMarkers): Code clean-up to be more concise. |
+ |
+2011-02-03 Abhishek Arya <inferno@chromium.org> |
+ |
+ Unreviewed, qt build fix. |
+ |
+ * rendering/RenderBlock.cpp: |
+ (WebCore::RenderBlock::removeFloatingObject): |
+ |
+2011-02-03 Brian Salomon <bsalomon@google.com> |
+ |
+ Reviewed by James Robinson. |
+ |
+ Handle non-raster backed images in getUnmultipliedImageData() |
+ https://bugs.webkit.org/show_bug.cgi?id=53468 |
+ |
+ No new tests. Existing canvas tests sufficient |
+ LayoutTests/canvas/philip/... |
+ |
+ * platform/graphics/skia/ImageBufferSkia.cpp: |
+ (WebCore::getImageData): |
+ (WebCore::ImageBuffer::getUnmultipliedImageData): |
+ (WebCore::ImageBuffer::getPremultipliedImageData): |
+ (WebCore::putImageData): |
+ (WebCore::ImageBuffer::putUnmultipliedImageData): |
+ (WebCore::ImageBuffer::putPremultipliedImageData): |
+ |
+2011-02-03 Abhishek Arya <inferno@chromium.org> |
+ |
+ Reviewed by James Robinson. |
+ |
+ Enforce more limits on root inline boxes height calculations. |
+ https://bugs.webkit.org/show_bug.cgi?id=53729 |
+ |
+ Test: fast/overflow/overflow-height-float-not-removed-crash.html |
+ |
+ * rendering/RenderBlock.cpp: |
+ (WebCore::RenderBlock::removeFloatingObject): prevent logicalBottom to |
+ become negative when logicalTop is INT_MAX. |
+ (WebCore::RenderBlock::markLinesDirtyInBlockRange): when logicalBottom |
+ is INT_MAX, we should dirty everything. So, we bail out to make |
+ afterLowest equal to the lastRootBox() or lowestDirstLine. |
+ |
+2011-02-03 David Levin <levin@chromium.org> |
+ |
+ Reviewed by Adam Barth and Oliver Hunt. |
+ |
+ Worker.importScript() should clean errors for cross origin imports. |
+ https://bugs.webkit.org/show_bug.cgi?id=52871 |
+ |
+ Test: http/tests/workers/worker-importScriptsOnError.html |
+ |
+ * bindings/js/WorkerScriptController.cpp: |
+ (WebCore::WorkerScriptController::evaluate): Use sanitizeScriptError |
+ to determine when to create a clean exception. |
+ * bindings/v8/WorkerContextExecutionProxy.cpp: |
+ (WebCore::WorkerContextExecutionProxy::evaluate): Ditto. |
+ * dom/ScriptExecutionContext.cpp: |
+ (WebCore::ScriptExecutionContext::sanitizeScriptError): Figure out |
+ if the error needs to be cleaned up. |
+ (WebCore::ScriptExecutionContext::dispatchErrorEvent): Extracted |
+ sanitizeScriptError for use by other places. |
+ * dom/ScriptExecutionContext.h: |
+ * workers/WorkerContext.cpp: |
+ (WebCore::WorkerContext::importScripts): Use the reponse url when |
+ telling the evaluate where the script came fro. |
+ * workers/WorkerScriptLoader.cpp: |
+ (WebCore::WorkerScriptLoader::responseURL): Expose the url that |
+ the script was loaded from (which may be different from url() due |
+ to redirects). |
+ (WebCore::WorkerScriptLoader::didReceiveResponse): Capture the reponse url. |
+ * workers/WorkerScriptLoader.h: |
+ |
+2011-02-03 Mark Mentovai <mark@chromium.org> |
+ |
+ Reviewed by Dimitri Glazkov. |
+ |
+ Chromium GYP build fix. |
+ |
+ When various settings were moved to webcore_prerequisites in r66364, |
+ things that should have been direct_dependent_settings were not marked |
+ as such. GYP 'defines', for example, make no sense on a 'none'-type |
+ target such as webcore_prerequisites. It appears that it was intended |
+ for these settings to be pushed to direct dependents, which would make |
+ direct_dependent_settings correct. |
+ |
+ Losing the ChromiumWebCoreObjC defines on the Mac, for example, caused |
+ http://crbug.com/71537, which at best causes Mac console log spew, and |
+ at worst may result in Chromium's copy of WebCore using system |
+ definitions of certain Objective-C classes at runtime, or vice-versa. |
+ |
+ The build now includes a postbuild step to prevent |
+ http://crbug.com/71537 from regressing again. The build will fail upon |
+ regression. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=53630 |
+ |
+ * WebCore.gyp/WebCore.gyp: Move things in webcore_prerequisites into |
+ direct_dependent_settings as needed, add the check_objc_rename |
+ postbuild step. |
+ * WebCore.gyp/mac/check_objc_rename.sh: Added. |
+ |
+2011-02-03 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Make XSSFilter go fast by adding a SuffixTree |
+ https://bugs.webkit.org/show_bug.cgi?id=53665 |
+ |
+ The SuffixTree lets us quickly reject snippets if the POST data is |
+ large (because we can avoid a linear scan over the POST data). |
+ |
+ * html/parser/XSSFilter.cpp: |
+ (WebCore::XSSFilter::init): |
+ (WebCore::XSSFilter::isContainedInRequest): |
+ * html/parser/XSSFilter.h: |
+ |
+2011-02-03 Mihai Parparita <mihaip@chromium.org> |
+ |
+ Reviewed by Alexey Proskuryakov. |
+ |
+ REGRESSION (r77355): Page cache layout tests crash |
+ https://bugs.webkit.org/show_bug.cgi?id=53648 |
+ |
+ Test: fast/events/pagehide-timeout.html |
+ |
+ Suspend active DOM objects after all pagehide event handlers have run, |
+ otherwise it's possible for them to create more objects that weren't |
+ getting suspended. |
+ |
+ * history/CachedFrame.cpp: |
+ (WebCore::CachedFrame::CachedFrame): |
+ |
+2011-02-03 Jeremy Orlow <jorlow@chromium.org> |
+ |
+ Reviewed by Nate Chapin. |
+ |
+ SerializedScriptValue should not require v8 to create undefined and null values |
+ https://bugs.webkit.org/show_bug.cgi?id=53730 |
+ |
+ Instead of creating a v8 type and passing that into the constructor, just use |
+ the writer class directly. While I was at it, I cleaned up the code a bit too |
+ by getting rid of the WireData/StringValue enum as I found that personally |
+ confusing. |
+ |
+ This is necessary because these methods are called by IndexedDB in the browser |
+ process where v8 is not spun up. |
+ |
+ No functionality changed and not possible to test. |
+ |
+ * bindings/v8/SerializedScriptValue.cpp: |
+ (WebCore::SerializedScriptValue::createFromWire): |
+ (WebCore::SerializedScriptValue::create): |
+ (WebCore::SerializedScriptValue::nullValue): |
+ (WebCore::SerializedScriptValue::undefinedValue): |
+ (WebCore::SerializedScriptValue::release): |
+ (WebCore::SerializedScriptValue::SerializedScriptValue): |
+ * bindings/v8/SerializedScriptValue.h: |
+ |
+2011-02-03 Beth Dakin <bdakin@apple.com> |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ Fix for <rdar://problem/8944544> Ability to animate track |
+ for WKPainter scrollers |
+ |
+ Two new WebKitSystemInterface functions. |
+ * WebCore.exp.in: |
+ * platform/mac/WebCoreSystemInterface.h: |
+ * platform/mac/WebCoreSystemInterface.mm: |
+ |
+ Use Scrollbar::convertFromContainingView() to return the right point. |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]): |
+ |
+ ScrollKnobAnimation is now ScrollbarPartAnimation. It can |
+ now be used to animate the knob or the track. |
+ (-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]): |
+ (-[ScrollbarPartAnimation setCurrentProgress:]): |
+ (-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]): |
+ (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]): |
+ (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]): |
+ |
+ Scrollbars need invalodating after the overlay state changes. |
+ (-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]): |
+ |
+2011-02-03 Sam Weinig <sam@webkit.org> |
+ |
+ Reviewed by Beth Dakin. |
+ |
+ Scroll thumb jumps to top when resizing horizontally. |
+ |
+ * platform/ScrollView.cpp: |
+ (WebCore::ScrollView::updateScrollbars): Add call to update |
+ the scrollbar's offset in the case where we may have created |
+ a new scrollbar but have not changed the current position. |
+ |
+2011-02-03 Justin Schuh <jschuh@chromium.org> |
+ |
+ Reviewed by Dirk Schulze. |
+ |
+ startAnimations should use a local, RefCounted Vector. |
+ https://bugs.webkit.org/show_bug.cgi?id=53458 |
+ |
+ Test: svg/custom/use-animation-in-fill.html |
+ |
+ * svg/SVGDocumentExtensions.cpp: |
+ (WebCore::SVGDocumentExtensions::startAnimations): |
+ |
+2011-02-03 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Daniel Bates. |
+ |
+ XSSFilter shouldn't bother to analyze pages without "injection" |
+ characters in the request |
+ https://bugs.webkit.org/show_bug.cgi?id=53664 |
+ |
+ If the request lacks these "injection" characters, then it's unlikely |
+ that there's a reflective XSS attack happening. This hueristic lets us |
+ avoid analyzing the vast majority of responses for XSS. Of course, the |
+ hueristic isn't perfect. Because of this huerstic, we miss out on |
+ injections into unquoted attributes. However, it's a trade-off that's |
+ worked well in the XSSAuditor. |
+ |
+ * html/parser/XSSFilter.cpp: |
+ (WebCore::HTMLNames::isRequiredForInjection): |
+ (WebCore::XSSFilter::XSSFilter): |
+ (WebCore::XSSFilter::init): |
+ (WebCore::XSSFilter::filterToken): |
+ (WebCore::XSSFilter::isContainedInRequest): |
+ * html/parser/XSSFilter.h: |
+ |
+2011-02-03 Vangelis Kokkevis <vangelis@chromium.org> |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ [chromium] Fixing a compositor crash occurring on layers |
+ without an associated RenderSurface. |
+ https://bugs.webkit.org/show_bug.cgi?id=53679 |
+ Regression was introduced by in r77425 |
+ |
+ Test: http://webkit.org/blog/386/3d-transforms/ doesn't crash |
+ anymore. |
+ |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ (WebCore::LayerRendererChromium::drawLayer): |
+ |
+2011-02-03 Dan Bernstein <mitz@apple.com> |
+ |
+ Reviewed by Anders Carlsson. |
+ |
+ <rdar://problem/8948788> Text emphasis marks have wrong orientation for vertical text |
+ https://bugs.webkit.org/show_bug.cgi?id=53709 |
+ |
+ Covered by rendering of fast/text/emphasis-vertical.html |
+ |
+ * platform/graphics/mac/SimpleFontDataMac.mm: |
+ (WebCore::SimpleFontData::scaledFontData): Give the scaled font the same orientation this font |
+ has. |
+ |
+2011-02-02 Levi Weintraub <leviw@chromium.org> |
+ |
+ Reviewed by Ryosuke Niwa. |
+ |
+ Moving cursor down in table cycles at the end of a row |
+ https://bugs.webkit.org/show_bug.cgi?id=50012 |
+ |
+ Avoids a caret cycling issue with certain content (e.g. tables) found at the very |
+ end of a document due to a bug in nextLeafWithSameEditability. |
+ |
+ Test: editing/selection/move-by-line-cycles-in-table.html |
+ |
+ * editing/visible_units.cpp: |
+ (WebCore::nextLeafWithSameEditability): Properly avoid descending back into the |
+ original leaf node. |
+ |
+2011-02-03 Pavel Podivilov <podivilov@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: remove dead code related to changes panel. |
+ https://bugs.webkit.org/show_bug.cgi?id=53688 |
+ |
+ * WebCore.gypi: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * inspector/front-end/ChangesView.js: Removed. |
+ * inspector/front-end/WebKit.qrc: |
+ * inspector/front-end/inspector.css: |
+ (#error-warning-count): |
+ (#error-warning-count:hover): |
+ (#error-count + #warning-count): |
+ * inspector/front-end/inspector.html: |
+ * inspector/front-end/inspector.js: |
+ |
+2011-02-02 Sam Weinig <sam@webkit.org> |
+ |
+ Reviewed by Anders Carlsson. |
+ |
+ Add notification of the end of a rubber band. |
+ <rdar://problem/8940648> |
+ |
+ * WebCore.exp.in: |
+ Add additional exprots. |
+ |
+ * page/ChromeClient.h: |
+ (WebCore::ChromeClient::didCompleteRubberBandForMainFrame): |
+ * page/FrameView.cpp: |
+ (WebCore::FrameView::didCompleteRubberBand): |
+ * page/FrameView.h: |
+ * platform/ScrollView.cpp: |
+ (WebCore::ScrollView::didCompleteRubberBand): |
+ * platform/ScrollView.h: |
+ Add hook. |
+ |
+ * platform/ScrollableArea.h: |
+ (WebCore::ScrollableArea::inLiveResize): |
+ (WebCore::ScrollableArea::maximumScrollPosition): |
+ (WebCore::ScrollableArea::visibleWidth): |
+ (WebCore::ScrollableArea::overhangAmount): |
+ (WebCore::ScrollableArea::didCompleteRubberBand): |
+ Reorganize and de-virtualize live resize notifications. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (WebCore::ScrollAnimatorMac::snapRubberBandTimerFired): |
+ Call the new hook when the rubberband ends. |
+ |
+2011-02-02 Evan Martin <evan@chromium.org> |
+ |
+ Reviewed by Tony Chang. |
+ |
+ [chromium] complex joining characters positioned in wrong place |
+ https://bugs.webkit.org/show_bug.cgi?id=53637 |
+ |
+ Provide the correct font metrics to Harfbuzz related to the font design space. |
+ There are used in some fonts for GPOS positioning. |
+ |
+ Test: platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html |
+ |
+ * platform/graphics/chromium/ComplexTextControllerLinux.cpp: |
+ (WebCore::ComplexTextController::setupFontForScriptRun): |
+ (WebCore::ComplexTextController::allocHarfbuzzFont): |
+ * platform/graphics/chromium/FontPlatformDataLinux.cpp: |
+ (WebCore::FontPlatformData::FontPlatformData): |
+ (WebCore::FontPlatformData::emSizeInFontUnits): |
+ (WebCore::FontPlatformData::operator=): |
+ * platform/graphics/chromium/FontPlatformDataLinux.h: |
+ (WebCore::FontPlatformData::FontPlatformData): |
+ |
+2011-02-02 Dimitri Glazkov <dglazkov@chromium.org> |
+ |
+ Reviewed by Kent Tamura. |
+ |
+ REGRESSION(r76147): Slider thumb position is not updated when value attribute is changed. |
+ https://bugs.webkit.org/show_bug.cgi?id=53634 |
+ |
+ Test: fast/dom/HTMLInputElement/input-slider-update.html |
+ |
+ * html/HTMLInputElement.cpp: |
+ (WebCore::HTMLInputElement::setValue): Added a call to InputType::valueChanged. |
+ * html/InputType.cpp: |
+ (WebCore::InputType::valueChanged): Added empty implementation. |
+ * html/InputType.h: Added def. |
+ * html/RangeInputType.cpp: |
+ (WebCore::RangeInputType::valueChanged): Added implementation that dirties layout |
+ bit on the thumb. |
+ * html/RangeInputType.h: Added def. |
+ |
+2011-02-02 Pavel Podivilov <podivilov@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: do not share source frames between resources panel and scripts panel. |
+ https://bugs.webkit.org/show_bug.cgi?id=53584 |
+ |
+ Currently, we show error messages only for resources. This change will allow showing error |
+ messages in source frame even when resource is not available (eval scripts, inlined scripts). |
+ |
+ * inspector/front-end/ConsoleView.js: |
+ (WebInspector.ConsoleView.prototype.addMessage): |
+ (WebInspector.ConsoleView.prototype.clearMessages): |
+ * inspector/front-end/ResourceView.js: |
+ (WebInspector.ResourceView.recreateResourceView): |
+ * inspector/front-end/ResourcesPanel.js: |
+ (WebInspector.FrameResourceTreeElement.prototype._setBubbleText): |
+ * inspector/front-end/ScriptsPanel.js: |
+ (WebInspector.ScriptsPanel.prototype._scriptSourceChanged): |
+ (WebInspector.ScriptsPanel.prototype.addConsoleMessage): |
+ (WebInspector.ScriptsPanel.prototype.clearConsoleMessages): |
+ (WebInspector.ScriptsPanel.prototype.reset): |
+ (WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource): |
+ (WebInspector.ScriptsPanel.prototype._sourceFrameForResource): |
+ (WebInspector.ScriptsPanel.prototype._sourceFrameForScript): |
+ |
+2011-02-03 Simon Fraser <simon.fraser@apple.com> |
+ |
+ Fix 32-bit builds. |
+ |
+ * platform/graphics/ShadowBlur.cpp: |
+ (WebCore::ShadowBlur::blurLayerImage): |
+ |
+2011-02-03 Mikhail Naganov <mnaganov@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: Add reporting of JS heap size limit to 'console.memory'. |
+ https://bugs.webkit.org/show_bug.cgi?id=53592 |
+ |
+ In JSC there is no limit, thus 'undefined' value is returned. |
+ For V8, the limit reported by the VM is returned. |
+ |
+ * Android.jscbindings.mk: |
+ * CMakeLists.txt: |
+ * GNUmakefile.am: |
+ * WebCore.gypi: |
+ * WebCore.pro: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * bindings/js/JSBindingsAllInOne.cpp: |
+ * bindings/js/JSMemoryInfoCustom.cpp: Added. |
+ * bindings/js/ScriptGCEvent.cpp: |
+ (WebCore::ScriptGCEvent::getHeapSize): |
+ * bindings/js/ScriptGCEvent.h: |
+ * bindings/v8/ScriptGCEvent.cpp: |
+ (WebCore::ScriptGCEvent::getHeapSize): |
+ * bindings/v8/ScriptGCEvent.h: |
+ * inspector/InspectorTimelineAgent.cpp: |
+ (WebCore::InspectorTimelineAgent::setHeapSizeStatistic): |
+ * page/MemoryInfo.cpp: |
+ (WebCore::MemoryInfo::MemoryInfo): |
+ * page/MemoryInfo.h: |
+ (WebCore::MemoryInfo::jsHeapSizeLimit): |
+ * page/MemoryInfo.idl: |
+ |
+2011-01-27 Philippe Normand <pnormand@igalia.com> |
+ |
+ Reviewed by Martin Robinson. |
+ |
+ [GTK] LayoutTests/media/audio-mpeg4-supported.html fails |
+ https://bugs.webkit.org/show_bug.cgi?id=53125 |
+ |
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: |
+ (WebCore::mimeTypeCache): Add audio/x-m4a mimetype in the cache. |
+ |
+2011-02-03 Simon Fraser <simon.fraser@apple.com> |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ ShadowBlur radius for CSS shadows is slightly too big |
+ https://bugs.webkit.org/show_bug.cgi?id=53660 |
+ |
+ If we follow SVG gaussian blur for CSS shadows, we can end up rendering |
+ shadows that extend further than the CSS "blur radius", which results |
+ in the shadows being truncated. |
+ |
+ Fix with a small fudge factor to reduce the kernel diameter slightly |
+ for CSS shadows. |
+ |
+ Also more closely follow the algorithm described in the SVG spec |
+ for computing the kernel size for different diameters, and clean up |
+ some variable naming relating to the shadow bounds. |
+ |
+ * platform/graphics/ShadowBlur.cpp: |
+ (WebCore::ShadowBlur::blurLayerImage): |
+ (WebCore::ShadowBlur::drawRectShadowWithTiling): |
+ |
+2011-02-01 Pavel Podivilov <podivilov@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: introduce new api for managing JavaScript breakpoints. |
+ https://bugs.webkit.org/show_bug.cgi?id=53235 |
+ |
+ Single protocol breakpoint (e.g. set by url) is mapped on zero or more VM breakpoints (set by sourceID). |
+ removeJavaScriptBreakpoint(breakpointId) removes breakpoint and all linked VM breakpoints. |
+ Since UI uses VM breakpoint location rather then protocol breakpoint location, all resolved breakpoints locations are passed to frontend. |
+ |
+ SourceFrame is now aware of whether breakpoint is resolved or not and may display it accordingly. |
+ JavaScriptBreakpointsSidebarPane filters out breakpoints set on nonexistent scripts to avoid UI cluttering. |
+ |
+ * bindings/js/ScriptDebugServer.cpp: |
+ (WebCore::ScriptDebugServer::setBreakpoint): |
+ (WebCore::ScriptDebugServer::removeBreakpoint): |
+ * bindings/js/ScriptDebugServer.h: |
+ * bindings/v8/DebuggerScript.js: |
+ (): |
+ * bindings/v8/ScriptDebugServer.cpp: |
+ (WebCore::ScriptDebugServer::setBreakpoint): |
+ * bindings/v8/ScriptDebugServer.h: |
+ * inspector/Inspector.idl: |
+ * inspector/InspectorAgent.cpp: clear breakpoints from inspector state when new frontend is created |
+ (WebCore::InspectorAgent::restoreInspectorStateFromCookie): |
+ (WebCore::InspectorAgent::populateScriptObjects): |
+ (WebCore::InspectorAgent::restoreDebugger): |
+ (WebCore::InspectorAgent::showAndEnableDebugger): |
+ (WebCore::InspectorAgent::enableDebugger): |
+ * inspector/InspectorAgent.h: |
+ * inspector/InspectorDebuggerAgent.cpp: manage relations between protocol breakpoints and VM breakpoints |
+ (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): |
+ (WebCore::InspectorDebuggerAgent::inspectedURLChanged): |
+ (WebCore::InspectorDebuggerAgent::setJavaScriptBreakpoint): |
+ (WebCore::InspectorDebuggerAgent::setJavaScriptBreakpointBySourceId): |
+ (WebCore::InspectorDebuggerAgent::removeJavaScriptBreakpoint): |
+ (WebCore::InspectorDebuggerAgent::continueToLocation): |
+ (WebCore::InspectorDebuggerAgent::resolveBreakpoint): |
+ (WebCore::InspectorDebuggerAgent::getScriptSource): |
+ (WebCore::InspectorDebuggerAgent::didParseSource): |
+ (WebCore::InspectorDebuggerAgent::didPause): |
+ * inspector/InspectorDebuggerAgent.h: |
+ (WebCore::InspectorDebuggerAgent::Script::Script): |
+ * inspector/InspectorValues.cpp: |
+ (WebCore::InspectorValue::asNumber): |
+ (WebCore::InspectorBasicValue::asNumber): |
+ (WebCore::InspectorObject::remove): |
+ * inspector/InspectorValues.h: |
+ (WebCore::InspectorObject::getNumber): |
+ (WebCore::InspectorObject::find): |
+ * inspector/ScriptBreakpoint.h: |
+ (WebCore::ScriptBreakpoint::ScriptBreakpoint): |
+ * inspector/front-end/Breakpoint.js: |
+ (WebInspector.Breakpoint): |
+ (WebInspector.Breakpoint.prototype.addLocation): |
+ * inspector/front-end/BreakpointManager.js: remove all stuff related to JavaScript breakpoints from here |
+ (WebInspector.BreakpointManager): |
+ (WebInspector.BreakpointManager.prototype._projectChanged): |
+ (WebInspector.BreakpointManager.prototype._saveBreakpoints): |
+ (WebInspector.BreakpointManager.prototype._validateBreakpoints): |
+ * inspector/front-end/BreakpointsSidebarPane.js: |
+ (WebInspector.JavaScriptBreakpointsSidebarPane): filter breakpoints set on nonexistent scripts to avoid ui cluttering |
+ * inspector/front-end/DebuggerModel.js: |
+ (WebInspector.DebuggerModel): pull all JavaScript from localStorage and push them to fronted when debugger is enabled, save resolved breakpoints data |
+ * inspector/front-end/Script.js: |
+ (WebInspector.Script.prototype.sourceLine): |
+ * inspector/front-end/ScriptsPanel.js: |
+ (WebInspector.ScriptsPanel.prototype._toggleDebugging): |
+ * inspector/front-end/Settings.js: |
+ (WebInspector.Settings): |
+ * inspector/front-end/SourceFrame.js: handle resolved and unresolved breakpoints differently |
+ * inspector/front-end/inspector.js: |
+ |
+2011-02-03 Nikolas Zimmermann <nzimmermann@rim.com> |
+ |
+ Reviewed by Dirk Schulze. |
+ |
+ small text which is scaled to be large renders pixelated |
+ https://bugs.webkit.org/show_bug.cgi?id=12448 |
+ |
+ SVG <text> with font-size smaller or equal to 1 does not paint correctly |
+ https://bugs.webkit.org/show_bug.cgi?id=14242 |
+ |
+ misplaced text in SVG |
+ https://bugs.webkit.org/show_bug.cgi?id=17053 |
+ |
+ Don't render very small (but zoomed) text inside SVG |
+ https://bugs.webkit.org/show_bug.cgi?id=19393 |
+ |
+ Tiny fonts scaled up end up too large in Safari |
+ https://bugs.webkit.org/show_bug.cgi?id=20192 |
+ |
+ Stretched SVG Text has awful glyph spacing |
+ https://bugs.webkit.org/show_bug.cgi?id=21774 |
+ |
+ REGRESSION (r72141?): svg/batik/text/smallFonts.svg failing on Leopard |
+ https://bugs.webkit.org/show_bug.cgi?id=49846 |
+ |
+ [Gtk] Text height in zoomed SVG is 1px too high |
+ https://bugs.webkit.org/show_bug.cgi?id=50313 |
+ |
+ SVG text smaller than 0.5px not displayed properly |
+ https://bugs.webkit.org/show_bug.cgi?id=50528 |
+ |
+ When rendering text, we're selecting a font with a size, as specified in the markup. |
+ This can lead to problems, if the context, where the text is rendered upon, is scaled. If a parent |
+ element of the <text> defines a transform=".." or the outermost <svg> containing a viewBox the |
+ problem becomes apparent. |
+ |
+ Consider following two snippets, which should render exactly the same: |
+ <svg viewBox="0 0 100 100"><text x="25" y="50" font-size="25">test</text></svg> |
+ <svg viewBox="0 0 1 1"><text x="0.25" y="0.5" font-size="0.25">test</text></svg> |
+ |
+ When selecting a font size below 0.5, FontCacheMac would request a font with size 0, |
+ which AppKit turns into 12. This lead to huge text rendering, instead of small text on Mac. |
+ Other platforms have different problems (Qt simply scales the font, leading to pixelation etc.) |
+ |
+ To fix this in a cross-platform fashion, we now always compute the final font size on screen, |
+ remove any scaling from the context, draw the text using the scaled font size, then reapply |
+ the context scale. This makes the example snippets above render exactly the same and fixes |
+ numerous of bugs, present since years. As we're now heavily using floating-point font sizes |
+ internally, depending on the scale of the document, it's very important to use the new |
+ floating-point text metrics information (floatAscent/floatDescent/floatHeight) everywhere in SVG. |
+ |
+ Fixes existing tests: css3/zoom-coords.xhtml (cross-platform inconsistencies should be gone, mac now reports floatHeight values for SVG text height) |
+ svg/hixie/text/003.html (no more pixelation) |
+ svg/batik/text/smallFonts.svg (small fonts aren't rendered huge anymore on mac) |
+ svg/hixie/viewbox/preserveAspectRatio/001.xml (bug 21774, no more awful spacing) |
+ svg/zoom/page/zoom-zoom-coords.xhtml (cross-platform inconsistencies should be gone, inspired by bug 50313) |
+ |
+ Tests: svg/text/font-size-below-point-five-2.svg (reduction from bug 50528) |
+ svg/text/font-size-below-point-five.svg (reduction from bug 50528) |
+ svg/text/scaled-font.svg (reduction from bug 12448) |
+ svg/text/small-fonts-2.svg (reduction from bug 14242) |
+ svg/text/small-fonts-3.svg (reduction from bug 17053) |
+ svg/text/small-fonts-in-html5.html (reduction from bug 19393) |
+ svg/text/small-fonts.svg (reduction from bug 20192)) |
+ |
+ * rendering/svg/RenderSVGInlineText.cpp: Cache 'float scalingFactor' & 'Font scaledFont', whenever the on-screen representation changes. |
+ * rendering/svg/RenderSVGInlineText.h: |
+ * rendering/svg/RenderSVGText.cpp: Update scalingFactor/scaledFont, if necessary. |
+ * rendering/svg/SVGInlineTextBox.cpp: Switch to new font rendering strategy. Always use scaledFont, and remove any context scale before drawing. |
+ * rendering/svg/SVGInlineTextBox.h: |
+ * rendering/svg/SVGTextLayoutEngineBaseline.cpp: Use floating-point metrics everywhere. |
+ * rendering/svg/SVGTextMetrics.cpp: Ditto. |
+ * rendering/svg/SVGTextMetrics.h: Ditto. |
+ * rendering/svg/SVGTextQuery.cpp: Ditto. |
+ * svg/SVGFont.cpp: Adjust stroke thickness, when drawing SVGFonts into a normalized context (no more scale). |
+ * svg/SVGTextContentElement.cpp: Make <text> elements always dependant on window size changes in combination with viewBox set. |
+ * svg/SVGTextPositioningElement.cpp: Remove now unnecessary code to determine wheter relative lengths are used as text attributes. |
+ * svg/SVGTextPositioningElement.h: |
+ |
+2011-02-03 Pavel Feldman <pfeldman@chromium.org> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: resources panel doesn't show frames after reload. |
+ https://bugs.webkit.org/show_bug.cgi?id=53430 |
+ |
+ * inspector/front-end/ResourcesPanel.js: |
+ (WebInspector.ResourcesPanel.prototype.show): |
+ (WebInspector.ResourcesPanel.prototype.loadEventFired): |
+ (WebInspector.ResourcesPanel.prototype._initDefaultSelection): |
+ (WebInspector.ResourcesPanel.prototype.reset): |
+ (WebInspector.ResourcesPanel.prototype.clear): |
+ * inspector/front-end/inspector.js: |
+ (WebInspector.loadEventFired): |
+ |
+2011-02-01 Alexander Pavlov <apavlov@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: Remove the *2 suffix from the CSS style-related protocol methods |
+ https://bugs.webkit.org/show_bug.cgi?id=53492 |
+ |
+ * inspector/Inspector.idl: |
+ * inspector/InspectorCSSAgent.cpp: |
+ (WebCore::InspectorCSSAgent::getStylesForNode): |
+ (WebCore::InspectorCSSAgent::getInlineStyleForNode): |
+ (WebCore::InspectorCSSAgent::getComputedStyleForNode): |
+ (WebCore::InspectorCSSAgent::getAllStyles): |
+ (WebCore::InspectorCSSAgent::getStyleSheet): |
+ (WebCore::InspectorCSSAgent::getStyleSheetText): |
+ (WebCore::InspectorCSSAgent::setStyleSheetText): |
+ (WebCore::InspectorCSSAgent::setPropertyText): |
+ (WebCore::InspectorCSSAgent::toggleProperty): |
+ (WebCore::InspectorCSSAgent::setRuleSelector): |
+ (WebCore::InspectorCSSAgent::addRule): |
+ * inspector/InspectorCSSAgent.h: |
+ * inspector/front-end/AuditRules.js: |
+ (WebInspector.AuditRules.UnusedCssRule.prototype.doRun): |
+ * inspector/front-end/CSSStyleModel.js: |
+ (WebInspector.CSSStyleModel.prototype.getStylesAsync): |
+ (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync): |
+ (WebInspector.CSSStyleModel.prototype.getInlineStyleAsync): |
+ (WebInspector.CSSStyleModel.prototype.setRuleSelector): |
+ (WebInspector.CSSStyleModel.prototype.addRule): |
+ (WebInspector.CSSStyleModel.prototype._styleSheetChanged): |
+ (WebInspector.CSSStyleModel.prototype._onRevert): |
+ (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt): |
+ (WebInspector.CSSProperty.prototype.setText): |
+ (WebInspector.CSSProperty.prototype.setDisabled): |
+ (WebInspector.CSSStyleSheet.createForId): |
+ (WebInspector.CSSStyleSheet.prototype.setText): |
+ |
+2011-02-03 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Daniel Bates. |
+ |
+ Teach XSSFilter about data URLs |
+ https://bugs.webkit.org/show_bug.cgi?id=53662 |
+ |
+ The XSS filter doesn't really make sense for data URLs because |
+ everything in a "response" from a data URL was part of the request. |
+ |
+ Test: http/tests/security/xssAuditor/data-urls-work.html |
+ |
+ * html/parser/XSSFilter.cpp: |
+ (WebCore::XSSFilter::init): |
+ (WebCore::XSSFilter::filterToken): |
+ |
+2011-02-02 Chris Evans <cevans@chromium.org> |
+ |
+ Reviewed by Darin Fisher. |
+ |
+ window.find() can fail when switching case sensitivity |
+ https://bugs.webkit.org/show_bug.cgi?id=53654 |
+ |
+ Reset the pattern to a safe one when done, to avoid usearch_reset() |
+ indirectly touching the old, stale text pointer. |
+ |
+ Test: fast/text/find-window.html |
+ |
+ * editing/TextIterator.cpp: |
+ (WebCore::SearchBuffer::~SearchBuffer): leave a safe pattern buffer when done. |
+ |
+2011-02-02 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Daniel Bates. |
+ |
+ Teach XSSFilter that <param> elements can contain URLs |
+ https://bugs.webkit.org/show_bug.cgi?id=53652 |
+ |
+ When loading plugins for the <object> tag, we're "smart" enough to |
+ reach into the <param> elements and pull out the URL in some cases. |
+ This patch teaches the XSSFilter how to block injections into those |
+ sorts of param elements. |
+ |
+ Fixes: |
+ http/tests/security/xssAuditor/object-* |
+ |
+ * html/HTMLParamElement.cpp: |
+ (WebCore::HTMLParamElement::isURLParameter): |
+ (WebCore::HTMLParamElement::isURLAttribute): |
+ (WebCore::HTMLParamElement::addSubresourceAttributeURLs): |
+ * html/HTMLParamElement.h: |
+ - Add a helper function so that HTMLParamElement can share the |
+ ground truth for these names with the XSSFilter. |
+ * html/parser/XSSFilter.cpp: |
+ (WebCore::XSSFilter::filterTokenInitial): |
+ (WebCore::XSSFilter::filterParamToken): |
+ * html/parser/XSSFilter.h: |
+ |
+2011-02-02 Dimitri Glazkov <dglazkov@chromium.org> |
+ |
+ Reviewed by David Levin. |
+ |
+ GCC compiler on ARM issues bogus warnings and fails to compile. |
+ https://bugs.webkit.org/show_bug.cgi?id=53620 |
+ |
+ Despite warnings explicitly being disallowed (-Wno-uninitialized), |
+ gcc (Ubuntu 4.4.3-4ubuntu5) 4.4.3 throws up the warnings like: |
+ |
+ "error: 'colorTransparent.unstatic.4909' may be used uninitialized in this function" |
+ |
+ The fix is to add an extra condition, which somehow pacifies the compiler. |
+ |
+ * css/CSSPrimitiveValue.cpp: |
+ (WebCore::CSSPrimitiveValue::createColor): Added workaround conditions. |
+ |
+2011-02-02 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Daniel Bates. |
+ |
+ Teach XSSFilter about X-XSS-Protection |
+ https://bugs.webkit.org/show_bug.cgi?id=53640 |
+ |
+ This patch causes us to pass: |
+ http/tests/security/xssAuditor/full-block-* |
+ http/tests/security/xssAuditor/no-protection-script-tag.html |
+ |
+ * html/parser/XSSFilter.cpp: |
+ (WebCore::XSSFilter::XSSFilter): |
+ (WebCore::XSSFilter::init): |
+ (WebCore::XSSFilter::filterToken): |
+ * html/parser/XSSFilter.h: |
+ |
+2011-02-02 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Daniel Bates. |
+ |
+ When XSSFilter blocks JavaScript URLs, use a safe JavaScript URL |
+ instead of the empty string |
+ https://bugs.webkit.org/show_bug.cgi?id=53643 |
+ |
+ In a URL context, the empty string completes to the URL of the current |
+ page, which causes these tests to go into an infinite loop. Instead, |
+ we should use a "safe" JavaScript URL that does nothing. |
+ |
+ Fixes: |
+ http/tests/security/xssAuditor/javascript-link* |
+ |
+ * html/parser/XSSFilter.cpp: |
+ (WebCore::XSSFilter::eraseDangerousAttributesIfInjected): |
+ |
+2011-02-02 Dan Bernstein <mitz@apple.com> |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ <rdar://problem/8380506> REGRESSION (r61921): RTL text in <b> tag doesn't display in WebKit under certain conditions |
+ https://bugs.webkit.org/show_bug.cgi?id=44942 |
+ |
+ Test: fast/text/bidi-embedding-pop-and-push-same-2.html |
+ |
+ * platform/text/BidiResolver.h: |
+ (WebCore::::commitExplicitEmbedding): Changed to return a boolean indicating whether there was |
+ a change to embedding levels. |
+ (WebCore::::createBidiRunsForLine): If embedding levels did not change as a result of committing |
+ the explicit embedding sequence, then runs were not added, and we should continue normally. |
+ |
+2011-02-02 Sam Weinig <sam@webkit.org> |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ Fix miscalculation of the overhang area used for painting. We were |
+ not correctly accounting for scrollbars resulting in an non-negative |
+ overhang even when we weren't over the edge. |
+ |
+ * platform/ScrollView.cpp: |
+ (WebCore::ScrollView::calculateOverhangAreasForPainting): |
+ |
+2011-02-02 Jeremy Orlow <jorlow@chromium.org> |
+ |
+ Reviewed by Nate Chapin. |
+ |
+ IDBTransaction and IDBRequest can be deleted while ScriptExecutionContext is iterating....which is bad |
+ https://bugs.webkit.org/show_bug.cgi?id=52722 |
+ |
+ The solution is to change ScriptExecutionContext's destructor to iterate over |
+ the list in a way that handles the mutations. This new method is destructive, |
+ but that's OK since the object is going away. I've also added a several asserts. |
+ |
+ There should be no behavior change. |
+ |
+ * dom/ScriptExecutionContext.cpp: |
+ (WebCore::ScriptExecutionContext::ScriptExecutionContext): |
+ (WebCore::ScriptExecutionContext::~ScriptExecutionContext): |
+ (WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects): |
+ (WebCore::ScriptExecutionContext::suspendActiveDOMObjects): |
+ (WebCore::ScriptExecutionContext::resumeActiveDOMObjects): |
+ (WebCore::ScriptExecutionContext::stopActiveDOMObjects): |
+ (WebCore::ScriptExecutionContext::createdActiveDOMObject): |
+ (WebCore::ScriptExecutionContext::destroyedActiveDOMObject): |
+ * dom/ScriptExecutionContext.h: |
+ * storage/IDBTransaction.cpp: |
+ (WebCore::IDBTransaction::contextDestroyed): |
+ * storage/IDBTransaction.h: |
+ |
+2011-02-02 Mark Rowe <mrowe@apple.com> |
+ |
+ Build fix. |
+ |
+ * WebCore.exp.in: Remove some bogus symbols from the .exp.in file. |
+ * platform/mac/ScrollbarThemeMac.mm: |
+ (WebCore::ScrollbarThemeMac::unregisterScrollbar): Look the object |
+ up in the HashMap rather than relying on a local variable that doesn't |
+ exist. |
+ |
+2011-02-02 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Daniel Bates. |
+ |
+ Teach XSSFilter about JavaScript URLs |
+ https://bugs.webkit.org/show_bug.cgi?id=53635 |
+ |
+ This patch teaches the XSSFilter to check for JavaScript URLs in |
+ attribute values. If this approach has too many false positives, we |
+ can restrict which attribute names we examine. |
+ |
+ Fixes these tests: |
+ http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL.html |
+ http/tests/security/xssAuditor/dom-write-location-javascript-URL.html |
+ http/tests/security/xssAuditor/iframe-javascript-url* |
+ |
+ * html/parser/XSSFilter.cpp: |
+ (WebCore::HTMLNames::containsJavaScriptURL): |
+ (WebCore::XSSFilter::filterTokenInitial): |
+ (WebCore::XSSFilter::eraseDangerousAttributesIfInjected): |
+ * html/parser/XSSFilter.h: |
+ |
+2011-02-02 Dan Bernstein <mitz@apple.com> |
+ |
+ Reviewed by Sam Weinig, even though this is just a... |
+ |
+ ...build fix. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (WebCore::ScrollAnimatorMac::~ScrollAnimatorMac): |
+ |
+2011-02-02 Mark Rowe <mrowe@apple.com> |
+ |
+ Reviewed by Beth Dakin. |
+ |
+ <rdar://problem/8952012> Crash on launch inside scrollbar code. |
+ |
+ We need to ensure that we remove ourselves as the delegates of objects when we're going |
+ away as failing to do this can lead to crashes if the lifetime of the other objects |
+ is longer than ours. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (WebCore::ScrollAnimatorMac::~ScrollAnimatorMac): |
+ * platform/mac/ScrollbarThemeMac.mm: |
+ (WebCore::ScrollbarThemeMac::unregisterScrollbar): |
+ |
+2011-02-02 Beth Dakin <bdakin@apple.com> |
+ |
+ Build fix. |
+ |
+ * WebCore.exp.in: |
+ |
+2011-02-02 Patrick Gansterer <paroga@webkit.org> |
+ |
+ Unreviewed WinCE build fix for r77397. |
+ |
+ * page/wince/FrameWinCE.cpp: |
+ (WebCore::computePageRectsForFrame): |
+ |
+2011-02-02 Patrick Gansterer <paroga@webkit.org> |
+ |
+ Unreviewed WinCE build fix for r77398. |
+ |
+ * platform/graphics/wince/PlatformPathWinCE.cpp: |
+ (WebCore::containsPoint): |
+ (WebCore::inflateRectToContainPoint): |
+ (WebCore::PlatformPath::addRect): |
+ * platform/graphics/wince/SharedBitmap.cpp: |
+ (WebCore::SharedBitmap::drawPattern): |
+ * rendering/RenderThemeWinCE.cpp: |
+ (WebCore::RenderThemeWinCE::paintMenuListButton): |
+ (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton): |
+ (WebCore::RenderThemeWinCE::paintSliderTrack): |
+ (WebCore::RenderThemeWinCE::paintMediaMuteButton): |
+ (WebCore::RenderThemeWinCE::paintMediaPlayButton): |
+ (WebCore::RenderThemeWinCE::paintMediaSeekBackButton): |
+ (WebCore::RenderThemeWinCE::paintMediaSeekForwardButton): |
+ |
+2011-02-02 Jian Li <jianli@chromium.org> |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ [V8] Accessing DataView with index of -1 returns 0, doesn't throw |
+ https://bugs.webkit.org/show_bug.cgi?id=53559 |
+ |
+ Added test cases to cover this in fast/canvas/webgl/data-view-test.html. |
+ |
+ * html/canvas/DataView.h: |
+ (WebCore::DataView::beyondRange): |
+ |
+2011-02-02 Sam Weinig <sam@webkit.org> |
+ |
+ Reviewed by Beth Dakin. |
+ |
+ Add ChromeClient function to paint custom overhang areas. |
+ https://bugs.webkit.org/show_bug.cgi?id=53639 |
+ |
+ * page/Chrome.cpp: |
+ (WebCore::ChromeClient::paintCustomOverhangArea): |
+ * page/ChromeClient.h: |
+ Add ChromeClient function. |
+ |
+ * page/FrameView.cpp: |
+ (WebCore::FrameView::paintOverhangAreas): |
+ * page/FrameView.h: |
+ Call out the the ChromeClient, call ScrollView base implementation |
+ if the ChromeClient returns false. |
+ |
+ * platform/ScrollView.cpp: |
+ (WebCore::ScrollView::paintOverhangAreas): |
+ * platform/ScrollView.h: |
+ Add dirty rect for use when painting overhang areas. |
+ |
+2011-02-02 Peter Kasting <pkasting@google.com> |
+ |
+ Not reviewed, build fix. |
+ |
+ Fix compile after r77427. |
+ https://bugs.webkit.org/show_bug.cgi?id=53455 |
+ |
+ * platform/graphics/qt/ImageDecoderQt.cpp: |
+ (WebCore::ImageDecoderQt::internalHandleCurrentImage): |
+ * platform/image-decoders/ImageDecoder.cpp: |
+ (WebCore::ImageFrame::operator=): |
+ * platform/image-decoders/bmp/BMPImageReader.cpp: |
+ (WebCore::BMPImageReader::decodeBMP): |
+ * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: |
+ (WebCore::JPEGImageDecoder::outputScanlines): |
+ * platform/image-decoders/png/PNGImageDecoder.cpp: |
+ (WebCore::PNGImageDecoder::rowAvailable): |
+ * platform/image-decoders/webp/WEBPImageDecoder.cpp: |
+ (WebCore::WEBPImageDecoder::decode): |
+ |
+2011-02-02 Peter Kasting <pkasting@google.com> |
+ |
+ Reviewed by David Levin. |
+ |
+ Clean up ImageDecoder's comments (remove/trim/clarify). |
+ https://bugs.webkit.org/show_bug.cgi?id=53455 |
+ |
+ This also renames or eliminates a couple of functions for clarity, and |
+ switches a couple erroneous strncmp() calls to memcmp(). |
+ |
+ * platform/image-decoders/ImageDecoder.cpp: |
+ (WebCore::ImageDecoder::create): |
+ (WebCore::ImageFrame::clearPixelData): |
+ (WebCore::ImageFrame::zeroFillPixelData): |
+ (WebCore::ImageFrame::setSize): |
+ * platform/image-decoders/ImageDecoder.h: |
+ (WebCore::ImageFrame::originalFrameRect): |
+ (WebCore::ImageFrame::setOriginalFrameRect): |
+ (WebCore::ImageDecoder::ImageDecoder): |
+ (WebCore::ImageDecoder::~ImageDecoder): |
+ (WebCore::ImageDecoder::isSizeAvailable): |
+ (WebCore::ImageDecoder::size): |
+ (WebCore::ImageDecoder::setIgnoreGammaAndColorProfile): |
+ (WebCore::ImageDecoder::clearFrameBufferCache): |
+ (WebCore::ImageDecoder::isOverSize): |
+ * platform/image-decoders/bmp/BMPImageReader.cpp: |
+ (WebCore::BMPImageReader::processNonRLEData): |
+ * platform/image-decoders/cg/ImageDecoderCG.cpp: |
+ (WebCore::ImageFrame::setSize): |
+ * platform/image-decoders/gif/GIFImageDecoder.cpp: |
+ (WebCore::GIFImageDecoder::clearFrameBufferCache): |
+ (WebCore::GIFImageDecoder::frameComplete): |
+ (WebCore::GIFImageDecoder::initFrameBuffer): |
+ * platform/image-decoders/jpeg/JPEGImageDecoder.h: |
+ * platform/image-decoders/qt/ImageFrameQt.cpp: |
+ (WebCore::ImageFrame::operator=): |
+ (WebCore::ImageFrame::clearPixelData): |
+ (WebCore::ImageFrame::zeroFillPixelData): |
+ (WebCore::ImageFrame::setSize): |
+ * platform/image-decoders/skia/ImageDecoderSkia.cpp: |
+ (WebCore::ImageFrame::operator=): |
+ (WebCore::ImageFrame::clearPixelData): |
+ (WebCore::ImageFrame::zeroFillPixelData): |
+ (WebCore::ImageFrame::setSize): |
+ * platform/image-decoders/webp/WEBPImageDecoder.h: |
+ |
+2011-02-02 Vangelis Kokkevis <vangelis@chromium.org> |
+ |
+ [chromium] Adding support for reflections to the accelerated |
+ compositing path. |
+ https://bugs.webkit.org/show_bug.cgi?id=53179 |
+ |
+ All layout tests in compositing/reflections generate correct |
+ results with the exception of: |
+ 1. nested-reflection-anchor-point.html : There appears to be |
+ some issue with the layer transform math that I haven't been |
+ able to track down yet. |
+ 2. reflection-opacity.html : The current implementation applies |
+ opacity before doing the reflection which makes this test |
+ produce incorrect results. This will affect reflected layers |
+ with opacity that overlap their original layer. FIXME comment |
+ added in the code. |
+ |
+ Tests: Covered by existing layout tests in compositing/reflections. |
+ Please see above for exceptions. |
+ |
+ * platform/graphics/chromium/GraphicsLayerChromium.cpp: |
+ (WebCore::GraphicsLayerChromium::setReplicatedByLayer): |
+ (WebCore::GraphicsLayerChromium::updateAnchorPoint): |
+ * platform/graphics/chromium/GraphicsLayerChromium.h: |
+ * platform/graphics/chromium/LayerChromium.cpp: |
+ (WebCore::LayerChromium::LayerChromium): |
+ * platform/graphics/chromium/LayerChromium.h: |
+ (WebCore::LayerChromium::setReplicaLayer): |
+ (WebCore::LayerChromium::replicaLayer): |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ (WebCore::LayerRendererChromium::updateLayersRecursive): |
+ (WebCore::LayerRendererChromium::drawLayer): |
+ * platform/graphics/chromium/RenderSurfaceChromium.cpp: |
+ (WebCore::RenderSurfaceChromium::drawableContentRect): |
+ (WebCore::RenderSurfaceChromium::drawSurface): |
+ (WebCore::RenderSurfaceChromium::draw): |
+ * platform/graphics/chromium/RenderSurfaceChromium.h: |
+ (WebCore::RenderSurfaceChromium::drawTransform): |
+ |
+2011-02-02 Xiyuan Xia <xiyuan@chromium.org> |
+ |
+ Reviewed by Tony Chang. |
+ |
+ [Chromium] Select popup with padding has white strip on right |
+ https://bugs.webkit.org/show_bug.cgi?id=53602 |
+ |
+ No new tests as this change restores old behavior. |
+ |
+ * platform/chromium/PopupMenuChromium.cpp: |
+ (WebCore::PopupListBox::layout): |
+ |
+2011-02-02 Beth Dakin <bdakin@apple.com> |
+ |
+ Reviewed by Mark Rowe. |
+ |
+ Fix for <rdar://problem/8950343> CrashTracer: [USER] |
+ 1 crash in WebProcess at com.apple.WebCore: |
+ WebCore::ScrollbarThemeMac::unregisterScrollbar + 22 |
+ |
+ It is possible for a Scrollbar's ScrollableArea to be null, |
+ so we must null check. |
+ * platform/mac/ScrollbarThemeMac.mm: |
+ (WebCore::ScrollbarThemeMac::registerScrollbar): |
+ (WebCore::ScrollbarThemeMac::unregisterScrollbar): |
+ |
+2011-02-02 Zhenyao Mo <zmo@google.com> |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ bufferData and bufferSubData should generate INVALID_VALUE with negative input |
+ https://bugs.webkit.org/show_bug.cgi?id=53626 |
+ |
+ * html/canvas/WebGLRenderingContext.cpp: |
+ (WebCore::WebGLRenderingContext::bufferData): |
+ (WebCore::WebGLRenderingContext::bufferSubData): |
+ |
+2011-02-02 Jeff Miller <jeffm@apple.com> |
+ |
+ Reviewed by Darin Adler and Steve Falkenburg. |
+ |
+ Add DerivedSources.make to some Visual Studio projects |
+ https://bugs.webkit.org/show_bug.cgi?id=53607 |
+ |
+ * WebCore.vcproj/WebCoreGenerated.vcproj: Add DerivedSources.make. |
+ |
+2011-02-02 Cris Neckar <cdn@chromium.org> |
+ |
+ Reviewed by James Robinson. |
+ |
+ Refcount domwindows when dispatching device orientation events. |
+ https://bugs.webkit.org/show_bug.cgi?id=53623 |
+ |
+ Test: fast/events/device-orientation-crash.html |
+ |
+ * dom/DeviceMotionController.cpp: |
+ (WebCore::DeviceMotionController::timerFired): |
+ (WebCore::DeviceMotionController::didChangeDeviceMotion): |
+ * dom/DeviceMotionController.h: |
+ * dom/DeviceOrientationController.cpp: |
+ (WebCore::DeviceOrientationController::timerFired): |
+ (WebCore::DeviceOrientationController::didChangeDeviceOrientation): |
+ * dom/DeviceOrientationController.h: |
+ |
+2011-02-02 Zhenyao Mo <zmo@google.com> |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ A deleted object should never been bound again |
+ https://bugs.webkit.org/show_bug.cgi?id=53604 |
+ |
+ * html/canvas/WebGLRenderingContext.cpp: |
+ (WebCore::WebGLRenderingContext::checkObjectToBeBound): Helper function to bind* and useProgram. |
+ (WebCore::WebGLRenderingContext::bindBuffer): Use checkObjectToBeBound. |
+ (WebCore::WebGLRenderingContext::bindFramebuffer): Ditto. |
+ (WebCore::WebGLRenderingContext::bindRenderbuffer): Ditto. |
+ (WebCore::WebGLRenderingContext::bindTexture): Ditto, also check the target matching. |
+ (WebCore::WebGLRenderingContext::deleteObject): Helper funtion to delete*. |
+ (WebCore::WebGLRenderingContext::deleteBuffer): Use deleteObject. |
+ (WebCore::WebGLRenderingContext::deleteFramebuffer): Ditto. |
+ (WebCore::WebGLRenderingContext::deleteProgram): Ditto. |
+ (WebCore::WebGLRenderingContext::deleteRenderbuffer): Ditto. |
+ (WebCore::WebGLRenderingContext::deleteShader): Ditto. |
+ (WebCore::WebGLRenderingContext::deleteTexture): Ditto. |
+ (WebCore::WebGLRenderingContext::useProgram): Use checkObjectToBeBound. |
+ * html/canvas/WebGLRenderingContext.h: |
+ * html/canvas/WebGLTexture.h: |
+ (WebCore::WebGLTexture::getTarget): Accessor to cached target. |
+ |
+2011-02-02 Alejandro G. Castro <alex@igalia.com> |
+ |
+ Unreviewed Efl buildfix after r77399. |
+ |
+ * CMakeListsEfl.txt: |
+ |
+2011-02-02 Kenneth Russell <kbr@google.com> |
+ |
+ Reviewed by James Robinson. |
+ |
+ Rename Typed Array subset to subarray |
+ https://bugs.webkit.org/show_bug.cgi?id=53618 |
+ |
+ * html/canvas/Float32Array.cpp: |
+ (WebCore::Float32Array::subarray): |
+ * html/canvas/Float32Array.h: |
+ * html/canvas/Float32Array.idl: |
+ * html/canvas/Int16Array.cpp: |
+ (WebCore::Int16Array::subarray): |
+ * html/canvas/Int16Array.h: |
+ * html/canvas/Int16Array.idl: |
+ * html/canvas/Int32Array.cpp: |
+ (WebCore::Int32Array::subarray): |
+ * html/canvas/Int32Array.h: |
+ * html/canvas/Int32Array.idl: |
+ * html/canvas/Int8Array.cpp: |
+ (WebCore::Int8Array::subarray): |
+ * html/canvas/Int8Array.h: |
+ * html/canvas/Int8Array.idl: |
+ * html/canvas/TypedArrayBase.h: |
+ (WebCore::TypedArrayBase::subarrayImpl): |
+ * html/canvas/Uint16Array.cpp: |
+ (WebCore::Uint16Array::subarray): |
+ * html/canvas/Uint16Array.h: |
+ * html/canvas/Uint16Array.idl: |
+ * html/canvas/Uint32Array.cpp: |
+ (WebCore::Uint32Array::subarray): |
+ * html/canvas/Uint32Array.h: |
+ * html/canvas/Uint32Array.idl: |
+ * html/canvas/Uint8Array.cpp: |
+ (WebCore::Uint8Array::subarray): |
+ * html/canvas/Uint8Array.h: |
+ * html/canvas/Uint8Array.idl: |
+ |
+2011-02-02 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Add an empty file for Content Security Policy |
+ https://bugs.webkit.org/show_bug.cgi?id=53573 |
+ |
+ Posting this as a separate patch because editing the build files is so |
+ painful. |
+ |
+ * Android.mk: |
+ * CMakeLists.txt: |
+ * GNUmakefile.am: |
+ * WebCore.gypi: |
+ * WebCore.pro: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ |
+2011-02-02 Dan Winship <danw@gnome.org> |
+ |
+ Reviewed by Martin Robinson. |
+ |
+ [GTK] remove old data: URI handler, fix the SoupRequest-based one |
+ to pass tests |
+ https://bugs.webkit.org/show_bug.cgi?id=50885 |
+ |
+ * platform/network/soup/ResourceHandleSoup.cpp: |
+ (WebCore::sendRequestCallback): Do content-type sniffing here for |
+ non-HTTP requests. |
+ (WebCore::startHTTPRequest): Rename to match WebKit style. |
+ (WebCore::ResourceHandle::start): Pass everything except HTTP to |
+ startNonHTTPRequest, letting the SoupRequester decide whether it's |
+ supported or not. |
+ (WebCore::startNonHTTPRequest): Remove some old pre-SoupRequester |
+ code that was a no-op for file: URIs, but would break some data: |
+ URIs. |
+ |
+2011-02-02 Dimitri Glazkov <dglazkov@chromium.org> |
+ |
+ Update even more references to right() and bottom() in Chromium. Sheesh. |
+ |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ (WebCore::LayerRendererChromium::getFramebufferPixels): Replaced bottom/right with maxY/maxX. |
+ |
+2011-02-02 Alejandro G. Castro <alex@igalia.com> |
+ |
+ Unreviewed Gtk3 buildfix after r77286. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=53520 |
+ Remove the physical terminology from IntRect and FloatRect. |
+ |
+ * platform/gtk/RenderThemeGtk3.cpp: |
+ (WebCore::RenderThemeGtk::paintMenuList): |
+ |
+2011-02-02 Anders Carlsson <andersca@apple.com> |
+ |
+ Fix build. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (WebCore::ScrollAnimatorMac::pinnedInDirection): |
+ |
+2011-02-02 David Hyatt <hyatt@apple.com> |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=53619 |
+ |
+ Floats should not use physical terminology for their rects. Replace left/top with x/y and right/bottom |
+ with maxX/maxY. This matches IntRect. |
+ |
+ * rendering/RenderBlock.cpp: |
+ (WebCore::RenderBlock::addOverflowFromFloats): |
+ (WebCore::RenderBlock::flipFloatForWritingMode): |
+ (WebCore::RenderBlock::paintFloats): |
+ (WebCore::RenderBlock::selectionGaps): |
+ (WebCore::RenderBlock::addOverhangingFloats): |
+ (WebCore::RenderBlock::addIntrudingFloats): |
+ (WebCore::RenderBlock::hitTestFloats): |
+ (WebCore::RenderBlock::adjustForBorderFit): |
+ * rendering/RenderBlock.h: |
+ (WebCore::RenderBlock::FloatingObject::x): |
+ (WebCore::RenderBlock::FloatingObject::maxX): |
+ (WebCore::RenderBlock::FloatingObject::y): |
+ (WebCore::RenderBlock::FloatingObject::maxY): |
+ (WebCore::RenderBlock::FloatingObject::setX): |
+ (WebCore::RenderBlock::FloatingObject::setY): |
+ (WebCore::RenderBlock::logicalTopForFloat): |
+ (WebCore::RenderBlock::logicalBottomForFloat): |
+ (WebCore::RenderBlock::logicalLeftForFloat): |
+ (WebCore::RenderBlock::logicalRightForFloat): |
+ (WebCore::RenderBlock::setLogicalTopForFloat): |
+ (WebCore::RenderBlock::setLogicalLeftForFloat): |
+ (WebCore::RenderBlock::xPositionForFloatIncludingMargin): |
+ (WebCore::RenderBlock::yPositionForFloatIncludingMargin): |
+ |
+2011-02-02 Dimitri Glazkov <dglazkov@chromium.org> |
+ |
+ Update more references to right() and bottom() in Chromium Win. |
+ |
+ * platform/graphics/chromium/TransparencyWin.cpp: |
+ (WebCore::TransparencyWin::compositeOpaqueComposite): Replaced bottom/right with maxY/maxX. |
+ (WebCore::TransparencyWin::compositeTextComposite): Ditto. |
+ * rendering/RenderThemeChromiumWin.cpp: |
+ (WebCore::RenderThemeChromiumWin::paintMenuList): Ditto. |
+ |
+2011-02-02 Adam Roben <aroben@apple.com> |
+ |
+ Encode/decode FormData and FormDataElement objects consistently |
+ |
+ Fixes <http://webkit.org/b/53615> <rdar://problem/8943346> WebKit2: Restoring session state |
+ that contains form data fails (asserts in Debug build) |
+ |
+ To prevent this from interfering with WebKit2 testing, it's useful to get this into a build |
+ now, even though we don't have an automated test for it yet. Writing a test is covered by |
+ <http://webkit.org/b/53616>. |
+ |
+ Reviewed by Darin Adler. |
+ |
+ * history/HistoryItem.cpp: Bump the encoding version, since this patch changes how we encode |
+ FormData objects. |
+ |
+ * platform/network/FormData.cpp: |
+ (WebCore::decode): Decode the type from the Decoder, rather than getting it from the |
+ default-constructed FormDataElement. Failing to do this meant that all future uses of the |
+ Decoder would be reading from an unexpected part of the buffer (i.e., the next decode would |
+ start by reading the uint32_t that we forgot to decode here, and so on). We already had code |
+ to correctly set the FormDataElement's type based on this decoded type later in the |
+ function. |
+ (WebCore::FormData::encodeForBackForward): Encode m_identifier as an int64_t, since that |
+ matches its type and how we decode it. |
+ |
+2011-02-02 Dan Winship <danw@gnome.org> |
+ |
+ Reviewed by Martin Robinson. |
+ |
+ [GTK] drop soup cache stuff, which has been moved to libsoup |
+ https://bugs.webkit.org/show_bug.cgi?id=50747 |
+ |
+ Use libsoup-based cache/requester API and remove the WebCore version |
+ of this functionality. This has been pushed upstream fully. |
+ |
+ No new tests because this should not change functionality. |
+ |
+ * GNUmakefile.am: Update for removed files. |
+ * platform/network/ResourceHandleInternal.h: |
+ (WebCore::ResourceHandleInternal::ResourceHandleInternal): Update |
+ type names, drop m_requester. |
+ * platform/network/soup/ResourceHandleSoup.cpp: |
+ (WebCore::ensureSessionIsInitialized): Add a SoupRequester to the |
+ session. |
+ (WebCore::parseDataUrl): |
+ (WebCore::startHttp): Get the requester from the session rather |
+ than using m_requester. |
+ (WebCore::sendRequestCallback): |
+ (WebCore::ResourceHandle::platformSetDefersLoading): |
+ (WebCore::readCallback): |
+ (WebCore::startGio): Update type names. |
+ * platform/network/soup/cache/soup-directory-input-stream.c: Removed. |
+ * platform/network/soup/cache/soup-directory-input-stream.h: Removed. |
+ * platform/network/soup/cache/soup-http-input-stream.c: Removed. |
+ * platform/network/soup/cache/soup-http-input-stream.h: Removed. |
+ * platform/network/soup/cache/soup-request-data.c: Removed. |
+ * platform/network/soup/cache/soup-request-data.h: Removed. |
+ * platform/network/soup/cache/soup-request-file.c: Removed. |
+ * platform/network/soup/cache/soup-request-file.h: Removed. |
+ * platform/network/soup/cache/soup-request-http.c: Removed. |
+ * platform/network/soup/cache/soup-request-http.h: Removed. |
+ * platform/network/soup/cache/soup-request.c: Removed. |
+ * platform/network/soup/cache/soup-request.h: Removed. |
+ * platform/network/soup/cache/soup-requester.c: Removed. |
+ * platform/network/soup/cache/soup-requester.h: Removed. |
+ * platform/network/soup/cache/webkit/soup-cache-private.h: Removed. |
+ * platform/network/soup/cache/webkit/soup-cache.c: Removed. |
+ * platform/network/soup/cache/webkit/soup-cache.h: Removed. |
+ |
+2011-02-02 David Hyatt <hyatt@apple.com> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=53520 |
+ |
+ Remove physical accessors from IntRect and FloatRect. |
+ |
+ * page/FrameView.cpp: |
+ (WebCore::FrameView::adjustPageHeightDeprecated): |
+ * platform/graphics/FloatRect.h: |
+ * platform/graphics/IntRect.h: |
+ |
+2011-02-02 David Hyatt <hyatt@apple.com> |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=53614 |
+ |
+ Remove physical terminology from overflow. Replace with minX/maxX/minY/maxY. |
+ |
+ * rendering/InlineFlowBox.cpp: |
+ (WebCore::InlineFlowBox::addBoxShadowVisualOverflow): |
+ (WebCore::InlineFlowBox::addTextBoxVisualOverflow): |
+ * rendering/InlineFlowBox.h: |
+ (WebCore::InlineFlowBox::minYLayoutOverflow): |
+ (WebCore::InlineFlowBox::maxYLayoutOverflow): |
+ (WebCore::InlineFlowBox::minXLayoutOverflow): |
+ (WebCore::InlineFlowBox::maxXLayoutOverflow): |
+ (WebCore::InlineFlowBox::logicalLeftLayoutOverflow): |
+ (WebCore::InlineFlowBox::logicalRightLayoutOverflow): |
+ (WebCore::InlineFlowBox::logicalTopLayoutOverflow): |
+ (WebCore::InlineFlowBox::logicalBottomLayoutOverflow): |
+ (WebCore::InlineFlowBox::minYVisualOverflow): |
+ (WebCore::InlineFlowBox::maxYVisualOverflow): |
+ (WebCore::InlineFlowBox::minXVisualOverflow): |
+ (WebCore::InlineFlowBox::maxXVisualOverflow): |
+ (WebCore::InlineFlowBox::logicalLeftVisualOverflow): |
+ (WebCore::InlineFlowBox::logicalRightVisualOverflow): |
+ (WebCore::InlineFlowBox::logicalminYVisualOverflow): |
+ (WebCore::InlineFlowBox::logicalmaxYVisualOverflow): |
+ * rendering/RenderBlock.cpp: |
+ (WebCore::RenderBlock::adjustLinePositionForPagination): |
+ * rendering/RenderBlockLineLayout.cpp: |
+ (WebCore::RenderBlock::beforeSideVisualOverflowForLine): |
+ (WebCore::RenderBlock::afterSideVisualOverflowForLine): |
+ (WebCore::RenderBlock::beforeSideLayoutOverflowForLine): |
+ (WebCore::RenderBlock::afterSideLayoutOverflowForLine): |
+ * rendering/RenderBox.cpp: |
+ (WebCore::RenderBox::scrollWidth): |
+ (WebCore::RenderBox::scrollHeight): |
+ * rendering/RenderBox.h: |
+ (WebCore::RenderBox::minYLayoutOverflow): |
+ (WebCore::RenderBox::maxYLayoutOverflow): |
+ (WebCore::RenderBox::minXLayoutOverflow): |
+ (WebCore::RenderBox::maxXLayoutOverflow): |
+ (WebCore::RenderBox::logicalLeftLayoutOverflow): |
+ (WebCore::RenderBox::logicalRightLayoutOverflow): |
+ (WebCore::RenderBox::minYVisualOverflow): |
+ (WebCore::RenderBox::maxYVisualOverflow): |
+ (WebCore::RenderBox::minXVisualOverflow): |
+ (WebCore::RenderBox::maxXVisualOverflow): |
+ (WebCore::RenderBox::logicalLeftVisualOverflow): |
+ (WebCore::RenderBox::logicalRightVisualOverflow): |
+ * rendering/RenderInline.cpp: |
+ (WebCore::RenderInline::linesVisualOverflowBoundingBox): |
+ * rendering/RenderLayerCompositor.cpp: |
+ (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): |
+ * rendering/RenderLineBoxList.cpp: |
+ (WebCore::RenderLineBoxList::anyLineIntersectsRect): |
+ (WebCore::RenderLineBoxList::lineIntersectsDirtyRect): |
+ (WebCore::RenderLineBoxList::paint): |
+ (WebCore::RenderLineBoxList::hitTest): |
+ * rendering/RenderMarquee.cpp: |
+ (WebCore::RenderMarquee::computePosition): |
+ * rendering/RenderOverflow.h: |
+ (WebCore::RenderOverflow::RenderOverflow): |
+ (WebCore::RenderOverflow::minYLayoutOverflow): |
+ (WebCore::RenderOverflow::maxYLayoutOverflow): |
+ (WebCore::RenderOverflow::minXLayoutOverflow): |
+ (WebCore::RenderOverflow::maxXLayoutOverflow): |
+ (WebCore::RenderOverflow::minYVisualOverflow): |
+ (WebCore::RenderOverflow::maxYVisualOverflow): |
+ (WebCore::RenderOverflow::minXVisualOverflow): |
+ (WebCore::RenderOverflow::maxXVisualOverflow): |
+ (WebCore::RenderOverflow::setminYVisualOverflow): |
+ (WebCore::RenderOverflow::visualOverflowRect): |
+ (WebCore::RenderOverflow::move): |
+ (WebCore::RenderOverflow::addVisualOverflow): |
+ (WebCore::RenderOverflow::setVisualOverflow): |
+ * rendering/RenderReplaced.cpp: |
+ (WebCore::RenderReplaced::shouldPaint): |
+ * rendering/RenderTable.cpp: |
+ (WebCore::RenderTable::layout): |
+ (WebCore::RenderTable::paint): |
+ * rendering/RenderTableCell.cpp: |
+ (WebCore::RenderTableCell::clippedOverflowRectForRepaint): |
+ * rendering/RenderTreeAsText.cpp: |
+ (WebCore::writeLayers): |
+ * rendering/RenderView.cpp: |
+ (WebCore::RenderView::docTop): |
+ |
+2011-02-02 Steve Lacey <sjl@chromium.org> |
+ |
+ Reviewed by Eric Carlson. |
+ |
+ Implement basic media statistics on media elements. |
+ https://bugs.webkit.org/show_bug.cgi?id=53322 |
+ |
+ * Configurations/FeatureDefines.xcconfig: |
+ * GNUmakefile.am: |
+ * features.pri: |
+ * html/HTMLMediaElement.cpp: |
+ (WebCore::HTMLMediaElement::webkitAudioBytesDecoded): |
+ (WebCore::HTMLMediaElement::webkitVideoBytesDecoded): |
+ * html/HTMLMediaElement.h: |
+ * html/HTMLMediaElement.idl: |
+ * html/HTMLVideoElement.cpp: |
+ (WebCore::HTMLVideoElement::webkitDecodedFrames): |
+ (WebCore::HTMLVideoElement::webkitDroppedFrames): |
+ * html/HTMLVideoElement.h: |
+ * html/HTMLVideoElement.idl: |
+ * platform/graphics/MediaPlayer.cpp: |
+ (WebCore::MediaPlayer::decodedFrames): |
+ (WebCore::MediaPlayer::droppedFrames): |
+ (WebCore::MediaPlayer::audioBytesDecoded): |
+ (WebCore::MediaPlayer::videoBytesDecoded): |
+ * platform/graphics/MediaPlayer.h: |
+ * platform/graphics/MediaPlayerPrivate.h: |
+ (WebCore::MediaPlayerPrivateInterface::decodedFrames): |
+ (WebCore::MediaPlayerPrivateInterface::droppedFrames): |
+ (WebCore::MediaPlayerPrivateInterface::audioBytesDecoded): |
+ (WebCore::MediaPlayerPrivateInterface::videoBytesDecoded): |
+ |
+2011-02-02 Luiz Agostini <luiz.agostini@openbossa.org> |
+ |
+ Reviewed by David Hyatt. |
+ |
+ More conversion from right()/bottom() to maxX()/maxY(). |
+ |
+ * page/qt/FrameQt.cpp: |
+ (WebCore::Frame::dragImageForSelection): |
+ * platform/graphics/qt/GraphicsContextQt.cpp: |
+ (WebCore::GraphicsContext::roundToDevicePixels): |
+ |
+2011-02-02 Kevin Ollivier <kevino@theolliviers.com> |
+ |
+ [wx] Build fixes for wxWebKit. |
+ |
+ * bindings/cpp/WebDOMHTMLDocumentCustom.cpp: |
+ (documentWrite): |
+ * bindings/scripts/CodeGeneratorCPP.pm: |
+ * page/wx/DragControllerWx.cpp: |
+ (WebCore::DragController::dragOperation): |
+ * platform/graphics/wx/FontCustomPlatformData.h: |
+ * platform/graphics/wx/FontPlatformData.h: |
+ (WebCore::FontPlatformData::widthVariant): |
+ * platform/graphics/wx/FontPlatformDataWx.cpp: |
+ (WebCore::FontPlatformData::computeHash): |
+ * platform/graphics/wx/FontWx.cpp: |
+ * platform/graphics/wx/GraphicsContextWx.cpp: |
+ (WebCore::GraphicsContext::fillPath): |
+ (WebCore::GraphicsContext::strokePath): |
+ * platform/wx/RenderThemeWx.cpp: |
+ |
+2011-02-02 David Hyatt <hyatt@apple.com> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ More right()/bottom() to maxX()/maxY() conversion. |
+ |
+ * page/chromium/FrameChromium.cpp: |
+ (WebCore::Frame::nodeImage): |
+ (WebCore::Frame::dragImageForSelection): |
+ |
+2011-02-02 Sam Weinig <sam@webkit.org> |
+ |
+ Fix windows clean build. |
+ |
+ * DerivedSources.make: |
+ |
+2011-02-02 Mikhail Naganov <mnaganov@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: [Chromium] Landing detailed heap snapshots, part 2. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=53606 |
+ |
+ Display progress while taking a snapshot, and hints while loading |
+ and parsing. This is needed because taking detailed heap snapshots |
+ takes time. |
+ |
+ * English.lproj/localizedStrings.js: |
+ * inspector/front-end/DetailedHeapshotView.js: |
+ (WebInspector.DetailedHeapshotProfileType.prototype.buttonClicked): |
+ * inspector/front-end/ProfilesPanel.js: |
+ (WebInspector.ProfilesPanel.prototype._reset): |
+ (WebInspector.ProfilesPanel.prototype._addProfileHeader): |
+ (WebInspector.ProfilesPanel.prototype.getProfiles): |
+ (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot): |
+ (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse): |
+ (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot): |
+ (WebInspector.ProfilesPanel.prototype.takeHeapSnapshot): |
+ (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress): |
+ * inspector/front-end/SidebarTreeElement.js: |
+ (WebInspector.SidebarTreeElement.prototype.refreshTitles): |
+ |
+2011-02-02 David Hyatt <hyatt@apple.com> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ More conversion from right()/bottom() to maxX()/maxY(). |
+ |
+ * platform/win/PopupMenuWin.cpp: |
+ (WebCore::PopupMenuWin::calculatePositionAndSize): |
+ (WebCore::PopupMenuWin::paint): |
+ |
+2011-02-02 David Hyatt <hyatt@apple.com> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Removal of right()/bottom(). Replace with maxX() and maxY(). Still converting. Haven't removed yet. |
+ |
+ * platform/chromium/PopupMenuChromium.cpp: |
+ (WebCore::PopupContainer::layoutAndCalculateWidgetRect): |
+ (WebCore::PopupListBox::scrollToRevealRow): |
+ (WebCore::PopupListBox::layout): |
+ * platform/graphics/FloatRect.h: |
+ * platform/graphics/IntRect.h: |
+ * platform/graphics/cairo/ImageBufferCairo.cpp: |
+ (WebCore::getImageData): |
+ (WebCore::putImageData): |
+ * platform/graphics/chromium/GLES2Canvas.cpp: |
+ (WebCore::GLES2Canvas::drawTexturedRect): |
+ * platform/graphics/chromium/LayerRendererChromium.cpp: |
+ (WebCore::LayerRendererChromium::verticalScrollbarRect): |
+ (WebCore::LayerRendererChromium::horizontalScrollbarRect): |
+ (WebCore::LayerRendererChromium::setScissorToRect): |
+ (WebCore::LayerRendererChromium::setDrawViewportRect): |
+ * platform/graphics/chromium/LayerTilerChromium.cpp: |
+ (WebCore::LayerTilerChromium::contentRectToTileIndices): |
+ (WebCore::LayerTilerChromium::growLayerToContain): |
+ * platform/graphics/gpu/TilingData.cpp: |
+ (WebCore::TilingData::tileBoundsWithBorder): |
+ (WebCore::TilingData::overlappedTileIndices): |
+ * platform/graphics/qt/ImageBufferQt.cpp: |
+ (WebCore::getImageData): |
+ (WebCore::putImageData): |
+ * platform/graphics/skia/FloatRectSkia.cpp: |
+ (WebCore::FloatRect::operator SkRect): |
+ * platform/graphics/skia/ImageBufferSkia.cpp: |
+ (WebCore::getImageData): |
+ (WebCore::putImageData): |
+ * platform/graphics/skia/IntRectSkia.cpp: |
+ (WebCore::IntRect::operator SkIRect): |
+ (WebCore::IntRect::operator SkRect): |
+ * platform/graphics/skia/PlatformContextSkia.cpp: |
+ (WebCore::PlatformContextSkia::beginLayerClippedToImage): |
+ * platform/graphics/win/GraphicsContextWin.cpp: |
+ (WebCore::GraphicsContextPlatformPrivate::clip): |
+ * platform/graphics/win/IntRectWin.cpp: |
+ (WebCore::IntRect::operator RECT): |
+ * platform/graphics/win/UniscribeController.cpp: |
+ (WebCore::UniscribeController::shapeAndPlaceItem): |
+ * platform/graphics/wince/GraphicsContextWinCE.cpp: |
+ (WebCore::roundRect): |
+ (WebCore::mapRect): |
+ (WebCore::TransparentLayerDC::TransparentLayerDC): |
+ (WebCore::GraphicsContext::drawRect): |
+ (WebCore::GraphicsContext::drawEllipse): |
+ (WebCore::GraphicsContext::strokeArc): |
+ (WebCore::GraphicsContext::clip): |
+ (WebCore::GraphicsContext::clipOut): |
+ (WebCore::GraphicsContext::strokeRect): |
+ * platform/image-decoders/gif/GIFImageDecoder.cpp: |
+ (WebCore::GIFImageDecoder::initFrameBuffer): |
+ * platform/win/PopupMenuWin.cpp: |
+ (WebCore::PopupMenuWin::calculatePositionAndSize): |
+ (WebCore::PopupMenuWin::paint): |
+ * plugins/win/PluginViewWin.cpp: |
+ (WebCore::PluginView::updatePluginWidget): |
+ (WebCore::PluginView::invalidateRect): |
+ * rendering/RenderThemeSafari.cpp: |
+ (WebCore::RenderThemeSafari::paintMenuListButtonGradients): |
+ (WebCore::RenderThemeSafari::paintMenuListButton): |
+ (WebCore::RenderThemeSafari::paintSliderTrack): |
+ * rendering/RenderThemeWin.cpp: |
+ (WebCore::RenderThemeWin::paintInnerSpinButton): |
+ (WebCore::RenderThemeWin::paintMenuListButton): |
+ |
+2011-02-02 Antti Koivisto <antti@apple.com> |
+ |
+ Reviewed by Maciej Stachowiak. |
+ |
+ Use Vector instead of a linked list for rules in CSSStyleSelector |
+ https://bugs.webkit.org/show_bug.cgi?id=53581 |
+ |
+ - eliminate CSSRuleDataList, replace with Vector<RuleData> |
+ - rename CSSRuleData -> RuleData and CSSRuleSet -> RuleSet |
+ (these are selector internal classes, CSS prefix is better reserved for public ones). |
+ - constify a bit |
+ - shrink the vectors to fit after collecting the rules |
+ |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::RuleData::RuleData): |
+ (WebCore::RuleData::position): |
+ (WebCore::RuleData::rule): |
+ (WebCore::RuleData::selector): |
+ (WebCore::RuleSet::disableAutoShrinkToFit): |
+ (WebCore::RuleSet::getIDRules): |
+ (WebCore::RuleSet::getClassRules): |
+ (WebCore::RuleSet::getTagRules): |
+ (WebCore::RuleSet::getPseudoRules): |
+ (WebCore::RuleSet::getUniversalRules): |
+ (WebCore::RuleSet::getPageRules): |
+ (WebCore::collectSiblingRulesInDefaultStyle): |
+ (WebCore::CSSStyleSelector::CSSStyleSelector): |
+ (WebCore::loadFullDefaultStyle): |
+ (WebCore::loadSimpleDefaultStyle): |
+ (WebCore::loadViewSourceStyle): |
+ (WebCore::CSSStyleSelector::matchRules): |
+ (WebCore::CSSStyleSelector::matchRulesForList): |
+ (WebCore::operator >): |
+ (WebCore::operator <=): |
+ (WebCore::CSSStyleSelector::sortMatchedRules): |
+ (WebCore::CSSStyleSelector::matchUARules): |
+ (WebCore::RuleSet::RuleSet): |
+ (WebCore::RuleSet::~RuleSet): |
+ (WebCore::RuleSet::addToRuleSet): |
+ (WebCore::RuleSet::addRule): |
+ (WebCore::RuleSet::addPageRule): |
+ (WebCore::RuleSet::addRulesFromSheet): |
+ (WebCore::RuleSet::addStyleRule): |
+ (WebCore::collectIdsAndSiblingRulesFromList): |
+ (WebCore::RuleSet::collectIdsAndSiblingRules): |
+ (WebCore::shrinkMapVectorsToFit): |
+ (WebCore::RuleSet::shrinkToFit): |
+ (WebCore::CSSStyleSelector::matchPageRules): |
+ (WebCore::CSSStyleSelector::matchPageRulesForList): |
+ * css/CSSStyleSelector.h: |
+ (WebCore::CSSStyleSelector::addMatchedRule): |
+ |
+2011-02-02 Andrey Adaikin <aandrey@google.com> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: Use DIVs instead of TABLE in TextViewer |
+ https://bugs.webkit.org/show_bug.cgi?id=53299 |
+ |
+ * inspector/front-end/SourceFrame.js: |
+ (WebInspector.SourceFrame.prototype._createTextViewer): |
+ (WebInspector.SourceFrame.prototype._mouseDown): |
+ * inspector/front-end/TextViewer.js: |
+ (WebInspector.TextViewer): |
+ (WebInspector.TextViewer.prototype.set mimeType): |
+ (WebInspector.TextViewer.prototype.revealLine): |
+ (WebInspector.TextViewer.prototype.addDecoration): |
+ (WebInspector.TextViewer.prototype.removeDecoration): |
+ (WebInspector.TextViewer.prototype.markAndRevealRange): |
+ (WebInspector.TextViewer.prototype.highlightLine): |
+ (WebInspector.TextViewer.prototype.clearLineHighlight): |
+ (WebInspector.TextViewer.prototype.freeCachedElements): |
+ (WebInspector.TextViewer.prototype._handleKeyDown): |
+ (WebInspector.TextViewer.prototype.editLine.finishEditing): |
+ (WebInspector.TextViewer.prototype.editLine): |
+ (WebInspector.TextViewer.prototype.beginUpdates): |
+ (WebInspector.TextViewer.prototype.endUpdates): |
+ (WebInspector.TextViewer.prototype.resize): |
+ (WebInspector.TextViewer.prototype._textChanged): |
+ (WebInspector.TextViewer.prototype._updatePanelOffsets): |
+ (WebInspector.TextViewer.prototype._syncScroll): |
+ (WebInspector.TextViewer.prototype._syncDecorationsForLine): |
+ (WebInspector.TextEditorChunkedPanel): |
+ (WebInspector.TextEditorChunkedPanel.prototype.set syncScrollListener): |
+ (WebInspector.TextEditorChunkedPanel.prototype.get textModel): |
+ (WebInspector.TextEditorChunkedPanel.prototype.addDecoration): |
+ (WebInspector.TextEditorChunkedPanel.prototype.removeDecoration): |
+ (WebInspector.TextEditorChunkedPanel.prototype.revealLine): |
+ (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk): |
+ (WebInspector.TextEditorChunkedPanel.prototype.textChanged): |
+ (WebInspector.TextEditorChunkedPanel.prototype.beginUpdates): |
+ (WebInspector.TextEditorChunkedPanel.prototype.endUpdates): |
+ (WebInspector.TextEditorChunkedPanel.prototype.resize): |
+ (WebInspector.TextEditorChunkedPanel.prototype._scroll): |
+ (WebInspector.TextEditorChunkedPanel.prototype._scheduleRepaintAll): |
+ (WebInspector.TextEditorChunkedPanel.prototype._buildChunks): |
+ (WebInspector.TextEditorChunkedPanel.prototype._repaintAll): |
+ (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine): |
+ (WebInspector.TextEditorChunkedPanel.prototype._chunkForLine): |
+ (WebInspector.TextEditorGutterPanel): |
+ (WebInspector.TextEditorGutterPanel.prototype.freeCachedElements): |
+ (WebInspector.TextEditorGutterPanel.prototype._createNewChunk): |
+ (WebInspector.TextEditorGutterPanel.prototype._expandChunks): |
+ (WebInspector.TextEditorGutterChunk): |
+ (WebInspector.TextEditorGutterChunk.prototype.get expanded): |
+ (WebInspector.TextEditorGutterChunk.prototype.set expanded): |
+ (WebInspector.TextEditorGutterChunk.prototype.get height): |
+ (WebInspector.TextEditorGutterChunk.prototype._createRow): |
+ (WebInspector.TextEditorMainPanel): |
+ (WebInspector.TextEditorMainPanel.prototype.set syncDecorationsForLine): |
+ (WebInspector.TextEditorMainPanel.prototype.set mimeType): |
+ (WebInspector.TextEditorMainPanel.prototype.markAndRevealRange): |
+ (WebInspector.TextEditorMainPanel.prototype.highlightLine): |
+ (WebInspector.TextEditorMainPanel.prototype.clearLineHighlight): |
+ (WebInspector.TextEditorMainPanel.prototype.freeCachedElements): |
+ (WebInspector.TextEditorMainPanel.prototype._buildChunks): |
+ (WebInspector.TextEditorMainPanel.prototype._createNewChunk): |
+ (WebInspector.TextEditorMainPanel.prototype._expandChunks): |
+ (WebInspector.TextEditorMainPanel.prototype._highlightDataReady): |
+ (WebInspector.TextEditorMainPanel.prototype._paintLines): |
+ (WebInspector.TextEditorMainPanel.prototype._paintLine): |
+ (WebInspector.TextEditorMainPanel.prototype._releaseLinesHighlight): |
+ (WebInspector.TextEditorMainPanel.prototype._getSelection): |
+ (WebInspector.TextEditorMainPanel.prototype._restoreSelection): |
+ (WebInspector.TextEditorMainPanel.prototype._selectionToPosition): |
+ (WebInspector.TextEditorMainPanel.prototype._positionToSelection): |
+ (WebInspector.TextEditorMainPanel.prototype._appendTextNode): |
+ (WebInspector.TextEditorMainPanel.prototype._handleDomUpdates): |
+ (WebInspector.TextEditorMainChunk): |
+ (WebInspector.TextEditorMainChunk.prototype.addDecoration): |
+ (WebInspector.TextEditorMainChunk.prototype.set expanded): |
+ (WebInspector.TextEditorMainChunk.prototype.get height): |
+ (WebInspector.TextEditorMainChunk.prototype.getExpandedLineRow): |
+ (WebInspector.TextEditorMainChunk.prototype._createRow): |
+ (WebInspector): |
+ * inspector/front-end/textViewer.css: |
+ (.text-editor-lines): |
+ (.text-editor-contents): |
+ (.text-editor-editable): |
+ (.webkit-line-decorations): |
+ (.webkit-line-number): |
+ (.webkit-execution-line.webkit-line-content): |
+ (.diff-container .webkit-added-line.webkit-line-content): |
+ (.diff-container .webkit-removed-line.webkit-line-content): |
+ (.diff-container .webkit-changed-line.webkit-line-content): |
+ (.webkit-highlighted-line.webkit-line-content): |
+ |
+2011-02-02 Hans Wennborg <hans@chromium.org> |
+ |
+ Reviewed by Jeremy Orlow. |
+ |
+ IndexedDB: Implement support for cursor updates |
+ https://bugs.webkit.org/show_bug.cgi?id=53421 |
+ |
+ Implement support for cursor updates using the same pattern as cursor |
+ deletes: forward the calls to the IDBObjectStoreBackend::put(). |
+ The put() function's signature needs to be changed to allow for a |
+ "cursor update mode". This makes the signature more clear anyway, |
+ since it replaces the boolean parameter. |
+ |
+ Test: storage/indexeddb/cursor-update.html |
+ |
+ * storage/IDBCursor.idl: |
+ * storage/IDBCursorBackendImpl.cpp: |
+ (WebCore::IDBCursorBackendImpl::key): |
+ (WebCore::IDBCursorBackendImpl::update): |
+ * storage/IDBCursorBackendImpl.h: |
+ * storage/IDBObjectStore.cpp: |
+ (WebCore::IDBObjectStore::add): |
+ (WebCore::IDBObjectStore::put): |
+ * storage/IDBObjectStoreBackendImpl.cpp: |
+ (WebCore::IDBObjectStoreBackendImpl::put): |
+ (WebCore::IDBObjectStoreBackendImpl::putInternal): |
+ * storage/IDBObjectStoreBackendImpl.h: |
+ * storage/IDBObjectStoreBackendInterface.h: |
+ |
+2011-02-02 Naoki Takano <takano.naoki@gmail.com> |
+ |
+ Reviewed by Kent Tamura. |
+ |
+ Fix popup menu RTL bug introduced by Changeset 75982. |
+ https://bugs.webkit.org/show_bug.cgi?id=53567 |
+ |
+ PopupMenuChromium::layout() calculates X position according to RTL or not. So Change the X position calculation in layoutAndCalculateWidgetRect(). |
+ |
+ No new tests. However we can check manually with select_dropdown_box_alignment.html, autofill_alignment.html, select_alignment.html, select_dropdown_box_alignment.html, autofill-popup-width-and-item-direction.html |
+ |
+ * platform/chromium/PopupMenuChromium.cpp: |
+ (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Fix calculation of x position, because layout() considers RTL. And change the parameter from both X and Y positions to only Y position. |
+ (WebCore::PopupContainer::showPopup): Change the passing parameter. |
+ (WebCore::PopupContainer::refresh): Change the passing parameter. |
+ * platform/chromium/PopupMenuChromium.h: Change the parameter declaration. |
+ |
+2011-02-02 Alejandro G. Castro <alex@igalia.com> |
+ |
+ Reviewed by Martin Robinson. |
+ |
+ [GTK] Fix dist compilation |
+ https://bugs.webkit.org/show_bug.cgi?id=53579 |
+ |
+ * GNUmakefile.am: Added FontWidthVariant.h to the sources, it was |
+ added in r77153. |
+ |
+2011-02-02 Dai Mikurube <dmikurube@google.com> |
+ |
+ Reviewed by David Levin. |
+ |
+ Make mime type lookup in File::create(path) thread-safe |
+ https://bugs.webkit.org/show_bug.cgi?id=47700 |
+ |
+ This patch introduces a new function MIMETypeRegistry::getMIMETypeForExtensionThreadSafe(). |
+ The function is to be called as a thread-safe version of getMIMETypeForExtension() when |
+ both FILE_SYSTEM and WORKERS are enabled. |
+ |
+ No tests for this patch. This patch itself doesn't change the behaviors. |
+ For Chromium, it runs in the same way with getMIMETypeForExtensionThreadSafe(). |
+ For the other platforms, it causes compilation error in case of enabled FILE_SYSTEM and WORKERS. |
+ The compilation error would be a signal to implement getMIMETypeForExtensionThreadSafe() in these |
+ platforms. Currently it doesn't happen since FILE_SYSTEM is not available in the other platforms. |
+ |
+ * platform/MIMETypeRegistry.cpp: Defined generic getMIMETypeForExtension() calling getMIMETypeForExtensionThreadSafe() for enabled FILE_SYSTEM and WORKERS. |
+ (WebCore::MIMETypeRegistry::getMIMETypeForExtension): |
+ * platform/MIMETypeRegistry.h: Declared getMIMETypeForExtensionThreadSafe() which should be implemented for each platform. |
+ * platform/android/TemporaryLinkStubs.cpp: |
+ (WebCore::MIMETypeRegistry::getMIMETypeForExtension): |
+ * platform/brew/MIMETypeRegistryBrew.cpp: |
+ (WebCore::MIMETypeRegistry::getMIMETypeForExtension): |
+ * platform/chromium/MIMETypeRegistryChromium.cpp: Defined getMIMETypeForExtensionThreadSafe() for the case when FILE_SYSTEM and WORKERS are enabled. |
+ (WebCore::MIMETypeRegistry::getMIMETypeForExtensionThreadSafe): |
+ * platform/efl/MIMETypeRegistryEfl.cpp: |
+ (WebCore::MIMETypeRegistry::getMIMETypeForExtension): |
+ * platform/gtk/MIMETypeRegistryGtk.cpp: |
+ (WebCore::MIMETypeRegistry::getMIMETypeForExtension): |
+ * platform/haiku/MIMETypeRegistryHaiku.cpp: |
+ (WebCore::MIMETypeRegistry::getMIMETypeForExtension): |
+ * platform/mac/MIMETypeRegistryMac.mm: |
+ (WebCore::MIMETypeRegistry::getMIMETypeForExtension): |
+ * platform/qt/MIMETypeRegistryQt.cpp: |
+ (WebCore::MIMETypeRegistry::getMIMETypeForExtension): |
+ * platform/win/MIMETypeRegistryWin.cpp: |
+ (WebCore::MIMETypeRegistry::getMIMETypeForExtension): |
+ * platform/wince/MIMETypeRegistryWinCE.cpp: |
+ (WebCore::MIMETypeRegistry::getMIMETypeForExtension): |
+ * platform/wx/MimeTypeRegistryWx.cpp: |
+ (WebCore::MIMETypeRegistry::getMIMETypeForExtension): |
+ |
+2011-02-01 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Alexey Proskuryakov. |
+ |
+ Improve readability of updateWidget by converting bool parameter to an enum |
+ https://bugs.webkit.org/show_bug.cgi?id=53576 |
+ |
+ As requested on webkit-dev. |
+ |
+ * html/HTMLEmbedElement.cpp: |
+ (WebCore::HTMLEmbedElement::updateWidget): |
+ * html/HTMLEmbedElement.h: |
+ * html/HTMLMediaElement.cpp: |
+ (WebCore::HTMLMediaElement::updateWidget): |
+ * html/HTMLMediaElement.h: |
+ * html/HTMLObjectElement.cpp: |
+ (WebCore::HTMLObjectElement::updateWidget): |
+ * html/HTMLObjectElement.h: |
+ * html/HTMLPlugInImageElement.cpp: |
+ (WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary): |
+ * html/HTMLPlugInImageElement.h: |
+ * page/FrameView.cpp: |
+ (WebCore::FrameView::updateWidget): |
+ |
+2011-02-01 James Robinson <jamesr@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ [v8] Increase V8 native->js recursion limit to match document.write() recursion limit |
+ https://bugs.webkit.org/show_bug.cgi?id=53566 |
+ |
+ A recursion limit of 22 is necessary to pass fast/dom/Document/document-write-recursion.html. |
+ Other than being large enough for this one test case, this limit is arbitrary. |
+ |
+ * bindings/v8/V8Proxy.h: |
+ |
+2011-02-01 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ Remove useless comment |
+ https://bugs.webkit.org/show_bug.cgi?id=53549 |
+ |
+ The reason for this parameter is captured in |
+ plugins/netscape-plugin-setwindow-size.html, which is a better place to |
+ capture it than in this comment (which otherwise just re-iterates the |
+ name of the parameter). |
+ |
+ * html/HTMLPlugInImageElement.cpp: |
+ (WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary): |
+ |
+2011-02-01 James Simonsen <simonjam@chromium.org> |
+ |
+ Reviewed by Tony Gentilcore. |
+ |
+ [WebTiming] Remove asserts that verify timestamp order |
+ https://bugs.webkit.org/show_bug.cgi?id=53548 |
+ |
+ Covered by existing tests. |
+ |
+ * loader/FrameLoader.cpp: |
+ (WebCore::FrameLoader::stopLoading): Remove assert. |
+ * page/DOMWindow.cpp: |
+ (WebCore::DOMWindow::dispatchTimedEvent): Ditto. |
+ |
+2011-02-01 Dimitri Glazkov <dglazkov@chromium.org> |
+ |
+ Add the 'default_targets' enclosure to the flags. |
+ |
+ * WebCore.gyp/WebCore.gyp: Did it. |
+ |
2011-02-01 Mihai Parparita <mihaip@chromium.org> |
Reviewed by James Robinson. |