Issue 6250177: Move reverting code from gclient_scm to scm to be able to reuse the code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6250177: Move reverting code from gclient_scm to scm to be able to reuse the code. (Closed)

Created:
9 years, 10 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, M-A Ruel, Peter Mayo (wrong one)

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Move reverting code from gclient_scm to scm to be able to reuse the code. There is 2 changes while moving the code: - Making externals handling an option. - Not trapping EnvironmentError. This code will be reused by the commit queue. TEST=unit tests BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74181

Patch Set 1 #

Patch Set 2 : Don't trap weirdo exceptions #

Patch Set 3 : Fix presubmit check #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -37 lines)			Patch
M	gclient_scm.py	View	1	1 chunk	+7 lines, -34 lines	0 comments	Download
M	presubmit_canned_checks.py	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	scm.py	View	1	2 chunks	+46 lines, -0 lines	0 comments	Download
M	tests/scm_unittest.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages