presubmit_canned_checks.py - Issue 6250177: Move reverting code from gclient_scm to scm to be able to reuse the code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 6250177: Move reverting code from gclient_scm to scm to be able to reuse the code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Fix presubmit check Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index 5c268ef087bbd89fa86ca64592be700ace693f97..79e030918bef92254281b482f52ec1a7f892236b 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -237,7 +237,7 @@ def CheckChangeHasNoTabs(input_api, output_api, source_file_filter=None):

def CheckChangeTodoHasOwner(input_api, output_api, source_file_filter=None):

"""Checks that the user didn't add TODO(name) without an owner."""

- unowned_todo = input_api.re.compile('TO' + 'DO[^(]');

+ unowned_todo = input_api.re.compile('TO' + 'DO[^(]')

for f, line_num, line in input_api.RightHandSideLines(source_file_filter):

if unowned_todo.search(line):

text = ('Found TO' + 'DO with no owner in %s, line %s' %

« no previous file with comments | « gclient_scm.py ('k') | scm.py » ('j') | no next file with comments »