Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6250088: Cleanup everything but net/ for our first clang plugins. (Closed)

Created:
9 years, 10 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
Reviewers:
dmac, Nico
CC:
chromium-reviews, ncarter (slow), Alpha Left Google, idana, Sergey Ulanov, James Hawkins, brettw-cc_chromium.org, apatrick_chromium, darin-cc_chromium.org, awong, garykac, Raghu Simha, pam+watch_chromium.org, Ilya Sherman, tim (not reviewing), dhollowa
Visibility:
Public.

Description

Cleanup everything but net/ for our first clang plugins. BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73396

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -64 lines) Patch
M chrome/browser/autofill/form_structure.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/autofill/form_structure.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/engine/syncer_thread.h View 2 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/sync/engine/syncer_thread.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/sync/js_arg_list.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/js_arg_list.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/sessions/session_state.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/sessions/session_state.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_observer.h View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/tab_contents/tab_contents_observer.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M jingle/notifier/base/fake_base_task.h View 1 chunk +1 line, -0 lines 0 comments Download
M jingle/notifier/base/fake_base_task.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/client/x11_input_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webmenuitem.h View 1 chunk +5 lines, -11 lines 2 comments Download
A webkit/glue/webmenuitem.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.h View 1 chunk +1 line, -12 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/resource_tracker.h View 1 chunk +1 line, -11 lines 0 comments Download
M webkit/plugins/ppapi/resource_tracker.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M webkit/support/test_webkit_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/support/test_webplugin_page_delegate.h View 2 chunks +2 lines, -9 lines 0 comments Download
A webkit/support/test_webplugin_page_delegate.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M webkit/support/webkit_support.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/support/weburl_loader_mock_factory.h View 2 chunks +3 lines, -6 lines 0 comments Download
M webkit/support/weburl_loader_mock_factory.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webmimeregistry_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webmimeregistry_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
9 years, 10 months ago (2011-02-01 23:21:05 UTC) #1
Nico
LG http://codereview.chromium.org/6250088/diff/1/webkit/glue/webmenuitem.h File webkit/glue/webmenuitem.h (right): http://codereview.chromium.org/6250088/diff/1/webkit/glue/webmenuitem.h#newcode26 webkit/glue/webmenuitem.h:26: WebMenuItem(const WebMenuItem& item); This one is new?
9 years, 10 months ago (2011-02-02 01:00:23 UTC) #2
dmac
On 2011/02/01 23:21:05, Elliot Glaysher wrote: Change to remoting/client/x11_input_handler.h LGTM
9 years, 10 months ago (2011-02-02 01:05:02 UTC) #3
Elliot Glaysher
9 years, 10 months ago (2011-02-02 01:09:26 UTC) #4 
http://codereview.chromium.org/6250088/diff/1/webkit/glue/webmenuitem.h
File webkit/glue/webmenuitem.h (right):

http://codereview.chromium.org/6250088/diff/1/webkit/glue/webmenuitem.h#newco...
webkit/glue/webmenuitem.h:26: WebMenuItem(const WebMenuItem& item);
On 2011/02/02 01:00:23, Nico wrote:
> This one is new?

Correct. std::vector<> calls the copy constructor and if we're publicly exposing
a std::vector<WebMenuItem>, we'll probably want to use this instead of the
compiler's autogenerated one.

Powered by Google App Engine
This is Rietveld 408576698